From patchwork Wed Oct 19 23:36:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Magnus Damm X-Patchwork-Id: 9385603 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6173F60487 for ; Wed, 19 Oct 2016 23:45:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 388C128B5D for ; Wed, 19 Oct 2016 23:45:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2C84B29087; Wed, 19 Oct 2016 23:45:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BCA9F28B5D for ; Wed, 19 Oct 2016 23:45:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932779AbcJSXoE (ORCPT ); Wed, 19 Oct 2016 19:44:04 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35115 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932777AbcJSXoC (ORCPT ); Wed, 19 Oct 2016 19:44:02 -0400 Received: by mail-pf0-f196.google.com with SMTP id s8so3680001pfj.2; Wed, 19 Oct 2016 16:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:date:message-id:in-reply-to:references:subject; bh=PZ6uJIBrrr8FT4IgOGmB+4dunxpYy/Kf36nz1DJMNLQ=; b=mDXtmqYe1Dq7uBrkLJpPqu9GRHL1RXY/0ylRFaLj4Z58natlDSiVK3IbQHk1aMOD3Q eyzAhqufktyyX1bbrhGejwZoZIo96/i1lvfIWk+0vWRvbjh2/4qeZCez1Ei1SlaohiXJ uBkpjSzmstr+sots5vIXl6Ahk/kLI7jKX2i8sEjY8s+vH9OIl0G4e9M50ygtk/6iF47P 1+Z3mCT2kt3hgbeEfLOFY9GdcOqeNvvmT2o3nNxjoAr5/As7IqMj61d3PRtsvPtcWzNV 9w4It0vG26NrOGMNa9XyMNrLgLG7w1X7VI6dZSdjBGQTGfm3r6ZOSeDSLSwkq2H7oGDa wZ3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:date:message-id:in-reply-to :references:subject; bh=PZ6uJIBrrr8FT4IgOGmB+4dunxpYy/Kf36nz1DJMNLQ=; b=DOgLkm/7uvbzhNhYh7YtLR/3UgQiT/hwdZIcI0krVtsBIk1+vqjjCWlCy1TLc46cjH XP9zQ3n5bKZe/f1xdeXarGjkVz83vfQl+KeWCEbiSI9bp5G10e74U8BMLCtIuGP4HNy3 nj1Ayi6waBJJAMZ4CcJyOEoyQ9OWsCE1PUziPLr0kwc9mLKiFKjAymZGtXCavzcQnNGY k23q3DNRAu/pbIKAJ7pNxGO1jP4OqQApO6npnf2+qBYdZafq4ZRDrhyuSuK414S05rl0 Iz1KtMo2jkHADGZ6xt+uxmaeluXpTXIH2A3UG77jM+58jCRMPYQKvt6Uj+Hk3sZ+KbjZ Cjdg== X-Gm-Message-State: AA6/9RnaEMxpNjIFjyVBq+7TISGe2dSBHmPDv7V1ChnxBvDGCtvY4RiJMsA8NiefCVRRJw== X-Received: by 10.98.80.130 with SMTP id g2mr15642824pfj.179.1476920637005; Wed, 19 Oct 2016 16:43:57 -0700 (PDT) Received: from [127.0.0.1] (s214090.ppp.asahi-net.or.jp. [220.157.214.90]) by smtp.gmail.com with ESMTPSA id fl4sm66480852pad.39.2016.10.19.16.43.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Oct 2016 16:43:55 -0700 (PDT) From: Magnus Damm To: iommu@lists.linux-foundation.org Cc: laurent.pinchart+renesas@ideasonboard.com, geert+renesas@glider.be, joro@8bytes.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, horms+renesas@verge.net.au, Magnus Damm , robin.murphy@arm.com, m.szyprowski@samsung.com Date: Thu, 20 Oct 2016 08:36:03 +0900 Message-Id: <20161019233603.10506.93030.sendpatchset@little-apple> In-Reply-To: <20161019233533.10506.16810.sendpatchset@little-apple> References: <20161019233533.10506.16810.sendpatchset@little-apple> Subject: [PATCH v6 03/07] iommu/ipmmu-vmsa: Break out utlb parsing code Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Magnus Damm Break out the utlb parsing code and dev_data allocation into a separate function. This is preparation for future code sharing. Signed-off-by: Magnus Damm Reviewed-by: Joerg Roedel --- Changes since V5: - None Changes since V4: - Dropped hunk with fix to apply on top of: b1e2afc iommu/ipmmu-vmsa: Fix wrong error handle of ipmmu_add_device Changes since V3: - Initialize "mmu" to NULL, check before accessing - Removed group parameter from ipmmu_init_platform_device() Changes since V2: - Included this new patch from the following series: [PATCH 00/04] iommu/ipmmu-vmsa: IPMMU CONFIG_IOMMU_DMA update - Reworked code to fit on top on previous two patches in current series. drivers/iommu/ipmmu-vmsa.c | 58 ++++++++++++++++++++++++++++---------------- 1 file changed, 37 insertions(+), 21 deletions(-) --- 0006/drivers/iommu/ipmmu-vmsa.c +++ work/drivers/iommu/ipmmu-vmsa.c 2016-09-20 21:49:34.580607110 +0900 @@ -647,22 +647,15 @@ static int ipmmu_find_utlbs(struct ipmmu return 0; } -static int ipmmu_add_device(struct device *dev) +static int ipmmu_init_platform_device(struct device *dev) { struct ipmmu_vmsa_archdata *archdata; struct ipmmu_vmsa_device *mmu; - struct iommu_group *group = NULL; unsigned int *utlbs; unsigned int i; int num_utlbs; int ret = -ENODEV; - if (dev->archdata.iommu) { - dev_warn(dev, "IOMMU driver already assigned to device %s\n", - dev_name(dev)); - return -EINVAL; - } - /* Find the master corresponding to the device. */ num_utlbs = of_count_phandle_with_args(dev->of_node, "iommus", @@ -699,6 +692,36 @@ static int ipmmu_add_device(struct devic } } + archdata = kzalloc(sizeof(*archdata), GFP_KERNEL); + if (!archdata) { + ret = -ENOMEM; + goto error; + } + + archdata->mmu = mmu; + archdata->utlbs = utlbs; + archdata->num_utlbs = num_utlbs; + dev->archdata.iommu = archdata; + return 0; + +error: + kfree(utlbs); + return ret; +} + +static int ipmmu_add_device(struct device *dev) +{ + struct ipmmu_vmsa_archdata *archdata; + struct ipmmu_vmsa_device *mmu = NULL; + struct iommu_group *group; + int ret; + + if (dev->archdata.iommu) { + dev_warn(dev, "IOMMU driver already assigned to device %s\n", + dev_name(dev)); + return -EINVAL; + } + /* Create a device group and add the device to it. */ group = iommu_group_alloc(); if (IS_ERR(group)) { @@ -716,16 +739,9 @@ static int ipmmu_add_device(struct devic goto error; } - archdata = kzalloc(sizeof(*archdata), GFP_KERNEL); - if (!archdata) { - ret = -ENOMEM; + ret = ipmmu_init_platform_device(dev); + if (ret < 0) goto error; - } - - archdata->mmu = mmu; - archdata->utlbs = utlbs; - archdata->num_utlbs = num_utlbs; - dev->archdata.iommu = archdata; /* * Create the ARM mapping, used by the ARM DMA mapping core to allocate @@ -736,6 +752,8 @@ static int ipmmu_add_device(struct devic * - Make the mapping size configurable ? We currently use a 2GB mapping * at a 1GB offset to ensure that NULL VAs will fault. */ + archdata = dev->archdata.iommu; + mmu = archdata->mmu; if (!mmu->mapping) { struct dma_iommu_mapping *mapping; @@ -760,10 +778,8 @@ static int ipmmu_add_device(struct devic return 0; error: - arm_iommu_release_mapping(mmu->mapping); - - kfree(dev->archdata.iommu); - kfree(utlbs); + if (mmu) + arm_iommu_release_mapping(mmu->mapping); dev->archdata.iommu = NULL;