| Message ID | 20161205174310.28802-1-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7d73a4da2681dc5d04e8ed9f4aa96c1deed2dbc5 |
| Headers | show |
On Mon, Dec 05, 2016 at 06:43:10PM +0100, Niklas Söderlund wrote: > The EthernetAVB should not depend on the bootloader to setup correct > drive-strength values. Values for drive-strength where found by > examining the registers after the bootloader has configured the > registers and successfully used the EthernetAVB. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> I believe this patch has run-time dependencies on PFC patches and will result in a regression without them. Please resubmit or otherwise ping me once chose changes are present in an (rc) release or immutable branch. Thanks!
On Mon, Dec 5, 2016 at 6:43 PM, Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote: > The EthernetAVB should not depend on the bootloader to setup correct > drive-strength values. Values for drive-strength where found by > examining the registers after the bootloader has configured the > registers and successfully used the EthernetAVB. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Simon, On 2016-12-08 14:31:38 +0100, Simon Horman wrote: > On Mon, Dec 05, 2016 at 06:43:10PM +0100, Niklas Söderlund wrote: > > The EthernetAVB should not depend on the bootloader to setup correct > > drive-strength values. Values for drive-strength where found by > > examining the registers after the bootloader has configured the > > registers and successfully used the EthernetAVB. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > I believe this patch has run-time dependencies on PFC patches and will > result in a regression without them. Please resubmit or otherwise ping me > once chose changes are present in an (rc) release or immutable branch. The dependency for this DT change is now present in v4.11-rc1, see 1. If it's convenient for you feel free to pick up this patch. 1. b25719eb938eb39a ("pinctrl: sh-pfc: r8a7795: Add group for AVB MDIO and MII pins") > > Thanks!
On Mon, Mar 06, 2017 at 12:28:18AM +0100, Niklas Söderlund wrote: > Hi Simon, > > On 2016-12-08 14:31:38 +0100, Simon Horman wrote: > > On Mon, Dec 05, 2016 at 06:43:10PM +0100, Niklas Söderlund wrote: > > > The EthernetAVB should not depend on the bootloader to setup correct > > > drive-strength values. Values for drive-strength where found by > > > examining the registers after the bootloader has configured the > > > registers and successfully used the EthernetAVB. > > > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > > > I believe this patch has run-time dependencies on PFC patches and will > > result in a regression without them. Please resubmit or otherwise ping me > > once chose changes are present in an (rc) release or immutable branch. > > The dependency for this DT change is now present in v4.11-rc1, see 1. If > it's convenient for you feel free to pick up this patch. > > 1. b25719eb938eb39a ("pinctrl: sh-pfc: r8a7795: Add group for AVB MDIO > and MII pins") Thanks Niklas, I am in the process of rebasing my branches on top of v4.11-rc1 and I have queued up this patch. It should appear in the next push of renesas-next and renesas-revel.
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts index b1eab68..784ced9 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts @@ -225,8 +225,22 @@ }; avb_pins: avb { - groups = "avb_mdc"; - function = "avb"; + mux { + groups = "avb_link", "avb_phy_int", "avb_mdc", + "avb_mii"; + function = "avb"; + }; + + pins_mdc { + groups = "avb_mdc"; + drive-strength = <24>; + }; + + pins_mii_tx { + pins = "PIN_AVB_TX_CTL", "PIN_AVB_TXC", "PIN_AVB_TD0", + "PIN_AVB_TD1", "PIN_AVB_TD2", "PIN_AVB_TD3"; + drive-strength = <12>; + }; }; du_pins: du {
The EthernetAVB should not depend on the bootloader to setup correct drive-strength values. Values for drive-strength where found by examining the registers after the bootloader has configured the registers and successfully used the EthernetAVB. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- Changes since v1: - Only set drive-strength for output pins, thanks Geert. - Add all used pin groups to the mux section. arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)