diff mbox

[3/3] ARM: dts: rskrza1: add ostm DT support

Message ID 20170112190108.2856-4-chris.brandt@renesas.com (mailing list archive)
State Superseded
Delegated to: Simon Horman
Headers show

Commit Message

Chris Brandt Jan. 12, 2017, 7:01 p.m. UTC
Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
---
 arch/arm/boot/dts/r7s72100-rskrza1.dts | 4 ++++
 arch/arm/boot/dts/r7s72100.dtsi        | 3 ++-
 2 files changed, 6 insertions(+), 1 deletion(-)

Comments

Geert Uytterhoeven Jan. 13, 2017, 8:40 a.m. UTC | #1
Hi Chris,

On Thu, Jan 12, 2017 at 8:01 PM, Chris Brandt <chris.brandt@renesas.com> wrote:
> --- a/arch/arm/boot/dts/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/r7s72100.dtsi
> @@ -513,7 +513,8 @@
>                 interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING
>                               GIC_SPI 103 IRQ_TYPE_EDGE_RISING>;
>
> -               clocks = <&mstp5_clks R7S72100_CLK_OSTM0>, <&mstp5_clks R7S72100_CLK_OSTM1>;
> +               clocks = <&mstp5_clks R7S72100_CLK_OSTM0>,
> +                        <&mstp5_clks R7S72100_CLK_OSTM1>;

I think this change should be folded into "[PATCH 2/3] ARM: dts: r7s72100: add
ostm to device tree" ;-)

>                 status = "disabled";
>         };
>  };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Sergei Shtylyov Jan. 13, 2017, 9:08 a.m. UTC | #2
Hello!

On 1/12/2017 10:01 PM, Chris Brandt wrote:

> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
[...]
> diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
> index 247bbe0..974c084 100644
> --- a/arch/arm/boot/dts/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/r7s72100.dtsi
> @@ -513,7 +513,8 @@
>  		interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING
>  			      GIC_SPI 103 IRQ_TYPE_EDGE_RISING>;
>
> -		clocks = <&mstp5_clks R7S72100_CLK_OSTM0>, <&mstp5_clks R7S72100_CLK_OSTM1>;
> +		clocks = <&mstp5_clks R7S72100_CLK_OSTM0>,
> +			 <&mstp5_clks R7S72100_CLK_OSTM1>;

    Unintended change?

>  		status = "disabled";
>  	};
>  };

MBR, Sergei
Chris Brandt Jan. 13, 2017, 2:50 p.m. UTC | #3
Hi Geert and Sergei,

On Friday, January 13, 2017, Geert Uytterhoeven wrote:
> On Thu, Jan 12, 2017 at 8:01 PM, Chris Brandt <chris.brandt@renesas.com>

> wrote:

> > --- a/arch/arm/boot/dts/r7s72100.dtsi

> > +++ b/arch/arm/boot/dts/r7s72100.dtsi

> > @@ -513,7 +513,8 @@

> >                 interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING

> >                               GIC_SPI 103 IRQ_TYPE_EDGE_RISING>;

> >

> > -               clocks = <&mstp5_clks R7S72100_CLK_OSTM0>, <&mstp5_clks

> R7S72100_CLK_OSTM1>;

> > +               clocks = <&mstp5_clks R7S72100_CLK_OSTM0>,

> > +                        <&mstp5_clks R7S72100_CLK_OSTM1>;

> 

> I think this change should be folded into "[PATCH 2/3] ARM: dts: r7s72100:

> add ostm to device tree" ;-)


Oops, I think I got things a little screwed up when git rebasing and
reordering and such.

Thanks for the review!

Chris
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts b/arch/arm/boot/dts/r7s72100-rskrza1.dts
index dd44181..e7b6afa 100644
--- a/arch/arm/boot/dts/r7s72100-rskrza1.dts
+++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts
@@ -61,6 +61,10 @@ 
 	status = "okay";
 };
 
+&ostm {
+	status = "okay";
+};
+
 &scif2 {
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index 247bbe0..974c084 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -513,7 +513,8 @@ 
 		interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING
 			      GIC_SPI 103 IRQ_TYPE_EDGE_RISING>;
 
-		clocks = <&mstp5_clks R7S72100_CLK_OSTM0>, <&mstp5_clks R7S72100_CLK_OSTM1>;
+		clocks = <&mstp5_clks R7S72100_CLK_OSTM0>,
+			 <&mstp5_clks R7S72100_CLK_OSTM1>;
 		status = "disabled";
 	};
 };