diff mbox

vsp-lib: Fix reference frame generation for HSV input formats

Message ID 20170213154656.30363-1-laurent.pinchart@ideasonboard.com (mailing list archive)
State Not Applicable
Delegated to: Geert Uytterhoeven
Headers show

Commit Message

Laurent Pinchart Feb. 13, 2017, 3:46 p.m. UTC
gen-image doesn't support processing HSV input frames. Fortunately the
HSV tests don't require it either, when they take an HSV input frame
they just pass it straight to the WPF. We can thus set the input format
to RGB for reference frame generation.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 scripts/vsp-lib.sh | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Kieran Bingham Feb. 20, 2017, 10:46 a.m. UTC | #1
Hi Laurent,

On 13/02/17 15:46, Laurent Pinchart wrote:
> gen-image doesn't support processing HSV input frames. Fortunately the
> HSV tests don't require it either, when they take an HSV input frame
> they just pass it straight to the WPF. We can thus set the input format
> to RGB for reference frame generation.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  scripts/vsp-lib.sh | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh
> index ae9683cffab6..695e081bf34d 100755
> --- a/scripts/vsp-lib.sh
> +++ b/scripts/vsp-lib.sh
> @@ -103,6 +103,16 @@ reference_frame() {
>  	local alpha=
>  	local options=
>  
> +	# gen-image doesn't support processing HSV input images. The good news
> +	# is that the HSV tests that take HSV images as inputs don't need to
> +	# perform any processing. We can set the input format to RGB for HSB

s/HSB/HSV/

> +	# reference frame generation.
> +	case $in_format in
> +	HSV24 | HSV32)
> +		in_format=ARGB32
> +		;;
> +	esac
> +
>  	# Start with the input format to compute the alpha value being used by
>  	# the RPF after unpacking. Keep in sync with generate_input_frame.
>  	case $in_format in

With that,

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
diff mbox

Patch

diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh
index ae9683cffab6..695e081bf34d 100755
--- a/scripts/vsp-lib.sh
+++ b/scripts/vsp-lib.sh
@@ -103,6 +103,16 @@  reference_frame() {
 	local alpha=
 	local options=
 
+	# gen-image doesn't support processing HSV input images. The good news
+	# is that the HSV tests that take HSV images as inputs don't need to
+	# perform any processing. We can set the input format to RGB for HSB
+	# reference frame generation.
+	case $in_format in
+	HSV24 | HSV32)
+		in_format=ARGB32
+		;;
+	esac
+
 	# Start with the input format to compute the alpha value being used by
 	# the RPF after unpacking. Keep in sync with generate_input_frame.
 	case $in_format in