From patchwork Sat Mar 18 20:52:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniu Rosca X-Patchwork-Id: 9632323 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A77E76024A for ; Sat, 18 Mar 2017 20:52:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8DDD126E76 for ; Sat, 18 Mar 2017 20:52:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7F8622833C; Sat, 18 Mar 2017 20:52:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ABD6526E76 for ; Sat, 18 Mar 2017 20:52:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751189AbdCRUw4 (ORCPT ); Sat, 18 Mar 2017 16:52:56 -0400 Received: from mail-wr0-f173.google.com ([209.85.128.173]:34416 "EHLO mail-wr0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbdCRUw4 (ORCPT ); Sat, 18 Mar 2017 16:52:56 -0400 Received: by mail-wr0-f173.google.com with SMTP id l37so70890735wrc.1 for ; Sat, 18 Mar 2017 13:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:subject:message-id:mime-version:content-disposition :user-agent; bh=m5SL1aP/JqLfLlefoHODT/pSnITPvpTbg7WGkj4Av6I=; b=r9btzCX9rTI24ocNqQEFmwJ6RJk3BsXUnFbpylGfkOPHZyUGb/YsHfYu3akpROQXCh 4uiECOWbjABtMOlsS3O9ujeFkr1cYtzLSyV6mb4zxRxNB7QAan8PY+yS9sIfq7LugedD r6/xxACQ+PrV92Jr8TLGnpe8rbwt4aKsnELa1/tDGcqaNm4M83U3D+zfbhFnmgYRas4Y oS4GcD191Aa6Tii33eIqeCfGjehP9dphvxNdjXzWKtCSoljbKJAYxkmZ2u0xUKZwRghD 6mkNhoTlwW9n5sv1pYJdgithT8LX3yQoNX38aQ7p5ta3mvoxkg/LHdjVeaUVz6+pE4aL twoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:subject:message-id:mime-version :content-disposition:user-agent; bh=m5SL1aP/JqLfLlefoHODT/pSnITPvpTbg7WGkj4Av6I=; b=JNwpV455Wma/h9H/fB4bGDz1QgLc12hAiCNIFZigjHeYVyNwwDu1VY0gmT3IHNk0pK AMejuFCjapzr+4LsMzxpoYsYtfXqKg9yIHOZI4j9HDHtUq1hWC1fxthadDTAEvj5/QwM 49JyNlgQ6TtM/hWohXgm/dEz0oC0JKqxj2zh0mqB6vA2CEjv+NlFATx4zJYWadbR2AmL 89RqWAT/mw6V93co0gBNRoBxaDe5UcA64LpZDfLvvSvVK5mV2lsTF0ke/eCd2lJ/6p2e a0IDJ7956q+fpEuh9QJ3/kEx53Z/Cp6+g6FqvZcYPRZty/MYn+H6pQ4ICUFPa7UEPgoc KTiw== X-Gm-Message-State: AFeK/H2viL5mrcX8OpotQG9yjqEk8ONX0s5b28S3xx0pQw1+tOidMx8m9XdsiLNKrWg26Q== X-Received: by 10.223.134.231 with SMTP id 36mr21026457wry.46.1489870348246; Sat, 18 Mar 2017 13:52:28 -0700 (PDT) Received: from x230 ([2a02:8108:91c0:4bcc:5578:3b50:6fe5:13fe]) by smtp.gmail.com with ESMTPSA id m188sm7445804wma.27.2017.03.18.13.52.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Mar 2017 13:52:27 -0700 (PDT) From: Eugeniu Rosca X-Google-Original-From: Eugeniu Rosca Date: Sat, 18 Mar 2017 21:52:26 +0100 To: laurent.pinchart@ideasonboard.com, geert+renesas@glider.be, linus.walleij@linaro.org, linux-renesas-soc@vger.kernel.org Subject: [PATCH] pinctrl: sh-pfc: Print correct pinmux info name Message-ID: <20170318205226.GA11403@x230> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From cce7953dac965d620bb4fe5a456cffe40793f39b Mon Sep 17 00:00:00 2001 From: Eugeniu Rosca Date: Tue, 28 Feb 2017 13:38:36 +0100 Subject: [PATCH] pinctrl: sh-pfc: Print correct pinmux info name commit 0c151062f32c ("sh-pfc: Add support for SoC-specific initialization") allows defining SoC specific init functions. Such custom functions can register new pinmux info structures. Here is an example: static int my_pinmux_init(struct sh_pfc *pfc) { if (my_criteria()) pfc->info = &new_pinmux_info; } A side effect of the pfc->info update in the above example is that the `const struct sh_pfc_soc_info *info` pointer used in the probe routine becomes outdated. One consequence of it is printing the wrong pinmux info structure name at the end of `sh_pfc_probe()`. Fix this. Signed-off-by: Eugeniu Rosca --- drivers/pinctrl/sh-pfc/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c index 6399eb1feb12..37fc70fb8e4d 100644 --- a/drivers/pinctrl/sh-pfc/core.c +++ b/drivers/pinctrl/sh-pfc/core.c @@ -703,7 +703,7 @@ static int sh_pfc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, pfc); - dev_info(pfc->dev, "%s support registered\n", info->name); + dev_info(pfc->dev, "%s support registered\n", pfc->info->name); return 0; } -- 2.12.0