| Message ID | 20170427191045.21199-1-chris.brandt@renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Thu, Apr 27, 2017 at 12:10:45PM -0700, Chris Brandt wrote: > This adds the USB0 and USB1 clocks to the device tree. > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> > --- > arch/arm/boot/dts/r7s72100.dtsi | 6 +++--- > include/dt-bindings/clock/r7s72100-clock.h | 2 ++ > 2 files changed, 5 insertions(+), 3 deletions(-) Hi Chris, could you break the .h patch out into a separate patch so that I can apply it to my dt-bindings branch? The reason for that branch is to allow better management of dependencies; something I got burnt by a few releases back. > > diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi > index fb54cb5d3fad..4ed12a4d9d51 100644 > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++ b/arch/arm/boot/dts/r7s72100.dtsi > @@ -144,9 +144,9 @@ > #clock-cells = <1>; > compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks"; > reg = <0xfcfe0430 4>; > - clocks = <&b_clk>; > - clock-indices = <R7S72100_CLK_ETHER>; > - clock-output-names = "ether"; > + clocks = <&b_clk>, <&p1_clk>, <&p1_clk>; > + clock-indices = <R7S72100_CLK_ETHER R7S72100_CLK_USB0 R7S72100_CLK_USB1>; > + clock-output-names = "ether", "usb0", "usb1"; The above looks fine to me although I was unable to find the USB parent clock in the documentation I have available. > }; > > mstp8_clks: mstp8_clks@fcfe0434 { > diff --git a/include/dt-bindings/clock/r7s72100-clock.h b/include/dt-bindings/clock/r7s72100-clock.h > index bc256d31099a..dcd2072151fc 100644 > --- a/include/dt-bindings/clock/r7s72100-clock.h > +++ b/include/dt-bindings/clock/r7s72100-clock.h > @@ -34,6 +34,8 @@ > > /* MSTP7 */ > #define R7S72100_CLK_ETHER 4 > +#define R7S72100_CLK_USB0 1 > +#define R7S72100_CLK_USB1 0 > > /* MSTP8 */ > #define R7S72100_CLK_MMCIF 4 The above also looks fine to me.
On Thu, Apr 27, 2017 at 9:10 PM, Chris Brandt <chris.brandt@renesas.com> wrote: > This adds the USB0 and USB1 clocks to the device tree. > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Simon: see Section 29.3.2 (BUSWAIT) for the reference to the P1 clock. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Fri, Apr 28, 2017 at 09:34:54AM +0200, Geert Uytterhoeven wrote: > On Thu, Apr 27, 2017 at 9:10 PM, Chris Brandt <chris.brandt@renesas.com> wrote: > > This adds the USB0 and USB1 clocks to the device tree. > > > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Simon: see Section 29.3.2 (BUSWAIT) for the reference to the P1 clock. Thanks, I see that now.
On Friday, April 28, 2017, Simon Horman wrote: > On Fri, Apr 28, 2017 at 09:34:54AM +0200, Geert Uytterhoeven wrote: > > On Thu, Apr 27, 2017 at 9:10 PM, Chris Brandt <chris.brandt@renesas.com> > wrote: > > > This adds the USB0 and USB1 clocks to the device tree. > > > > > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Simon: see Section 29.3.2 (BUSWAIT) for the reference to the P1 clock. > > Thanks, I see that now. I was going to say that I simply look at sections: 6.10.6 Internal Clock Signals (1) 6.10.7 Internal Clock Signals (2) Because it lists all the IP blocks and their corresponding clock sources in one place. Chris
Hi Chris, On Fri, Apr 28, 2017 at 2:47 PM, Chris Brandt <Chris.Brandt@renesas.com> wrote: > On Friday, April 28, 2017, Simon Horman wrote: >> On Fri, Apr 28, 2017 at 09:34:54AM +0200, Geert Uytterhoeven wrote: >> > On Thu, Apr 27, 2017 at 9:10 PM, Chris Brandt <chris.brandt@renesas.com> >> wrote: >> > > This adds the USB0 and USB1 clocks to the device tree. >> > Simon: see Section 29.3.2 (BUSWAIT) for the reference to the P1 clock. >> >> Thanks, I see that now. > > I was going to say that I simply look at sections: > 6.10.6 Internal Clock Signals (1) > 6.10.7 Internal Clock Signals (2) > > Because it lists all the IP blocks and their corresponding clock sources in one place. Cool, I grew up with rev. 0.60 of the user manual, so I wasn't aware of that secton. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Fri, Apr 28, 2017 at 04:27:45PM +0200, Geert Uytterhoeven wrote: > Hi Chris, > > On Fri, Apr 28, 2017 at 2:47 PM, Chris Brandt <Chris.Brandt@renesas.com> wrote: > > On Friday, April 28, 2017, Simon Horman wrote: > >> On Fri, Apr 28, 2017 at 09:34:54AM +0200, Geert Uytterhoeven wrote: > >> > On Thu, Apr 27, 2017 at 9:10 PM, Chris Brandt <chris.brandt@renesas.com> > >> wrote: > >> > > This adds the USB0 and USB1 clocks to the device tree. > > >> > Simon: see Section 29.3.2 (BUSWAIT) for the reference to the P1 clock. > >> > >> Thanks, I see that now. > > > > I was going to say that I simply look at sections: > > 6.10.6 Internal Clock Signals (1) > > 6.10.7 Internal Clock Signals (2) > > > > Because it lists all the IP blocks and their corresponding clock sources in one place. > > Cool, I grew up with rev. 0.60 of the user manual, so I wasn't aware of > that secton. Thanks, now I'm not looking at 0.60 any more I see the sections Chris mentions too.
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi index fb54cb5d3fad..4ed12a4d9d51 100644 --- a/arch/arm/boot/dts/r7s72100.dtsi +++ b/arch/arm/boot/dts/r7s72100.dtsi @@ -144,9 +144,9 @@ #clock-cells = <1>; compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks"; reg = <0xfcfe0430 4>; - clocks = <&b_clk>; - clock-indices = <R7S72100_CLK_ETHER>; - clock-output-names = "ether"; + clocks = <&b_clk>, <&p1_clk>, <&p1_clk>; + clock-indices = <R7S72100_CLK_ETHER R7S72100_CLK_USB0 R7S72100_CLK_USB1>; + clock-output-names = "ether", "usb0", "usb1"; }; mstp8_clks: mstp8_clks@fcfe0434 { diff --git a/include/dt-bindings/clock/r7s72100-clock.h b/include/dt-bindings/clock/r7s72100-clock.h index bc256d31099a..dcd2072151fc 100644 --- a/include/dt-bindings/clock/r7s72100-clock.h +++ b/include/dt-bindings/clock/r7s72100-clock.h @@ -34,6 +34,8 @@ /* MSTP7 */ #define R7S72100_CLK_ETHER 4 +#define R7S72100_CLK_USB0 1 +#define R7S72100_CLK_USB1 0 /* MSTP8 */ #define R7S72100_CLK_MMCIF 4
This adds the USB0 and USB1 clocks to the device tree. Signed-off-by: Chris Brandt <chris.brandt@renesas.com> --- arch/arm/boot/dts/r7s72100.dtsi | 6 +++--- include/dt-bindings/clock/r7s72100-clock.h | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-)