| Message ID | 20170501090346.10801-4-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Mon, May 1, 2017 at 11:03 AM, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > The obviously wrong comment was added in 2011 with commit df3ef2d3c92c0a > ("mmc: protect the tmio_mmc driver against a theoretical race") but > already obsoleted half a year later with commit b9269fdd4f61aa ("mmc: > tmio: fix recursive spinlock, don't schedule with interrupts disabled"). Fixes: b9269fdd4f61aa ("mmc: tmio: fix recursive spinlock, don't schedule with interrupts disabled") > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c index 9d86e3ac626444..36539950347fbc 100644 --- a/drivers/mmc/host/tmio_mmc_pio.c +++ b/drivers/mmc/host/tmio_mmc_pio.c @@ -279,7 +279,6 @@ static void tmio_mmc_reset_work(struct work_struct *work) mmc_request_done(host->mmc, mrq); } -/* called with host->lock held, interrupts disabled */ static void tmio_mmc_finish_request(struct tmio_mmc_host *host) { struct mmc_request *mrq;
The obviously wrong comment was added in 2011 with commit df3ef2d3c92c0a ("mmc: protect the tmio_mmc driver against a theoretical race") but already obsoleted half a year later with commit b9269fdd4f61aa ("mmc: tmio: fix recursive spinlock, don't schedule with interrupts disabled"). Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/mmc/host/tmio_mmc_pio.c | 1 - 1 file changed, 1 deletion(-)