| Message ID | 20170510070458.21193-4-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Laurent, Uli, On Wed, May 10, 2017 at 9:04 AM, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > From: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > > Instantiate the HDMI connectors and enable the encoders. > > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm64/boot/dts/renesas/salvator-x.dtsi | 50 +++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/salvator-x.dtsi b/arch/arm64/boot/dts/renesas/salvator-x.dtsi > index d5eb022d247c..2cd0cce818e7 100644 > --- a/arch/arm64/boot/dts/renesas/salvator-x.dtsi > +++ b/arch/arm64/boot/dts/renesas/salvator-x.dtsi > @@ -151,6 +151,30 @@ > 1800000 0>; > }; > > + hdmi0-out { Can you please respect sort order when inserting new nodes? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, On Wednesday 10 May 2017 10:28:11 Geert Uytterhoeven wrote: > On Wed, May 10, 2017 at 9:04 AM, Laurent Pinchart wrote: > > From: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > > > > Instantiate the HDMI connectors and enable the encoders. > > > > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > --- > > > > arch/arm64/boot/dts/renesas/salvator-x.dtsi | 50 ++++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/salvator-x.dtsi > > b/arch/arm64/boot/dts/renesas/salvator-x.dtsi index > > d5eb022d247c..2cd0cce818e7 100644 > > --- a/arch/arm64/boot/dts/renesas/salvator-x.dtsi > > +++ b/arch/arm64/boot/dts/renesas/salvator-x.dtsi > > @@ -151,6 +151,30 @@ > > 1800000 0>; > > }; > > > > + hdmi0-out { > > Can you please respect sort order when inserting new nodes? > Thanks! Doesn't it make more sense to keep all display outputs grouped together instead of scattering them over the file ?
On Wed, May 10, 2017 at 1:52 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Wednesday 10 May 2017 10:28:11 Geert Uytterhoeven wrote: >> On Wed, May 10, 2017 at 9:04 AM, Laurent Pinchart wrote: >> > From: Koji Matsuoka <koji.matsuoka.xm@renesas.com> >> > >> > Instantiate the HDMI connectors and enable the encoders. >> > >> > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> >> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> >> > Signed-off-by: Laurent Pinchart >> > <laurent.pinchart+renesas@ideasonboard.com> >> > --- >> > >> > arch/arm64/boot/dts/renesas/salvator-x.dtsi | 50 ++++++++++++++++++++++++ >> > 1 file changed, 50 insertions(+) >> > >> > diff --git a/arch/arm64/boot/dts/renesas/salvator-x.dtsi >> > b/arch/arm64/boot/dts/renesas/salvator-x.dtsi index >> > d5eb022d247c..2cd0cce818e7 100644 >> > --- a/arch/arm64/boot/dts/renesas/salvator-x.dtsi >> > +++ b/arch/arm64/boot/dts/renesas/salvator-x.dtsi >> > @@ -151,6 +151,30 @@ >> > 1800000 0>; >> > }; >> > >> > + hdmi0-out { >> >> Can you please respect sort order when inserting new nodes? >> Thanks! > > Doesn't it make more sense to keep all display outputs grouped together > instead of scattering them over the file ? Simon, what do you think? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Wed, May 10, 2017 at 02:13:00PM +0200, Geert Uytterhoeven wrote: > On Wed, May 10, 2017 at 1:52 PM, Laurent Pinchart > <laurent.pinchart@ideasonboard.com> wrote: > > On Wednesday 10 May 2017 10:28:11 Geert Uytterhoeven wrote: > >> On Wed, May 10, 2017 at 9:04 AM, Laurent Pinchart wrote: > >> > From: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > >> > > >> > Instantiate the HDMI connectors and enable the encoders. > >> > > >> > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > >> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > >> > Signed-off-by: Laurent Pinchart > >> > <laurent.pinchart+renesas@ideasonboard.com> > >> > --- > >> > > >> > arch/arm64/boot/dts/renesas/salvator-x.dtsi | 50 ++++++++++++++++++++++++ > >> > 1 file changed, 50 insertions(+) > >> > > >> > diff --git a/arch/arm64/boot/dts/renesas/salvator-x.dtsi > >> > b/arch/arm64/boot/dts/renesas/salvator-x.dtsi index > >> > d5eb022d247c..2cd0cce818e7 100644 > >> > --- a/arch/arm64/boot/dts/renesas/salvator-x.dtsi > >> > +++ b/arch/arm64/boot/dts/renesas/salvator-x.dtsi > >> > @@ -151,6 +151,30 @@ > >> > 1800000 0>; > >> > }; > >> > > >> > + hdmi0-out { > >> > >> Can you please respect sort order when inserting new nodes? > >> Thanks! > > > > Doesn't it make more sense to keep all display outputs grouped together > > instead of scattering them over the file ? > > Simon, what do you think? I tend to agree with Laurent here. I would, however, like the order to be consistent in the case where similar nodes are in multiple files as it makes it somewhat easier to make comparisons.
diff --git a/arch/arm64/boot/dts/renesas/salvator-x.dtsi b/arch/arm64/boot/dts/renesas/salvator-x.dtsi index d5eb022d247c..2cd0cce818e7 100644 --- a/arch/arm64/boot/dts/renesas/salvator-x.dtsi +++ b/arch/arm64/boot/dts/renesas/salvator-x.dtsi @@ -151,6 +151,30 @@ 1800000 0>; }; + hdmi0-out { + compatible = "hdmi-connector"; + label = "HDMI0 OUT"; + type = "a"; + + port { + hdmi0_con: endpoint { + remote-endpoint = <&rcar_dw_hdmi0_out>; + }; + }; + }; + + hdmi1-out { + compatible = "hdmi-connector"; + label = "HDMI1 OUT"; + type = "a"; + + port { + hdmi1_con: endpoint { + remote-endpoint = <&rcar_dw_hdmi1_out>; + }; + }; + }; + vga { compatible = "vga-connector"; @@ -243,6 +267,32 @@ clock-frequency = <32768>; }; +&hdmi0 { + status = "okay"; + + ports { + port@1 { + reg = <1>; + rcar_dw_hdmi0_out: endpoint { + remote-endpoint = <&hdmi0_con>; + }; + }; + }; +}; + +&hdmi1 { + status = "okay"; + + ports { + port@1 { + reg = <1>; + rcar_dw_hdmi1_out: endpoint { + remote-endpoint = <&hdmi1_con>; + }; + }; + }; +}; + &hsusb { status = "okay"; };