diff mbox

[v2.1,4/7] arm64: dts: renesas: r8a7796: Add HDMI encoder instance

Message ID 20170621121730.22025-1-laurent.pinchart+renesas@ideasonboard.com (mailing list archive)
State Superseded
Delegated to: Simon Horman
Headers show

Commit Message

Laurent Pinchart June 21, 2017, 12:17 p.m. UTC 
Add the HDMI encoder to the R8A7796 DT in disabled state.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Changes since v2:

- Rename node to hdmi@fead0000

Comments

Geert Uytterhoeven June 26, 2017, 11:45 a.m. UTC | #1 
On Wed, Jun 21, 2017 at 2:17 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> Add the HDMI encoder to the R8A7796 DT in disabled state.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

(disclaimer: I'm no ports/endpoint expert).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Simon Horman July 10, 2017, 9:07 a.m. UTC | #2 
On Wed, Jun 21, 2017 at 03:17:30PM +0300, Laurent Pinchart wrote:
> Add the HDMI encoder to the R8A7796 DT in disabled state.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> Changes since v2:
> 
> - Rename node to hdmi@fead0000
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> index ad9cd1c3199f..8c1a770c41cd 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -1532,6 +1532,31 @@
>  			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
>  		};
>  
> +		hdmi0: hdmi@fead0000 {
> +			compatible = "renesas,r8a7796-hdmi", "renesas,rcar-gen3-hdmi";
> +			reg = <0 0xfead0000 0 0x10000>;
> +			interrupts = <GIC_SPI 389 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 729>, <&cpg CPG_CORE R8A7796_CLK_HDMI>;
> +			clock-names = "iahb", "isfr";
> +			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> +			resets = <&cpg 729>;
> +			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				port@0 {
> +					reg = <0>;
> +					dw_hdmi0_in: endpoint {
> +						remote-endpoint = <&du_out_hdmi0>;

du_out_hdmi0 is used here but does not exist until the following patch is
applied. What to do?

> +					};
> +				};
> +				port@1 {
> +					reg = <1>;
> +				};
> +			};
> +		};
> +
>  		du: display@feb00000 {
>  			/* placeholder */
>  
> -- 
> Regards,
> 
> Laurent Pinchart
>
Laurent Pinchart July 10, 2017, 9:49 a.m. UTC | #3 
Hi Simon,

On Monday 10 Jul 2017 11:07:50 Simon Horman wrote:
> On Wed, Jun 21, 2017 at 03:17:30PM +0300, Laurent Pinchart wrote:
> > Add the HDMI encoder to the R8A7796 DT in disabled state.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > 
> > Changes since v2:
> > 
> > - Rename node to hdmi@fead0000
> > 
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index
> > ad9cd1c3199f..8c1a770c41cd 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > @@ -1532,6 +1532,31 @@
> > 
> >  			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> >  		
> >  		};
> > 
> > +		hdmi0: hdmi@fead0000 {
> > +			compatible = "renesas,r8a7796-hdmi", "renesas,rcar-
gen3-hdmi";
> > +			reg = <0 0xfead0000 0 0x10000>;
> > +			interrupts = <GIC_SPI 389 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&cpg CPG_MOD 729>, <&cpg CPG_CORE 
R8A7796_CLK_HDMI>;
> > +			clock-names = "iahb", "isfr";
> > +			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> > +			resets = <&cpg 729>;
> > +			status = "disabled";
> > +
> > +			ports {
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +				port@0 {
> > +					reg = <0>;
> > +					dw_hdmi0_in: endpoint {
> > +						remote-endpoint = 
<&du_out_hdmi0>;
> 
> du_out_hdmi0 is used here but does not exist until the following patch is
> applied. What to do?

Good point. I'll resubmit patches 4/7 and 5/7 with a fix.

> > +					};
> > +				};
> > +				port@1 {
> > +					reg = <1>;
> > +				};
> > +			};
> > +		};
> > +
> >  		du: display@feb00000 {
> >  			/* placeholder */
Simon Horman July 11, 2017, 9 a.m. UTC | #4 
On Mon, Jul 10, 2017 at 12:49:45PM +0300, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Monday 10 Jul 2017 11:07:50 Simon Horman wrote:
> > On Wed, Jun 21, 2017 at 03:17:30PM +0300, Laurent Pinchart wrote:
> > > Add the HDMI encoder to the R8A7796 DT in disabled state.
> > > 
> > > Signed-off-by: Laurent Pinchart
> > > <laurent.pinchart+renesas@ideasonboard.com>
> > > ---
> > > 
> > >  arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25 +++++++++++++++++++++++++
> > >  1 file changed, 25 insertions(+)
> > > 
> > > Changes since v2:
> > > 
> > > - Rename node to hdmi@fead0000
> > > 
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > > b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index
> > > ad9cd1c3199f..8c1a770c41cd 100644
> > > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > > @@ -1532,6 +1532,31 @@
> > > 
> > >  			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> > >  		
> > >  		};
> > > 
> > > +		hdmi0: hdmi@fead0000 {
> > > +			compatible = "renesas,r8a7796-hdmi", "renesas,rcar-
> gen3-hdmi";
> > > +			reg = <0 0xfead0000 0 0x10000>;
> > > +			interrupts = <GIC_SPI 389 IRQ_TYPE_LEVEL_HIGH>;
> > > +			clocks = <&cpg CPG_MOD 729>, <&cpg CPG_CORE 
> R8A7796_CLK_HDMI>;
> > > +			clock-names = "iahb", "isfr";
> > > +			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> > > +			resets = <&cpg 729>;
> > > +			status = "disabled";
> > > +
> > > +			ports {
> > > +				#address-cells = <1>;
> > > +				#size-cells = <0>;
> > > +				port@0 {
> > > +					reg = <0>;
> > > +					dw_hdmi0_in: endpoint {
> > > +						remote-endpoint = 
> <&du_out_hdmi0>;
> > 
> > du_out_hdmi0 is used here but does not exist until the following patch is
> > applied. What to do?
> 
> Good point. I'll resubmit patches 4/7 and 5/7 with a fix.

Thanks, that seems better.
I have queued up the resulting series.
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index ad9cd1c3199f..8c1a770c41cd 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1532,6 +1532,31 @@ 
 			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
 		};
 
+		hdmi0: hdmi@fead0000 {
+			compatible = "renesas,r8a7796-hdmi", "renesas,rcar-gen3-hdmi";
+			reg = <0 0xfead0000 0 0x10000>;
+			interrupts = <GIC_SPI 389 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 729>, <&cpg CPG_CORE R8A7796_CLK_HDMI>;
+			clock-names = "iahb", "isfr";
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			resets = <&cpg 729>;
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				port@0 {
+					reg = <0>;
+					dw_hdmi0_in: endpoint {
+						remote-endpoint = <&du_out_hdmi0>;
+					};
+				};
+				port@1 {
+					reg = <1>;
+				};
+			};
+		};
+
 		du: display@feb00000 {
 			/* placeholder */