| Message ID | 20170713121714.30789-1-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 72f81693e1bdadd5fd9b2b71d3d077f3869f248d |
| Delegated to: | Simon Horman |
| Headers | show |
On Thu, Jul 13, 2017 at 2:17 PM, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > The DU LVDS output is on port 3 on R8A7795 but on port 2 on R8A7796. The > lvds_connector label thus can't be defined in salvator-common.dtsi, > common to the two SoCs. > > The lvds_connector label is meant for convience to be referenced from > panel device tree files, such as r8a77xx-aa104xd12-panel.dtsi or > r8a77xx-aa121td01-panel.dtsi. As those files are not included in any > device tree source, and the label never used elsewhere, we can simply > remove it. Out-of-tree patches that include panel device tree files can > then add a > > #define lvds_connector du_out_lvds0 > > before including the panel device tree file. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Simon, On Monday 17 Jul 2017 10:07:33 Geert Uytterhoeven wrote: > On Thu, Jul 13, 2017 at 2:17 PM, Laurent Pinchart wrote: > > The DU LVDS output is on port 3 on R8A7795 but on port 2 on R8A7796. The > > lvds_connector label thus can't be defined in salvator-common.dtsi, > > common to the two SoCs. > > > > The lvds_connector label is meant for convience to be referenced from > > panel device tree files, such as r8a77xx-aa104xd12-panel.dtsi or > > r8a77xx-aa121td01-panel.dtsi. As those files are not included in any > > device tree source, and the label never used elsewhere, we can simply > > remove it. Out-of-tree patches that include panel device tree files can > > then add a > > > > #define lvds_connector du_out_lvds0 > > > > before including the panel device tree file. > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Could you please pick this patch up for v4.14 ?
On Sat, Jul 29, 2017 at 11:05:50PM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Monday 17 Jul 2017 10:07:33 Geert Uytterhoeven wrote: > > On Thu, Jul 13, 2017 at 2:17 PM, Laurent Pinchart wrote: > > > The DU LVDS output is on port 3 on R8A7795 but on port 2 on R8A7796. The > > > lvds_connector label thus can't be defined in salvator-common.dtsi, > > > common to the two SoCs. > > > > > > The lvds_connector label is meant for convience to be referenced from > > > panel device tree files, such as r8a77xx-aa104xd12-panel.dtsi or > > > r8a77xx-aa121td01-panel.dtsi. As those files are not included in any > > > device tree source, and the label never used elsewhere, we can simply > > > remove it. Out-of-tree patches that include panel device tree files can > > > then add a > > > > > > #define lvds_connector du_out_lvds0 > > > > > > before including the panel device tree file. > > > > > > Signed-off-by: Laurent Pinchart > > > <laurent.pinchart+renesas@ideasonboard.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Could you please pick this patch up for v4.14 ? Sure done. I took the liberty of correcting the spelling of convenience before committing the change.
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi index aef35e0b685a..7d46a6c0f74b 100644 --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi @@ -268,10 +268,6 @@ remote-endpoint = <&adv7123_in>; }; }; - port@3 { - lvds_connector: endpoint { - }; - }; }; };
The DU LVDS output is on port 3 on R8A7795 but on port 2 on R8A7796. The lvds_connector label thus can't be defined in salvator-common.dtsi, common to the two SoCs. The lvds_connector label is meant for convience to be referenced from panel device tree files, such as r8a77xx-aa104xd12-panel.dtsi or r8a77xx-aa121td01-panel.dtsi. As those files are not included in any device tree source, and the label never used elsewhere, we can simply remove it. Out-of-tree patches that include panel device tree files can then add a #define lvds_connector du_out_lvds0 before including the panel device tree file. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ---- 1 file changed, 4 deletions(-)