From patchwork Wed Aug 30 17:42:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 9930361 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EA62E60309 for ; Wed, 30 Aug 2017 17:42:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DA2A928711 for ; Wed, 30 Aug 2017 17:42:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CE7C528716; Wed, 30 Aug 2017 17:42:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1618A28711 for ; Wed, 30 Aug 2017 17:42:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751462AbdH3Rmc (ORCPT ); Wed, 30 Aug 2017 13:42:32 -0400 Received: from sauhun.de ([88.99.104.3]:49959 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbdH3Rmb (ORCPT ); Wed, 30 Aug 2017 13:42:31 -0400 Received: from localhost (p54B33EA6.dip0.t-ipconnect.de [84.179.62.166]) by pokefinder.org (Postfix) with ESMTPSA id DA2292C2F9C; Wed, 30 Aug 2017 19:42:28 +0200 (CEST) Date: Wed, 30 Aug 2017 19:42:28 +0200 From: Wolfram Sang To: Javier Martinez Canillas Cc: Linux Kernel , Rob Herring , Florian Larysch , David Lechner , Rob Herring , Andy Shevchenko , Catalin Marinas , =?utf-8?B?U8O2cmVu?= Brinkmann , Simon Horman , Michal Simek , Dinh Nguyen , Russell King , Will Deacon , "devicetree@vger.kernel.org" , Sekhar Nori , Scott Wood , Benjamin Herrenschmidt , Joachim Eastwood , Mark Rutland , "linux-arm-kernel@lists.infradead.org" , Masahiro Yamada , Michael Ellerman , Santosh Shilimkar , Linux-Renesas , Paul Mackerras , Magnus Damm , linuxppc-dev , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Linux I2C Subject: Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Message-ID: <20170830174228.sx5jgtxxy56zq47t@ninjato> References: <20170615185418.13980-1-javier@dowhile0.org> <20170731153009.xkjknygpmckv2pfp@ninjato> <20170828160121.gu4wf7jqu4ditksc@ninjato> <20170829084831.hsdok3ksi7anxzuc@ninjato> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Aug 30, 2017 at 06:19:02PM +0200, Javier Martinez Canillas wrote: > Hello Wolfram, > > On Tue, Aug 29, 2017 at 10:48 AM, Wolfram Sang wrote: > > > >> I don't have a DT based system at hand now, but I'll test it again and > >> let you know probably tomorrow. > > > > I will try again today, too. Thanks! > > > > Ok, I had some time to do some tests again. I used an ARM Chromebook > (Exynos Peach Pi) that has an I2C touchpad (Atmel maXTouch). I tried again as well and it still fails for me. > Tested the following cases: I think we should talk about the same case: Let me repeat what I did: 1) I added your patch "eeprom: at24: Add OF device ID table" 2) I added an EEPROM node to an I2C + eeprom@50 { + compatible = "renesas,24c01"; + reg = <0x50>; + }; -> no at24 binding to the device 3) I revert your patch -> at24 binding to the device I think you should be able to test this DTS snipplet even without a real eeprom. Especially after applying this to the at24 driver. Can you check this? Thanks, Wolfram diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 79c5c39be29cac..f9f547680c53db 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -805,11 +805,6 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id) * Perform a one-byte test read to verify that the * chip is functional. */ - err = at24_read(at24, 0, &test_byte, 1); - if (err) { - err = -ENODEV; - goto err_clients; - } at24->nvmem_config.name = dev_name(&client->dev); at24->nvmem_config.dev = &client->dev;