| Message ID | 20171116003349.19235-3-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Thu, Nov 16, 2017 at 02:33:49AM +0200, Laurent Pinchart wrote: > To avoid races between device access and unplug, call the > video_device_unplug() function in the platform driver remove handler. > This will unsure that all device access completes before the remove > handler proceeds to free resources. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/media/platform/rcar-vin/rcar-core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c > index bd7976efa1fb..c5210f1d09ed 100644 > --- a/drivers/media/platform/rcar-vin/rcar-core.c > +++ b/drivers/media/platform/rcar-vin/rcar-core.c > @@ -1273,6 +1273,7 @@ static int rcar_vin_remove(struct platform_device *pdev) > > pm_runtime_disable(&pdev->dev); > > + video_device_unplug(&vin->vdev); Does this depend on another patch? > > if (!vin->info->use_mc) { > v4l2_async_notifier_unregister(&vin->notifier); > -- > Regards, > > Laurent Pinchart >
Hi Sakari, On 2017-11-16 14:36:24 +0200, Sakari Ailus wrote: > On Thu, Nov 16, 2017 at 02:33:49AM +0200, Laurent Pinchart wrote: > > To avoid races between device access and unplug, call the > > video_device_unplug() function in the platform driver remove handler. > > This will unsure that all device access completes before the remove > > handler proceeds to free resources. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > --- > > drivers/media/platform/rcar-vin/rcar-core.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c > > index bd7976efa1fb..c5210f1d09ed 100644 > > --- a/drivers/media/platform/rcar-vin/rcar-core.c > > +++ b/drivers/media/platform/rcar-vin/rcar-core.c > > @@ -1273,6 +1273,7 @@ static int rcar_vin_remove(struct platform_device *pdev) > > > > pm_runtime_disable(&pdev->dev); > > > > + video_device_unplug(&vin->vdev); > > Does this depend on another patch? I believe this patch is on top of the R-Car VIN Gen3 enablement series. > > > > > if (!vin->info->use_mc) { > > v4l2_async_notifier_unregister(&vin->notifier); > > -- > > Regards, > > > > Laurent Pinchart > > > > -- > Sakari Ailus > e-mail: sakari.ailus@iki.fi
diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c index bd7976efa1fb..c5210f1d09ed 100644 --- a/drivers/media/platform/rcar-vin/rcar-core.c +++ b/drivers/media/platform/rcar-vin/rcar-core.c @@ -1273,6 +1273,7 @@ static int rcar_vin_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); + video_device_unplug(&vin->vdev); if (!vin->info->use_mc) { v4l2_async_notifier_unregister(&vin->notifier);
To avoid races between device access and unplug, call the video_device_unplug() function in the platform driver remove handler. This will unsure that all device access completes before the remove handler proceeds to free resources. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/media/platform/rcar-vin/rcar-core.c | 1 + 1 file changed, 1 insertion(+)