| Message ID | 20171203105735.10529-6-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hello! On 12/3/2017 1:57 PM, Laurent Pinchart wrote: > The structure is used in the API that the VSP1 driver exposes to the DU > driver. Documenting it is thus important. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > include/media/vsp1.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/media/vsp1.h b/include/media/vsp1.h > index 68a8abe4fac5..7850f96fb708 100644 > --- a/include/media/vsp1.h > +++ b/include/media/vsp1.h > @@ -41,6 +41,16 @@ struct vsp1_du_lif_config { > int vsp1_du_setup_lif(struct device *dev, unsigned int pipe_index, > const struct vsp1_du_lif_config *cfg); > > +/** > + * struct vsp1_du_atomic_config - VSP atomic configuration parameters > + * @pixelformat: plan pixel format (V4L2 4CC) s/plan/plane/? [...] MBR, Sergei
Hi Sergei, On Monday, 4 December 2017 11:31:49 EET Sergei Shtylyov wrote: > On 12/3/2017 1:57 PM, Laurent Pinchart wrote: > > The structure is used in the API that the VSP1 driver exposes to the DU > > driver. Documenting it is thus important. > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > --- > > > > include/media/vsp1.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/include/media/vsp1.h b/include/media/vsp1.h > > index 68a8abe4fac5..7850f96fb708 100644 > > --- a/include/media/vsp1.h > > +++ b/include/media/vsp1.h > > @@ -41,6 +41,16 @@ struct vsp1_du_lif_config { > > int vsp1_du_setup_lif(struct device *dev, unsigned int pipe_index, > > const struct vsp1_du_lif_config *cfg); > > > > +/** > > + * struct vsp1_du_atomic_config - VSP atomic configuration parameters > > + * @pixelformat: plan pixel format (V4L2 4CC) > > s/plan/plane/? Of course, my bad. This will be fixed in v2. Thank you for catching the typo.
diff --git a/include/media/vsp1.h b/include/media/vsp1.h index 68a8abe4fac5..7850f96fb708 100644 --- a/include/media/vsp1.h +++ b/include/media/vsp1.h @@ -41,6 +41,16 @@ struct vsp1_du_lif_config { int vsp1_du_setup_lif(struct device *dev, unsigned int pipe_index, const struct vsp1_du_lif_config *cfg); +/** + * struct vsp1_du_atomic_config - VSP atomic configuration parameters + * @pixelformat: plan pixel format (V4L2 4CC) + * @pitch: line pitch in bytes, for all planes + * @mem: DMA memory address for each plane of the frame buffer + * @src: source rectangle in the frame buffer (integer coordinates) + * @dst: destination rectangle on the display (integer coordinates) + * @alpha: alpha value (0: fully transparent, 255: fully opaque) + * @zpos: Z position of the plane (from 0 to number of planes minus 1) + */ struct vsp1_du_atomic_config { u32 pixelformat; unsigned int pitch;
The structure is used in the API that the VSP1 driver exposes to the DU driver. Documenting it is thus important. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- include/media/vsp1.h | 10 ++++++++++ 1 file changed, 10 insertions(+)