| Message ID | 20171221115423.13591-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Simon Horman |
| Headers | show |
On 12/21/2017 02:54 PM, Wolfram Sang wrote: > We need to configure its GPIOs later. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > > arch/arm64/boot/dts/renesas/salvator-common.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > index a298df74ca6c03..1f52be050e2b13 100644 > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > @@ -338,6 +338,11 @@ > &i2c4 { > status = "okay"; > > + pca9654: gpio@20 { > + compatible = "onsemi,pca9654"; The registered vendor prefix is "onnn", not "onsemi". The GPIO driver no longer recognizes "onsemi,pca9654", I've fixed it. [...] MBR, Sergei
> > + pca9654: gpio@20 { > > + compatible = "onsemi,pca9654"; > > The registered vendor prefix is "onnn", not "onsemi". The GPIO driver no > longer recognizes "onsemi,pca9654", I've fixed it. Now, that's a cool vendor prefix. I'll definately use that! Onnn...
Hi Wolfram, On Thu, Dec 21, 2017 at 12:54 PM, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > We need to configure its GPIOs later. Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > @@ -338,6 +338,11 @@ > &i2c4 { > status = "okay"; > > + pca9654: gpio@20 { > + compatible = "onsemi,pca9654"; > + reg = <0x20>; Missing gpio-controller, #gpio-cells, and interrupts properties? Seems like Documentation/devicetree/bindings/gpio/gpio-pca953x.txt can use some updates... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
> Missing gpio-controller, #gpio-cells, I can fix that... > and interrupts properties? ... but this is not tested! > Seems like Documentation/devicetree/bindings/gpio/gpio-pca953x.txt > can use some updates... Heh, I was relying on that. I can fix it, too.
Hi Wolfram, On Thu, Dec 21, 2017 at 1:30 PM, Wolfram Sang <wsa@the-dreams.de> wrote: >> Missing gpio-controller, #gpio-cells, > > I can fix that... > >> and interrupts properties? > > ... but this is not tested! It's hardware description ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hello! On 12/21/2017 03:25 PM, Geert Uytterhoeven wrote: >> We need to configure its GPIOs later. > > Thanks for your patch! > >> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi >> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi >> @@ -338,6 +338,11 @@ >> &i2c4 { >> status = "okay"; >> >> + pca9654: gpio@20 { >> + compatible = "onsemi,pca9654"; >> + reg = <0x20>; > > Missing gpio-controller, #gpio-cells, and interrupts properties? Indeed. > Seems like Documentation/devicetree/bindings/gpio/gpio-pca953x.txt > can use some updates... What do you mean? I've surely updated it in my vendor prefix fix: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8a64e557f399090f5d1917b2f32a065da2b12be1 > Gr{oetje,eeting}s, > > Geert MBR, Sergei
Hi Sergei, On Thu, Dec 21, 2017 at 5:07 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 12/21/2017 03:25 PM, Geert Uytterhoeven wrote: >>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi >>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi >>> @@ -338,6 +338,11 @@ >>> &i2c4 { >>> status = "okay"; >>> >>> + pca9654: gpio@20 { >>> + compatible = "onsemi,pca9654"; >>> + reg = <0x20>; >> >> >> Missing gpio-controller, #gpio-cells, and interrupts properties? > > Indeed. > >> Seems like Documentation/devicetree/bindings/gpio/gpio-pca953x.txt >> can use some updates... > > What do you mean? I've surely updated it in my vendor prefix fix: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8a64e557f399090f5d1917b2f32a065da2b12be1 I mean the missing properties are also not documented in the bindings, or omitted in the example. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi index a298df74ca6c03..1f52be050e2b13 100644 --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi @@ -338,6 +338,11 @@ &i2c4 { status = "okay"; + pca9654: gpio@20 { + compatible = "onsemi,pca9654"; + reg = <0x20>; + }; + csa_vdd: adc@7c { compatible = "maxim,max9611"; reg = <0x7c>;
We need to configure its GPIOs later. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- arch/arm64/boot/dts/renesas/salvator-common.dtsi | 5 +++++ 1 file changed, 5 insertions(+)