diff mbox

[v3] arm64: dts: renesas: salvator-common: add GPIO extender

Message ID 20171222201146.8414-1-wsa+renesas@sang-engineering.com (mailing list archive)
State Accepted
Commit ece30287af4e08e681f27c3d58853b68cdde658b
Delegated to: Simon Horman
Headers show

Commit Message

Wolfram Sang Dec. 22, 2017, 8:11 p.m. UTC
We need to configure its GPIOs later.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Changes since V2:
* added two more required properties (Thanks Geert!)

And no dependency anymore (my statement for V2 was wrong).

 arch/arm64/boot/dts/renesas/salvator-common.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Geert Uytterhoeven Jan. 3, 2018, 10:41 a.m. UTC | #1
Hi Wolfram,

On Fri, Dec 22, 2017 at 9:11 PM, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We need to configure its GPIOs later.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Changes since V2:
> * added two more required properties (Thanks Geert!)
>
> And no dependency anymore (my statement for V2 was wrong).
>
>  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index a298df74ca6c03..7d43ec24cf9fd0 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -338,6 +338,13 @@
>  &i2c4 {
>         status = "okay";
>
> +       pca9654: gpio@20 {
> +               compatible = "onnn,pca9654";
> +               reg = <0x20>;
> +               gpio-controller;
> +               #gpio-cells = <2>;

interrupts?

You can test them using CP16/17 and gpio-keys.

> +       };
> +
>         csa_vdd: adc@7c {
>                 compatible = "maxim,max9611";
>                 reg = <0x7c>;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Wolfram Sang Jan. 3, 2018, 11:16 a.m. UTC | #2
> > +       pca9654: gpio@20 {
> > +               compatible = "onnn,pca9654";
> > +               reg = <0x20>;
> > +               gpio-controller;
> > +               #gpio-cells = <2>;
> 
> interrupts?
> 
> You can test them using CP16/17 and gpio-keys.

Too low priority. We can add it when needed.
Wolfram Sang Jan. 3, 2018, 11:17 a.m. UTC | #3
On Wed, Jan 03, 2018 at 12:16:11PM +0100, Wolfram Sang wrote:
> 
> > > +       pca9654: gpio@20 {
> > > +               compatible = "onnn,pca9654";
> > > +               reg = <0x20>;
> > > +               gpio-controller;
> > > +               #gpio-cells = <2>;
> > 
> > interrupts?
> > 
> > You can test them using CP16/17 and gpio-keys.
> 
> Too low priority. We can add it when needed.

Or when we are bored somewhen ;)
Simon Horman Jan. 4, 2018, 4:51 p.m. UTC | #4
On Fri, Dec 22, 2017 at 09:11:46PM +0100, Wolfram Sang wrote:
> We need to configure its GPIOs later.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> 
> Changes since V2:
> * added two more required properties (Thanks Geert!)
> 
> And no dependency anymore (my statement for V2 was wrong).

Thanks, applied.
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index a298df74ca6c03..7d43ec24cf9fd0 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -338,6 +338,13 @@ 
 &i2c4 {
 	status = "okay";
 
+	pca9654: gpio@20 {
+		compatible = "onnn,pca9654";
+		reg = <0x20>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
 	csa_vdd: adc@7c {
 		compatible = "maxim,max9611";
 		reg = <0x7c>;