| Message ID | 20180119195439.145129729@cogentembedded.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Sergei, On Fri, Jan 19, 2018 at 8:42 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Define the generic R8A77970 part of the LVDS device node. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> I love your patch! Yet something to improve... > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi > +++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi > @@ -654,6 +654,31 @@ > port@1 { > reg = <1>; > du_out_lvds: endpoint { > + remote-endpoint = <&lvds_in>; > + }; > + }; > + }; > + }; > + > + lvds: lvds@feb90000 { > + compatible = "renesas,r8a77970-lvds"; > + reg = <0 0xfeb90000 0 0x14>; > + clocks = <&cpg CPG_MOD 727>; Missing resets and power-domains properties. > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + lvds_in: endpoint { > + remote-endpoint = <&du_out_lvds>; > + }; > + }; > + port@1 { > + reg = <1>; > + lvds_out: endpoint { > }; > }; > }; > Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Index: renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi =================================================================== --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi +++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi @@ -654,6 +654,31 @@ port@1 { reg = <1>; du_out_lvds: endpoint { + remote-endpoint = <&lvds_in>; + }; + }; + }; + }; + + lvds: lvds@feb90000 { + compatible = "renesas,r8a77970-lvds"; + reg = <0 0xfeb90000 0 0x14>; + clocks = <&cpg CPG_MOD 727>; + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + lvds_in: endpoint { + remote-endpoint = <&du_out_lvds>; + }; + }; + port@1 { + reg = <1>; + lvds_out: endpoint { }; }; };
Define the generic R8A77970 part of the LVDS device node. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- arch/arm64/boot/dts/renesas/r8a77970.dtsi | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)