| Message ID | 20180223122949.24291-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Fri, Feb 23, 2018 at 1:29 PM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Bit pattern RCAR_PCI_INT_SIGRETABORT is being bit-wise or'd twice; > remove the redundant 2nd RCAR_PCI_INT_SIGRETABORT. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Fri, Feb 23, 2018 at 12:29:49PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Bit pattern RCAR_PCI_INT_SIGRETABORT is being bit-wise or'd twice; > remove the redundant 2nd RCAR_PCI_INT_SIGRETABORT. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/pci/host/pci-rcar-gen2.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c Applied to pci/rcar for v4.17, thanks ! Lorenzo > index a28370bb2b2a..dd4f1a6b57c5 100644 > --- a/drivers/pci/host/pci-rcar-gen2.c > +++ b/drivers/pci/host/pci-rcar-gen2.c > @@ -52,7 +52,6 @@ > #define RCAR_PCI_INT_B (1 << 17) > #define RCAR_PCI_INT_PME (1 << 19) > #define RCAR_PCI_INT_ALLERRORS (RCAR_PCI_INT_SIGTABORT | \ > - RCAR_PCI_INT_SIGRETABORT | \ > RCAR_PCI_INT_SIGRETABORT | \ > RCAR_PCI_INT_REMABORT | \ > RCAR_PCI_INT_PERR | \ > -- > 2.15.1 >
diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c index a28370bb2b2a..dd4f1a6b57c5 100644 --- a/drivers/pci/host/pci-rcar-gen2.c +++ b/drivers/pci/host/pci-rcar-gen2.c @@ -52,7 +52,6 @@ #define RCAR_PCI_INT_B (1 << 17) #define RCAR_PCI_INT_PME (1 << 19) #define RCAR_PCI_INT_ALLERRORS (RCAR_PCI_INT_SIGTABORT | \ - RCAR_PCI_INT_SIGRETABORT | \ RCAR_PCI_INT_SIGRETABORT | \ RCAR_PCI_INT_REMABORT | \ RCAR_PCI_INT_PERR | \