diff mbox

[v13,02/33] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

Message ID 20180326214456.6655-3-niklas.soderlund+renesas@ragnatech.se (mailing list archive)
State Not Applicable
Headers show

Commit Message

Niklas Söderlund March 26, 2018, 9:44 p.m. UTC 
From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Add compatible strings for r8a7743 and r8a7745. No driver change
is needed as "renesas,rcar-gen2-vin" will activate the right code.
However, it is good practice to document compatible strings for the
specific SoC as this allows SoC specific changes to the driver if
needed, in addition to document SoC support and therefore allow
checkpatch.pl to validate compatible string values.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 Documentation/devicetree/bindings/media/rcar_vin.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Fabrizio Castro April 10, 2018, 9:55 a.m. UTC | #1 
Dear All,

this patch was originally sent on the 16/11/2017, and reposted a few times, does anybody know who is supposed to take it?

Thanks,
Fab

> -----Original Message-----

> From: Niklas Söderlund [mailto:niklas.soderlund+renesas@ragnatech.se]

> Sent: 26 March 2018 22:44

> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>; Hans Verkuil <hverkuil@xs4all.nl>; linux-media@vger.kernel.org

> Cc: linux-renesas-soc@vger.kernel.org; TOMOHARU FUKAWA <tomoharu.fukawa.eb@renesas.com>; Kieran Bingham

> <kieran.bingham@ideasonboard.com>; Fabrizio Castro <fabrizio.castro@bp.renesas.com>

> Subject: [PATCH v13 02/33] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

>

> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

>

> Add compatible strings for r8a7743 and r8a7745. No driver change

> is needed as "renesas,rcar-gen2-vin" will activate the right code.

> However, it is good practice to document compatible strings for the

> specific SoC as this allows SoC specific changes to the driver if

> needed, in addition to document SoC support and therefore allow

> checkpatch.pl to validate compatible string values.

>

> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> Acked-by: Rob Herring <robh@kernel.org>

> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---

>  Documentation/devicetree/bindings/media/rcar_vin.txt | 5 ++++-

>  1 file changed, 4 insertions(+), 1 deletion(-)

>

> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt

> index d99b6f5dee418056..4c76d82905c9d3b8 100644

> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt

> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt

> @@ -6,6 +6,8 @@ family of devices. The current blocks are always slaves and suppot one input

>  channel which can be either RGB, YUYV or BT656.

>

>   - compatible: Must be one or more of the following

> +   - "renesas,vin-r8a7743" for the R8A7743 device

> +   - "renesas,vin-r8a7745" for the R8A7745 device

>     - "renesas,vin-r8a7778" for the R8A7778 device

>     - "renesas,vin-r8a7779" for the R8A7779 device

>     - "renesas,vin-r8a7790" for the R8A7790 device

> @@ -14,7 +16,8 @@ channel which can be either RGB, YUYV or BT656.

>     - "renesas,vin-r8a7793" for the R8A7793 device

>     - "renesas,vin-r8a7794" for the R8A7794 device

>     - "renesas,vin-r8a7795" for the R8A7795 device

> -   - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 compatible device.

> +   - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 or RZ/G1 compatible

> +     device.

>     - "renesas,rcar-gen3-vin" for a generic R-Car Gen3 compatible device.

>

>     When compatible with the generic version nodes must list the

> --

> 2.16.2





Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Niklas Söderlund April 10, 2018, 10:17 a.m. UTC | #2 
Hi Fabrizio,

On 2018-04-10 09:55:29 +0000, Fabrizio Castro wrote:
> Dear All,
> 
> this patch was originally sent on the 16/11/2017, and reposted a few times, does anybody know who is supposed to take it?

Hans have indicated he will take this a respin of this whole patch-set 
sometime next week.

> 
> Thanks,
> Fab
> 
> > -----Original Message-----
> > From: Niklas Söderlund [mailto:niklas.soderlund+renesas@ragnatech.se]
> > Sent: 26 March 2018 22:44
> > To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>; Hans Verkuil <hverkuil@xs4all.nl>; linux-media@vger.kernel.org
> > Cc: linux-renesas-soc@vger.kernel.org; TOMOHARU FUKAWA <tomoharu.fukawa.eb@renesas.com>; Kieran Bingham
> > <kieran.bingham@ideasonboard.com>; Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Subject: [PATCH v13 02/33] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]
> >
> > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > Add compatible strings for r8a7743 and r8a7745. No driver change
> > is needed as "renesas,rcar-gen2-vin" will activate the right code.
> > However, it is good practice to document compatible strings for the
> > specific SoC as this allows SoC specific changes to the driver if
> > needed, in addition to document SoC support and therefore allow
> > checkpatch.pl to validate compatible string values.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> > Acked-by: Rob Herring <robh@kernel.org>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> >  Documentation/devicetree/bindings/media/rcar_vin.txt | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> > index d99b6f5dee418056..4c76d82905c9d3b8 100644
> > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> > @@ -6,6 +6,8 @@ family of devices. The current blocks are always slaves and suppot one input
> >  channel which can be either RGB, YUYV or BT656.
> >
> >   - compatible: Must be one or more of the following
> > +   - "renesas,vin-r8a7743" for the R8A7743 device
> > +   - "renesas,vin-r8a7745" for the R8A7745 device
> >     - "renesas,vin-r8a7778" for the R8A7778 device
> >     - "renesas,vin-r8a7779" for the R8A7779 device
> >     - "renesas,vin-r8a7790" for the R8A7790 device
> > @@ -14,7 +16,8 @@ channel which can be either RGB, YUYV or BT656.
> >     - "renesas,vin-r8a7793" for the R8A7793 device
> >     - "renesas,vin-r8a7794" for the R8A7794 device
> >     - "renesas,vin-r8a7795" for the R8A7795 device
> > -   - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 compatible device.
> > +   - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 or RZ/G1 compatible
> > +     device.
> >     - "renesas,rcar-gen3-vin" for a generic R-Car Gen3 compatible device.
> >
> >     When compatible with the generic version nodes must list the
> > --
> > 2.16.2
> 
> 
> 
> 
> Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Fabrizio Castro April 10, 2018, 11:04 a.m. UTC | #3 
Hello Niklas,

> Subject: Re: [PATCH v13 02/33] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]
>
> Hi Fabrizio,
>
> On 2018-04-10 09:55:29 +0000, Fabrizio Castro wrote:
> > Dear All,
> >
> > this patch was originally sent on the 16/11/2017, and reposted a few times, does anybody know who is supposed to take it?
>
> Hans have indicated he will take this a respin of this whole patch-set
> sometime next week.

fantastic, thanks a lot for the information.

Cheers,
Fab

>
> >
> > Thanks,
> > Fab
> >
> > > -----Original Message-----
> > > From: Niklas Söderlund [mailto:niklas.soderlund+renesas@ragnatech.se]
> > > Sent: 26 March 2018 22:44
> > > To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>; Hans Verkuil <hverkuil@xs4all.nl>; linux-media@vger.kernel.org
> > > Cc: linux-renesas-soc@vger.kernel.org; TOMOHARU FUKAWA <tomoharu.fukawa.eb@renesas.com>; Kieran Bingham
> > > <kieran.bingham@ideasonboard.com>; Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Subject: [PATCH v13 02/33] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]
> > >
> > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > >
> > > Add compatible strings for r8a7743 and r8a7745. No driver change
> > > is needed as "renesas,rcar-gen2-vin" will activate the right code.
> > > However, it is good practice to document compatible strings for the
> > > specific SoC as this allows SoC specific changes to the driver if
> > > needed, in addition to document SoC support and therefore allow
> > > checkpatch.pl to validate compatible string values.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> > > Acked-by: Rob Herring <robh@kernel.org>
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > >  Documentation/devicetree/bindings/media/rcar_vin.txt | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> > > index d99b6f5dee418056..4c76d82905c9d3b8 100644
> > > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> > > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> > > @@ -6,6 +6,8 @@ family of devices. The current blocks are always slaves and suppot one input
> > >  channel which can be either RGB, YUYV or BT656.
> > >
> > >   - compatible: Must be one or more of the following
> > > +   - "renesas,vin-r8a7743" for the R8A7743 device
> > > +   - "renesas,vin-r8a7745" for the R8A7745 device
> > >     - "renesas,vin-r8a7778" for the R8A7778 device
> > >     - "renesas,vin-r8a7779" for the R8A7779 device
> > >     - "renesas,vin-r8a7790" for the R8A7790 device
> > > @@ -14,7 +16,8 @@ channel which can be either RGB, YUYV or BT656.
> > >     - "renesas,vin-r8a7793" for the R8A7793 device
> > >     - "renesas,vin-r8a7794" for the R8A7794 device
> > >     - "renesas,vin-r8a7795" for the R8A7795 device
> > > -   - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 compatible device.
> > > +   - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 or RZ/G1 compatible
> > > +     device.
> > >     - "renesas,rcar-gen3-vin" for a generic R-Car Gen3 compatible device.
> > >
> > >     When compatible with the generic version nodes must list the
> > > --
> > > 2.16.2
> >
> >
> >
> >
> > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England
> & Wales under Registered No. 04586709.
>
> --
> Regards,
> Niklas Söderlund



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
index d99b6f5dee418056..4c76d82905c9d3b8 100644
--- a/Documentation/devicetree/bindings/media/rcar_vin.txt
+++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
@@ -6,6 +6,8 @@  family of devices. The current blocks are always slaves and suppot one input
 channel which can be either RGB, YUYV or BT656.
 
  - compatible: Must be one or more of the following
+   - "renesas,vin-r8a7743" for the R8A7743 device
+   - "renesas,vin-r8a7745" for the R8A7745 device
    - "renesas,vin-r8a7778" for the R8A7778 device
    - "renesas,vin-r8a7779" for the R8A7779 device
    - "renesas,vin-r8a7790" for the R8A7790 device
@@ -14,7 +16,8 @@  channel which can be either RGB, YUYV or BT656.
    - "renesas,vin-r8a7793" for the R8A7793 device
    - "renesas,vin-r8a7794" for the R8A7794 device
    - "renesas,vin-r8a7795" for the R8A7795 device
-   - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 compatible device.
+   - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 or RZ/G1 compatible
+     device.
    - "renesas,rcar-gen3-vin" for a generic R-Car Gen3 compatible device.
 
    When compatible with the generic version nodes must list the