| Message ID | 20180410124302.29932-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi, On 2018년 04월 10일 21:43, Wolfram Sang wrote: > Since commit eca0f13c836a ("extcon: int3496: Ignore incorrect > IoRestriction for ID pin"), the driver doesn't use GPIOF_* flags > anymore. We can thus now drop the deprecated include file for GPIO and > use the new one. Looks good to me. But, you need to send stable mailing list and add 'Fixes' tag on v2. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > > Compile tested only. > > @linusw: one more gone > > drivers/extcon/extcon-intel-int3496.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c > index acaccb128fc4..fd24debe58a3 100644 > --- a/drivers/extcon/extcon-intel-int3496.c > +++ b/drivers/extcon/extcon-intel-int3496.c > @@ -20,7 +20,7 @@ > > #include <linux/acpi.h> > #include <linux/extcon-provider.h> > -#include <linux/gpio.h> > +#include <linux/gpio/consumer.h> > #include <linux/interrupt.h> > #include <linux/module.h> > #include <linux/platform_device.h> >
On 2018년 04월 13일 10:09, Chanwoo Choi wrote: > Hi, > > On 2018년 04월 10일 21:43, Wolfram Sang wrote: >> Since commit eca0f13c836a ("extcon: int3496: Ignore incorrect >> IoRestriction for ID pin"), the driver doesn't use GPIOF_* flags >> anymore. We can thus now drop the deprecated include file for GPIO and >> use the new one. > > Looks good to me. But, you need to send stable mailing list > and add 'Fixes' tag on v2. You don't need to send stable mailing list. It is my mistake. Just I'll pick this patch on extcon-fixes branch. > >> >> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> >> --- >> >> Compile tested only. >> >> @linusw: one more gone >> >> drivers/extcon/extcon-intel-int3496.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c >> index acaccb128fc4..fd24debe58a3 100644 >> --- a/drivers/extcon/extcon-intel-int3496.c >> +++ b/drivers/extcon/extcon-intel-int3496.c >> @@ -20,7 +20,7 @@ >> >> #include <linux/acpi.h> >> #include <linux/extcon-provider.h> >> -#include <linux/gpio.h> >> +#include <linux/gpio/consumer.h> >> #include <linux/interrupt.h> >> #include <linux/module.h> >> #include <linux/platform_device.h> >> > >
diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c index acaccb128fc4..fd24debe58a3 100644 --- a/drivers/extcon/extcon-intel-int3496.c +++ b/drivers/extcon/extcon-intel-int3496.c @@ -20,7 +20,7 @@ #include <linux/acpi.h> #include <linux/extcon-provider.h> -#include <linux/gpio.h> +#include <linux/gpio/consumer.h> #include <linux/interrupt.h> #include <linux/module.h> #include <linux/platform_device.h>
Since commit eca0f13c836a ("extcon: int3496: Ignore incorrect IoRestriction for ID pin"), the driver doesn't use GPIOF_* flags anymore. We can thus now drop the deprecated include file for GPIO and use the new one. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Compile tested only. @linusw: one more gone drivers/extcon/extcon-intel-int3496.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)