| Message ID | 20180417204958.14723-1-niklas.soderlund@ragnatech.se (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Tue, Apr 17, 2018 at 10:49 PM, Niklas Söderlund <niklas.soderlund@ragnatech.se> wrote: > From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > The datasheet have been expanded with more registers and the DT files > have been updated with the new size. This change updates the example so > writing new DT files can use the enchanted driver which uses the new > registers. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hello! On 4/17/2018 11:49 PM, Niklas Söderlund wrote: > From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > The datasheet have been expanded with more registers and the DT files > have been updated with the new size. This change updates the example so > writing new DT files can use the enchanted driver which uses the new Enhanced, maybe? Or was there indeed some magic in the air? :-) > registers. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> [...] MBR, Sergei
On Tue, Apr 17, 2018 at 10:49:58PM +0200, Niklas Söderlund wrote: > From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > The datasheet have been expanded with more registers and the DT files Nit: "datasheets have" or "datasheet has" > have been updated with the new size. This change updates the example so > writing new DT files can use the enchanted driver which uses the new > registers. As Sergei mentioned, maybe enhanced rather than enchanted :) > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> The documentation change itself looks fine to me: Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > --- > .../devicetree/bindings/thermal/rcar-gen3-thermal.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt > index fdf5caa6229b4fff..39e7d4e61a63c038 100644 > --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt > @@ -27,9 +27,9 @@ Example: > > tsc: thermal@e6198000 { > compatible = "renesas,r8a7795-thermal"; > - reg = <0 0xe6198000 0 0x68>, > - <0 0xe61a0000 0 0x5c>, > - <0 0xe61a8000 0 0x5c>; > + reg = <0 0xe6198000 0 0x100>, > + <0 0xe61a0000 0 0x100>, > + <0 0xe61a8000 0 0x100>; > interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>; > -- > 2.17.0 >
On Tue, Apr 17, 2018 at 10:49:58PM +0200, Niklas Söderlund wrote: > From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > The datasheet have been expanded with more registers and the DT files > have been updated with the new size. This change updates the example so > writing new DT files can use the enchanted driver which uses the new > registers. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > .../devicetree/bindings/thermal/rcar-gen3-thermal.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied with Simon's comments addressed. Rob
Hi Rob, On 2018-04-24 09:28:41 -0500, Rob Herring wrote: > On Tue, Apr 17, 2018 at 10:49:58PM +0200, Niklas Söderlund wrote: > > From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > > > The datasheet have been expanded with more registers and the DT files > > have been updated with the new size. This change updates the example so > > writing new DT files can use the enchanted driver which uses the new > > registers. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > --- > > .../devicetree/bindings/thermal/rcar-gen3-thermal.txt | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > Applied with Simon's comments addressed. Thanks for addressing Simon's comments while applying. I had planed to repost the thermal patches I got comments for later today so this is one less thing for me to do :-) > > Rob
diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt index fdf5caa6229b4fff..39e7d4e61a63c038 100644 --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt @@ -27,9 +27,9 @@ Example: tsc: thermal@e6198000 { compatible = "renesas,r8a7795-thermal"; - reg = <0 0xe6198000 0 0x68>, - <0 0xe61a0000 0 0x5c>, - <0 0xe61a8000 0 0x5c>; + reg = <0 0xe6198000 0 0x100>, + <0 0xe61a0000 0 0x100>, + <0 0xe61a8000 0 0x100>; interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;