| Message ID | 20180419140641.27926-4-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
[CC'ing Linus W.] On Thu, Apr 19, 2018 at 4:05 PM, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Seems fine and other drivers in platform/ also call dev_get_drvdata directly for this. If Linus does not have anything against it, I will put it in my queue. Thanks, Miguel > --- > > Build tested only. buildbot is happy. Please apply individually. > > drivers/auxdisplay/arm-charlcd.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/auxdisplay/arm-charlcd.c b/drivers/auxdisplay/arm-charlcd.c > index b3176ee92b90..26246ab7a066 100644 > --- a/drivers/auxdisplay/arm-charlcd.c > +++ b/drivers/auxdisplay/arm-charlcd.c > @@ -329,8 +329,7 @@ static int __init charlcd_probe(struct platform_device *pdev) > > static int charlcd_suspend(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct charlcd *lcd = platform_get_drvdata(pdev); > + struct charlcd *lcd = dev_get_drvdata(dev); > > /* Power the display off */ > charlcd_4bit_command(lcd, HD_DISPCTRL); > @@ -339,8 +338,7 @@ static int charlcd_suspend(struct device *dev) > > static int charlcd_resume(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct charlcd *lcd = platform_get_drvdata(pdev); > + struct charlcd *lcd = dev_get_drvdata(dev); > > /* Turn the display back on */ > charlcd_4bit_command(lcd, HD_DISPCTRL | HD_DISPCTRL_ON); > -- > 2.11.0 >
On Thu, Apr 19, 2018 at 4:05 PM, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Sorry for slow reply. Yours, Linus Walleij
diff --git a/drivers/auxdisplay/arm-charlcd.c b/drivers/auxdisplay/arm-charlcd.c index b3176ee92b90..26246ab7a066 100644 --- a/drivers/auxdisplay/arm-charlcd.c +++ b/drivers/auxdisplay/arm-charlcd.c @@ -329,8 +329,7 @@ static int __init charlcd_probe(struct platform_device *pdev) static int charlcd_suspend(struct device *dev) { - struct platform_device *pdev = to_platform_device(dev); - struct charlcd *lcd = platform_get_drvdata(pdev); + struct charlcd *lcd = dev_get_drvdata(dev); /* Power the display off */ charlcd_4bit_command(lcd, HD_DISPCTRL); @@ -339,8 +338,7 @@ static int charlcd_suspend(struct device *dev) static int charlcd_resume(struct device *dev) { - struct platform_device *pdev = to_platform_device(dev); - struct charlcd *lcd = platform_get_drvdata(pdev); + struct charlcd *lcd = dev_get_drvdata(dev); /* Turn the display back on */ charlcd_4bit_command(lcd, HD_DISPCTRL | HD_DISPCTRL_ON);
We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Build tested only. buildbot is happy. Please apply individually. drivers/auxdisplay/arm-charlcd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)