| Message ID | 20180422103528.3402-2-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5d3b50d3c04dc277258dfca02afdddd8e69ecd29 |
| Delegated to: | Simon Horman |
| Headers | show |
On Sun, Apr 22, 2018 at 01:35:25PM +0300, Laurent Pinchart wrote: > The r8a7790 has three FDP1 instances. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Hi Laurent, could you rearrange these nodes so they preserve the sorting of sub-nodes of the soc node by bus address. The other patches in the series seem fine in this regards and I have applied them.
On Sun, Apr 22, 2018 at 12:35 PM, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > The r8a7790 has three FDP1 instances. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -1606,6 +1606,33 @@ > resets = <&cpg 128>; > }; > > + fdp1@fe940000 { Just wondering: should we go for "display-processor@foo"? Gr{oetje,eeting}s, Geert
On Tue, Apr 24, 2018 at 05:01:29PM +0200, Geert Uytterhoeven wrote: > On Sun, Apr 22, 2018 at 12:35 PM, Laurent Pinchart > <laurent.pinchart+renesas@ideasonboard.com> wrote: > > The r8a7790 has three FDP1 instances. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, applied. > > > --- a/arch/arm/boot/dts/r8a7790.dtsi > > +++ b/arch/arm/boot/dts/r8a7790.dtsi > > @@ -1606,6 +1606,33 @@ > > resets = <&cpg 128>; > > }; > > > > + fdp1@fe940000 { > > Just wondering: should we go for "display-processor@foo"? > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >
Hi Simon, On Monday, 23 April 2018 14:07:14 EEST Simon Horman wrote: > On Sun, Apr 22, 2018 at 01:35:25PM +0300, Laurent Pinchart wrote: > > The r8a7790 has three FDP1 instances. > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > Hi Laurent, > > could you rearrange these nodes so they preserve the sorting > of sub-nodes of the soc node by bus address. The other patches > in the series seem fine in this regards and I have applied them. I would have if you hadn't merged the patch already :-) Would you like me to submit a follow-up patch ?
On Thu, Apr 26, 2018 at 12:29:47PM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Monday, 23 April 2018 14:07:14 EEST Simon Horman wrote: > > On Sun, Apr 22, 2018 at 01:35:25PM +0300, Laurent Pinchart wrote: > > > The r8a7790 has three FDP1 instances. > > > > > > Signed-off-by: Laurent Pinchart > > > <laurent.pinchart+renesas@ideasonboard.com> > > > > Hi Laurent, > > > > could you rearrange these nodes so they preserve the sorting > > of sub-nodes of the soc node by bus address. The other patches > > in the series seem fine in this regards and I have applied them. > > I would have if you hadn't merged the patch already :-) Would you like me to > submit a follow-up patch ? Sorry about that. Yes, please submit a follow-up patch.
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index e4367cecad18..9c527ddfde56 100644 --- a/arch/arm/boot/dts/r8a7790.dtsi +++ b/arch/arm/boot/dts/r8a7790.dtsi @@ -1606,6 +1606,33 @@ resets = <&cpg 128>; }; + fdp1@fe940000 { + compatible = "renesas,fdp1"; + reg = <0 0xfe940000 0 0x2400>; + interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 119>; + power-domains = <&sysc R8A7790_PD_ALWAYS_ON>; + resets = <&cpg 119>; + }; + + fdp1@fe944000 { + compatible = "renesas,fdp1"; + reg = <0 0xfe944000 0 0x2400>; + interrupts = <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 118>; + power-domains = <&sysc R8A7790_PD_ALWAYS_ON>; + resets = <&cpg 118>; + }; + + fdp1@fe948000 { + compatible = "renesas,fdp1"; + reg = <0 0xfe948000 0 0x2400>; + interrupts = <GIC_SPI 264 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 117>; + power-domains = <&sysc R8A7790_PD_ALWAYS_ON>; + resets = <&cpg 117>; + }; + vsp@fe938000 { compatible = "renesas,vsp1"; reg = <0 0xfe938000 0 0x8000>;
The r8a7790 has three FDP1 instances. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/arm/boot/dts/r8a7790.dtsi | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)