diff mbox

media: vsp1: Document vsp1_dl_body refcnt

Message ID 20180528102420.19150-1-kieran.bingham@ideasonboard.com (mailing list archive)
State Not Applicable
Delegated to: Geert Uytterhoeven
Headers show

Commit Message

Kieran Bingham May 28, 2018, 10:24 a.m. UTC
In commit 2d9445db0ee9 ("media: vsp1: Use reference counting for
bodies"), a new field was introduced to the vsp1_dl_body structure to
account for usage tracking of the body.

Document the newly added field in the kerneldoc.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 drivers/media/platform/vsp1/vsp1_dl.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Horman May 29, 2018, 8:43 a.m. UTC | #1
On Mon, May 28, 2018 at 11:24:20AM +0100, Kieran Bingham wrote:
> In commit 2d9445db0ee9 ("media: vsp1: Use reference counting for
> bodies"), a new field was introduced to the vsp1_dl_body structure to
> account for usage tracking of the body.
> 
> Document the newly added field in the kerneldoc.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Laurent Pinchart May 29, 2018, 12:32 p.m. UTC | #2
Hi Kieran,

Thank you for the patch.

On Monday, 28 May 2018 13:24:20 EEST Kieran Bingham wrote:
> In commit 2d9445db0ee9 ("media: vsp1: Use reference counting for
> bodies"), a new field was introduced to the vsp1_dl_body structure to
> account for usage tracking of the body.
> 
> Document the newly added field in the kerneldoc.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and taken in my tree for v4.19.

> ---
>  drivers/media/platform/vsp1/vsp1_dl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/vsp1/vsp1_dl.c
> b/drivers/media/platform/vsp1/vsp1_dl.c index d9b9cdd8fbe2..10a24bde2299
> 100644
> --- a/drivers/media/platform/vsp1/vsp1_dl.c
> +++ b/drivers/media/platform/vsp1/vsp1_dl.c
> @@ -43,6 +43,7 @@ struct vsp1_dl_entry {
>   * struct vsp1_dl_body - Display list body
>   * @list: entry in the display list list of bodies
>   * @free: entry in the pool free body list
> + * @refcnt: reference tracking for the body
>   * @pool: pool to which this body belongs
>   * @vsp1: the VSP1 device
>   * @entries: array of entries
diff mbox

Patch

diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/drivers/media/platform/vsp1/vsp1_dl.c
index d9b9cdd8fbe2..10a24bde2299 100644
--- a/drivers/media/platform/vsp1/vsp1_dl.c
+++ b/drivers/media/platform/vsp1/vsp1_dl.c
@@ -43,6 +43,7 @@  struct vsp1_dl_entry {
  * struct vsp1_dl_body - Display list body
  * @list: entry in the display list list of bodies
  * @free: entry in the pool free body list
+ * @refcnt: reference tracking for the body
  * @pool: pool to which this body belongs
  * @vsp1: the VSP1 device
  * @entries: array of entries