| Message ID | 20180605231013.1803-4-marek.vasut+renesas@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi Marek, On Wed, Jun 6, 2018 at 1:10 AM, Marek Vasut <marek.vasut@gmail.com> wrote: > Replace DA9063_NUM_IRQ macro which is not used anywhere with > plain ARRAY_SIZE(). Thanks for your patch! > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> With the issue below fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/include/linux/mfd/da9063/core.h > +++ b/include/linux/mfd/da9063/core.h > @@ -73,7 +73,6 @@ enum da9063_irqs { > }; > > #define DA9063_IRQ_BASE_OFFSET 0 DA9063_IRQ_BASE_OFFSET is now unused, so please remove it (before someone starts using it, and makes it non-zero ;-) > -#define DA9063_NUM_IRQ (DA9063_IRQ_GPI15 + 1 - DA9063_IRQ_BASE_OFFSET) Gr{oetje,eeting}s, Geert
On Wed, 06 Jun 2018, Marek Vasut wrote: > Replace DA9063_NUM_IRQ macro which is not used anywhere with > plain ARRAY_SIZE(). > > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Steve Twiss <stwiss.opensource@diasemi.com> > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> > Cc: linux-renesas-soc@vger.kernel.org > --- > V4: New patch > --- > drivers/mfd/da9063-irq.c | 2 +- > include/linux/mfd/da9063/core.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c index bd448d6cdf8b..34ea8d0334d7 100644 --- a/drivers/mfd/da9063-irq.c +++ b/drivers/mfd/da9063-irq.c @@ -94,7 +94,7 @@ static const struct regmap_irq da9063_irqs[] = { static const struct regmap_irq_chip da9063_irq_chip = { .name = "da9063-irq", .irqs = da9063_irqs, - .num_irqs = DA9063_NUM_IRQ, + .num_irqs = ARRAY_SIZE(da9063_irqs), .num_regs = 4, .status_base = DA9063_REG_EVENT_A, .mask_base = DA9063_REG_IRQ_MASK_A, diff --git a/include/linux/mfd/da9063/core.h b/include/linux/mfd/da9063/core.h index f3ae65db4c86..2622e9822086 100644 --- a/include/linux/mfd/da9063/core.h +++ b/include/linux/mfd/da9063/core.h @@ -73,7 +73,6 @@ enum da9063_irqs { }; #define DA9063_IRQ_BASE_OFFSET 0 -#define DA9063_NUM_IRQ (DA9063_IRQ_GPI15 + 1 - DA9063_IRQ_BASE_OFFSET) struct da9063 { /* Device */
Replace DA9063_NUM_IRQ macro which is not used anywhere with plain ARRAY_SIZE(). Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Lee Jones <lee.jones@linaro.org> Cc: Mark Brown <broonie@kernel.org> Cc: Steve Twiss <stwiss.opensource@diasemi.com> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> Cc: linux-renesas-soc@vger.kernel.org --- V4: New patch --- drivers/mfd/da9063-irq.c | 2 +- include/linux/mfd/da9063/core.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)