diff mbox series

[v2,1/7] dt-bindings: arm: Document Renesas R-Car M3-N-based ULCB board

Message ID 20180812133149.7710-1-erosca@de.adit-jv.com (mailing list archive)
State Accepted
Commit 43bcac2396f7874338016d3c6d86d0bdad8e63e8
Delegated to: Simon Horman
Headers show
Series [v2,1/7] dt-bindings: arm: Document Renesas R-Car M3-N-based ULCB board | expand

Commit Message

Eugeniu Rosca Aug. 12, 2018, 1:31 p.m. UTC
In harmony with ATF and U-Boot outputs [1] and [2], the new board is
based on M3-N revision ES1.1 and the amount of memory present on SiP
is 2GiB, contiguously addressed.

The amount of RAM is mentioned based on the assumption that it is
encoded in the board id/string. There is some evidence supporting this
in form of last-digit-mismatch between two R-Car H3 ES2.0 ULCB board
ids, one with 4GiB and one with 8GiB of RAM (see [3]).

[1] BL2: R-Car Gen3 Initial Program Loader(CA57) Rev.1.0.21
    BL2: PRR is R-Car M3N Ver.1.1

[2] U-Boot 2015.04-00295-*
    CPU: Renesas Electronics R8A77965 rev 1.1
    ---8<----
    DRAM:  1.9 GiB
    Bank #0: 0x048000000 - 0x0bfffffff, 1.9 GiB
    ---8<----

[3] https://patchwork.kernel.org/patch/10555957/#22169325

Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
---
Changes in v2:
 - [Jacopo Mondi] Emphasized the fact the amount of RAM is encoded in
   the board id, so documenting it *is* relevant for this commit.
 - [Simon Horman]
   - Renamed board name 's/M3-N ULCB/M3NULCB/'
   - Renamed compatible string 's/renesas,ulcb/renesas,m3nulcb/'
 - Pushed all dt-bindings patches to the beginning of the series.
---
 Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Simon Horman Aug. 17, 2018, 10:08 a.m. UTC | #1
On Sun, Aug 12, 2018 at 03:31:43PM +0200, Eugeniu Rosca wrote:
> In harmony with ATF and U-Boot outputs [1] and [2], the new board is
> based on M3-N revision ES1.1 and the amount of memory present on SiP
> is 2GiB, contiguously addressed.
> 
> The amount of RAM is mentioned based on the assumption that it is
> encoded in the board id/string. There is some evidence supporting this
> in form of last-digit-mismatch between two R-Car H3 ES2.0 ULCB board
> ids, one with 4GiB and one with 8GiB of RAM (see [3]).
> 
> [1] BL2: R-Car Gen3 Initial Program Loader(CA57) Rev.1.0.21
>     BL2: PRR is R-Car M3N Ver.1.1
> 
> [2] U-Boot 2015.04-00295-*
>     CPU: Renesas Electronics R8A77965 rev 1.1
>     ---8<----
>     DRAM:  1.9 GiB
>     Bank #0: 0x048000000 - 0x0bfffffff, 1.9 GiB
>     ---8<----
> 
> [3] https://patchwork.kernel.org/patch/10555957/#22169325
> 
> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>

Thanks,

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Simon Horman Aug. 27, 2018, 12:37 p.m. UTC | #2
On Fri, Aug 17, 2018 at 12:08:24PM +0200, Simon Horman wrote:
> On Sun, Aug 12, 2018 at 03:31:43PM +0200, Eugeniu Rosca wrote:
> > In harmony with ATF and U-Boot outputs [1] and [2], the new board is
> > based on M3-N revision ES1.1 and the amount of memory present on SiP
> > is 2GiB, contiguously addressed.
> > 
> > The amount of RAM is mentioned based on the assumption that it is
> > encoded in the board id/string. There is some evidence supporting this
> > in form of last-digit-mismatch between two R-Car H3 ES2.0 ULCB board
> > ids, one with 4GiB and one with 8GiB of RAM (see [3]).
> > 
> > [1] BL2: R-Car Gen3 Initial Program Loader(CA57) Rev.1.0.21
> >     BL2: PRR is R-Car M3N Ver.1.1
> > 
> > [2] U-Boot 2015.04-00295-*
> >     CPU: Renesas Electronics R8A77965 rev 1.1
> >     ---8<----
> >     DRAM:  1.9 GiB
> >     Bank #0: 0x048000000 - 0x0bfffffff, 1.9 GiB
> >     ---8<----
> > 
> > [3] https://patchwork.kernel.org/patch/10555957/#22169325
> > 
> > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> 
> Thanks,
> 
> This looks fine to me but I will wait to see if there are other reviews
> before applying.
> 
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

Thanks again, applied for v4.20.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
index d8cf740132c6..03a314c7989d 100644
--- a/Documentation/devicetree/bindings/arm/shmobile.txt
+++ b/Documentation/devicetree/bindings/arm/shmobile.txt
@@ -106,6 +106,8 @@  Boards:
     compatible = "renesas,lager", "renesas,r8a7790"
   - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))
     compatible = "renesas,m3ulcb", "renesas,r8a7796"
+  - M3NULCB (R-Car Starter Kit Pro, RTP0RC77965SKBX010SA00 (M3-N ES1.1))
+    compatible = "renesas,m3nulcb", "renesas,r8a77965"
   - Marzen (R0P7779A00010S)
     compatible = "renesas,marzen", "renesas,r8a7779"
   - Porter (M2-LCDP)