| Message ID | 20180918014509.6394-4-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | i2c: adv748x: add support for CSI-2 TXA to work in 1-, 2- and 4-lane mode | expand |
On 9/18/2018 4:45 AM, Niklas Söderlund wrote: > Fix copy-and-past error in comment for TXB CSI-2 transmitter power down -paste. :-) > sequence. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> [...] MBR, Sergei
Hi Niklas, Thank you for the patch, I don't think this conflicts with Jacopo's series at all does it ? Perhaps with the amount of adv748x churn currently I should create an integration/for-next branch :-) On 18/09/18 02:45, Niklas Söderlund wrote: > Fix copy-and-past error in comment for TXB CSI-2 transmitter power down > sequence. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> This looks good and useful to me. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/media/i2c/adv748x/adv748x-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > index 9a82cdf301bccb41..86cb38f4d7cc11c6 100644 > --- a/drivers/media/i2c/adv748x/adv748x-core.c > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > @@ -299,7 +299,7 @@ static const struct adv748x_reg_value adv748x_power_down_txb_1lane[] = { > > {ADV748X_PAGE_TXB, 0x31, 0x82}, /* ADI Required Write */ > {ADV748X_PAGE_TXB, 0x1e, 0x00}, /* ADI Required Write */ > - {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 4-lane MIPI */ > + {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 1-lane MIPI */ > {ADV748X_PAGE_TXB, 0xda, 0x01}, /* i2c_mipi_pll_en - 1'b1 */ > {ADV748X_PAGE_TXB, 0xc1, 0x3b}, /* ADI Required Write */
Hi Niklas, Thank you for the patch. On Tuesday, 18 September 2018 04:45:09 EEST Niklas Söderlund wrote: > Fix copy-and-past error in comment for TXB CSI-2 transmitter power down > sequence. Apart from the s/past/paste/ typo that Sergei pointed out, I see no other issue. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/media/i2c/adv748x/adv748x-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c > b/drivers/media/i2c/adv748x/adv748x-core.c index > 9a82cdf301bccb41..86cb38f4d7cc11c6 100644 > --- a/drivers/media/i2c/adv748x/adv748x-core.c > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > @@ -299,7 +299,7 @@ static const struct adv748x_reg_value > adv748x_power_down_txb_1lane[] = { > > {ADV748X_PAGE_TXB, 0x31, 0x82}, /* ADI Required Write */ > {ADV748X_PAGE_TXB, 0x1e, 0x00}, /* ADI Required Write */ > - {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 4-lane MIPI */ > + {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 1-lane MIPI */ > {ADV748X_PAGE_TXB, 0xda, 0x01}, /* i2c_mipi_pll_en - 1'b1 */ > {ADV748X_PAGE_TXB, 0xc1, 0x3b}, /* ADI Required Write */
Hi Niklas, On 18/09/18 10:54, Kieran Bingham wrote: > Hi Niklas, > > Thank you for the patch, > > I don't think this conflicts with Jacopo's series at all does it ? > > Perhaps with the amount of adv748x churn currently I should create an > integration/for-next branch :-) > > On 18/09/18 02:45, Niklas Söderlund wrote: >> Fix copy-and-past error in comment for TXB CSI-2 transmitter power down >> sequence. >> >> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > This looks good and useful to me. > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > >> --- >> drivers/media/i2c/adv748x/adv748x-core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c >> index 9a82cdf301bccb41..86cb38f4d7cc11c6 100644 >> --- a/drivers/media/i2c/adv748x/adv748x-core.c >> +++ b/drivers/media/i2c/adv748x/adv748x-core.c >> @@ -299,7 +299,7 @@ static const struct adv748x_reg_value adv748x_power_down_txb_1lane[] = { >> >> {ADV748X_PAGE_TXB, 0x31, 0x82}, /* ADI Required Write */ >> {ADV748X_PAGE_TXB, 0x1e, 0x00}, /* ADI Required Write */ >> - {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 4-lane MIPI */ >> + {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 1-lane MIPI */ I should just go look at the rest of the code - but it stands out in this hunk that we are enabling the lane in our power-down sequence?. Perhaps we power it down further in the table which isn't provided by the diff. >> {ADV748X_PAGE_TXB, 0xda, 0x01}, /* i2c_mipi_pll_en - 1'b1 */ >> {ADV748X_PAGE_TXB, 0xc1, 0x3b}, /* ADI Required Write */ > > >
Hi Kieran, On Tue, Sep 18, 2018 at 10:54:44AM +0100, Kieran Bingham wrote: > Hi Niklas, > > Thank you for the patch, > > I don't think this conflicts with Jacopo's series at all does it ? It does, and I think this series should have been (re)based, or the other way around, but all these changes should probably go together, don't they? > > Perhaps with the amount of adv748x churn currently I should create an > integration/for-next branch :-) > Also, but we may be able to handle this a single series, once we have Ebisu working. Thanks j > On 18/09/18 02:45, Niklas Söderlund wrote: > > Fix copy-and-past error in comment for TXB CSI-2 transmitter power down > > sequence. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > This looks good and useful to me. > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > --- > > drivers/media/i2c/adv748x/adv748x-core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > > index 9a82cdf301bccb41..86cb38f4d7cc11c6 100644 > > --- a/drivers/media/i2c/adv748x/adv748x-core.c > > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > > @@ -299,7 +299,7 @@ static const struct adv748x_reg_value adv748x_power_down_txb_1lane[] = { > > > > {ADV748X_PAGE_TXB, 0x31, 0x82}, /* ADI Required Write */ > > {ADV748X_PAGE_TXB, 0x1e, 0x00}, /* ADI Required Write */ > > - {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 4-lane MIPI */ > > + {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 1-lane MIPI */ > > {ADV748X_PAGE_TXB, 0xda, 0x01}, /* i2c_mipi_pll_en - 1'b1 */ > > {ADV748X_PAGE_TXB, 0xc1, 0x3b}, /* ADI Required Write */ > > > > -- > Regards > -- > Kieran
Hi Jacopo, On 18/09/18 13:34, jacopo mondi wrote: > Hi Kieran, > > On Tue, Sep 18, 2018 at 10:54:44AM +0100, Kieran Bingham wrote: >> Hi Niklas, >> >> Thank you for the patch, >> >> I don't think this conflicts with Jacopo's series at all does it ? > > It does, and I think this series should have been (re)based, or the > other way around, but all these changes should probably go together, > don't they? I think when I wrote that comment, I actually meant *just this patch* :-) I think your series is more mature and closer to integration, so it might be that this series should be on top. >> >> Perhaps with the amount of adv748x churn currently I should create an >> integration/for-next branch :-) >> > > Also, but we may be able to handle this a single series, once we have > Ebisu working. > > Thanks > j > >> On 18/09/18 02:45, Niklas Söderlund wrote: >>> Fix copy-and-past error in comment for TXB CSI-2 transmitter power down >>> sequence. >>> >>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> >> >> This looks good and useful to me. >> >> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> >> >>> --- >>> drivers/media/i2c/adv748x/adv748x-core.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c >>> index 9a82cdf301bccb41..86cb38f4d7cc11c6 100644 >>> --- a/drivers/media/i2c/adv748x/adv748x-core.c >>> +++ b/drivers/media/i2c/adv748x/adv748x-core.c >>> @@ -299,7 +299,7 @@ static const struct adv748x_reg_value adv748x_power_down_txb_1lane[] = { >>> >>> {ADV748X_PAGE_TXB, 0x31, 0x82}, /* ADI Required Write */ >>> {ADV748X_PAGE_TXB, 0x1e, 0x00}, /* ADI Required Write */ >>> - {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 4-lane MIPI */ >>> + {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 1-lane MIPI */ >>> {ADV748X_PAGE_TXB, 0xda, 0x01}, /* i2c_mipi_pll_en - 1'b1 */ >>> {ADV748X_PAGE_TXB, 0xc1, 0x3b}, /* ADI Required Write */ >> >> >> >> -- >> Regards >> -- >> Kieran
Hi Niklas, On 18/09/18 02:45, Niklas Söderlund wrote: > Fix copy-and-past error in comment for TXB CSI-2 transmitter power down > sequence. > I have collected this patch into my adv748x/for-next branch (and fixed the typo in "copy-and-past" and submitted as a pull request for Hans and Mauro. -- Regards Kieran > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/media/i2c/adv748x/adv748x-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > index 9a82cdf301bccb41..86cb38f4d7cc11c6 100644 > --- a/drivers/media/i2c/adv748x/adv748x-core.c > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > @@ -299,7 +299,7 @@ static const struct adv748x_reg_value adv748x_power_down_txb_1lane[] = { > > {ADV748X_PAGE_TXB, 0x31, 0x82}, /* ADI Required Write */ > {ADV748X_PAGE_TXB, 0x1e, 0x00}, /* ADI Required Write */ > - {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 4-lane MIPI */ > + {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 1-lane MIPI */ > {ADV748X_PAGE_TXB, 0xda, 0x01}, /* i2c_mipi_pll_en - 1'b1 */ > {ADV748X_PAGE_TXB, 0xc1, 0x3b}, /* ADI Required Write */ > >
Hi Kieran, On 2018-09-26 14:49:22 +0100, Kieran Bingham wrote: > Hi Niklas, > > On 18/09/18 02:45, Niklas Söderlund wrote: > > Fix copy-and-past error in comment for TXB CSI-2 transmitter power down > > sequence. > > > > I have collected this patch into my adv748x/for-next branch (and fixed > the typo in "copy-and-past" and submitted as a pull request for Hans and > Mauro. Thanks I will drop this patch for my v2. > > -- > Regards > > Kieran > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > --- > > drivers/media/i2c/adv748x/adv748x-core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c > > index 9a82cdf301bccb41..86cb38f4d7cc11c6 100644 > > --- a/drivers/media/i2c/adv748x/adv748x-core.c > > +++ b/drivers/media/i2c/adv748x/adv748x-core.c > > @@ -299,7 +299,7 @@ static const struct adv748x_reg_value adv748x_power_down_txb_1lane[] = { > > > > {ADV748X_PAGE_TXB, 0x31, 0x82}, /* ADI Required Write */ > > {ADV748X_PAGE_TXB, 0x1e, 0x00}, /* ADI Required Write */ > > - {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 4-lane MIPI */ > > + {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 1-lane MIPI */ > > {ADV748X_PAGE_TXB, 0xda, 0x01}, /* i2c_mipi_pll_en - 1'b1 */ > > {ADV748X_PAGE_TXB, 0xc1, 0x3b}, /* ADI Required Write */ > > > >
diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c index 9a82cdf301bccb41..86cb38f4d7cc11c6 100644 --- a/drivers/media/i2c/adv748x/adv748x-core.c +++ b/drivers/media/i2c/adv748x/adv748x-core.c @@ -299,7 +299,7 @@ static const struct adv748x_reg_value adv748x_power_down_txb_1lane[] = { {ADV748X_PAGE_TXB, 0x31, 0x82}, /* ADI Required Write */ {ADV748X_PAGE_TXB, 0x1e, 0x00}, /* ADI Required Write */ - {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 4-lane MIPI */ + {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 1-lane MIPI */ {ADV748X_PAGE_TXB, 0xda, 0x01}, /* i2c_mipi_pll_en - 1'b1 */ {ADV748X_PAGE_TXB, 0xc1, 0x3b}, /* ADI Required Write */
Fix copy-and-past error in comment for TXB CSI-2 transmitter power down sequence. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- drivers/media/i2c/adv748x/adv748x-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)