| Message ID | 20181015105517.28032-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | [RESEND] ARM: dma-mapping: update comment about handling dma_ops when detaching from IOMMU | expand |
On Mon, Oct 15, 2018 at 12:55:17PM +0200, Wolfram Sang wrote: > Update the comment because we don't set the pointer to NULL anymore. > Also use the correct pointer name 'dma_ops' instead of 'dma_map_ops'. > > Fixes: 1874619a7df4 ("ARM: dma-mapping: Set proper DMA ops in arm_iommu_detach_device()") > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm/mm/dma-mapping.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > index 66566472c153..e3b04786838f 100644 > --- a/arch/arm/mm/dma-mapping.c > +++ b/arch/arm/mm/dma-mapping.c > @@ -2287,7 +2287,7 @@ EXPORT_SYMBOL_GPL(arm_iommu_attach_device); > * @dev: valid struct device pointer > * > * Detaches the provided device from a previously attached map. > - * This voids the dma operations (dma_map_ops pointer) > + * This overwrites the dma_ops pointer with appropriate non-IOMMU ops. > */ > void arm_iommu_detach_device(struct device *dev) > { > -- > 2.11.0 >
On Mon, Oct 15, 2018 at 12:55:17PM +0200, Wolfram Sang wrote: > Update the comment because we don't set the pointer to NULL anymore. > Also use the correct pointer name 'dma_ops' instead of 'dma_map_ops'. > > Fixes: 1874619a7df4 ("ARM: dma-mapping: Set proper DMA ops in arm_iommu_detach_device()") > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Russell, is this patch in your realm? If not, whom should I contact? Thanks! > --- > arch/arm/mm/dma-mapping.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > index 66566472c153..e3b04786838f 100644 > --- a/arch/arm/mm/dma-mapping.c > +++ b/arch/arm/mm/dma-mapping.c > @@ -2287,7 +2287,7 @@ EXPORT_SYMBOL_GPL(arm_iommu_attach_device); > * @dev: valid struct device pointer > * > * Detaches the provided device from a previously attached map. > - * This voids the dma operations (dma_map_ops pointer) > + * This overwrites the dma_ops pointer with appropriate non-IOMMU ops. > */ > void arm_iommu_detach_device(struct device *dev) > { > -- > 2.11.0 >
Hi Wolfram, On Sun, Dec 9, 2018 at 10:51 PM Wolfram Sang <wsa@the-dreams.de> wrote: > On Mon, Oct 15, 2018 at 12:55:17PM +0200, Wolfram Sang wrote: > > Update the comment because we don't set the pointer to NULL anymore. > > Also use the correct pointer name 'dma_ops' instead of 'dma_map_ops'. > > > > Fixes: 1874619a7df4 ("ARM: dma-mapping: Set proper DMA ops in arm_iommu_detach_device()") > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Russell, is this patch in your realm? If not, whom should I contact? Probably you should contact Russell's patch system, instead of Russell's human email instance, cfr. Documentation/arm/README Gr{oetje,eeting}s, Geert
Hi Geert, > Probably you should contact Russell's patch system, instead of Russell's > human email instance, cfr. Documentation/arm/README I didn't do this so far because rmk's patch tracker says "please submit all patches to the linux-arm-kernel mailing list for community review prior to submission here." But hey, you reviewed it, maybe this will do :) Thanks, Wolfram
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index 66566472c153..e3b04786838f 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -2287,7 +2287,7 @@ EXPORT_SYMBOL_GPL(arm_iommu_attach_device); * @dev: valid struct device pointer * * Detaches the provided device from a previously attached map. - * This voids the dma operations (dma_map_ops pointer) + * This overwrites the dma_ops pointer with appropriate non-IOMMU ops. */ void arm_iommu_detach_device(struct device *dev) {
Update the comment because we don't set the pointer to NULL anymore. Also use the correct pointer name 'dma_ops' instead of 'dma_map_ops'. Fixes: 1874619a7df4 ("ARM: dma-mapping: Set proper DMA ops in arm_iommu_detach_device()") Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> --- arch/arm/mm/dma-mapping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)