| Message ID | 20181017174801.19838-1-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 89862542fab10fed8a3c2f9c167622ef4287351d |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | ARM: dts: r8a779[01]: Disable unconnected LVDS encoders | expand |
Hello, On Wednesday, 17 October 2018 20:48:01 EEST Laurent Pinchart wrote: > The LVDS0 encoder on Koelsh and Porter, and the LVDS1 encoder on Lager, > are enabled in DT but have no device connected to their output. This > result in spurious messages being printed to the kernel log such as > > rcar-du feb00000.display: no connector for encoder /soc/lvds@feb90000, > skipping > > Fix it by disabling the encoders. > > Fixes: 15a1ff30d8f9 ("ARM: dts: r8a7790: Convert to new LVDS DT bindings") > Fixes: e5c3f4707f39 ("ARM: dts: r8a7791: Convert to new LVDS DT bindings") > Reported-by: Simon Horman <horms@verge.net.au> This should have read Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> Sorry for the mistake, I had read the e-mail thread containing the report incorrectly. Simon, could you fix this when applying to your tree, or should I send a v2 ? > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm/boot/dts/r8a7790-lager.dts | 2 -- > arch/arm/boot/dts/r8a7791-koelsch.dts | 2 -- > arch/arm/boot/dts/r8a7791-porter.dts | 2 -- > 3 files changed, 6 deletions(-) > > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts > b/arch/arm/boot/dts/r8a7790-lager.dts index 50312e752e2f..7b9508e83d46 > 100644 > --- a/arch/arm/boot/dts/r8a7790-lager.dts > +++ b/arch/arm/boot/dts/r8a7790-lager.dts > @@ -489,8 +489,6 @@ > }; > > &lvds1 { > - status = "okay"; > - > ports { > port@1 { > lvds_connector: endpoint { > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts > b/arch/arm/boot/dts/r8a7791-koelsch.dts index ce22db01fbba..e6580aa0cea3 > 100644 > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > @@ -479,8 +479,6 @@ > }; > > &lvds0 { > - status = "okay"; > - > ports { > port@1 { > lvds_connector: endpoint { > diff --git a/arch/arm/boot/dts/r8a7791-porter.dts > b/arch/arm/boot/dts/r8a7791-porter.dts index f02036e5de01..fefdf8238bbe > 100644 > --- a/arch/arm/boot/dts/r8a7791-porter.dts > +++ b/arch/arm/boot/dts/r8a7791-porter.dts > @@ -482,8 +482,6 @@ > }; > > &lvds0 { > - status = "okay"; > - > ports { > port@1 { > lvds_connector: endpoint {
On Wed, Oct 17, 2018 at 09:01:04PM +0300, Laurent Pinchart wrote: > Hello, > > On Wednesday, 17 October 2018 20:48:01 EEST Laurent Pinchart wrote: > > The LVDS0 encoder on Koelsh and Porter, and the LVDS1 encoder on Lager, > > are enabled in DT but have no device connected to their output. This > > result in spurious messages being printed to the kernel log such as > > > > rcar-du feb00000.display: no connector for encoder /soc/lvds@feb90000, > > skipping > > > > Fix it by disabling the encoders. > > > > Fixes: 15a1ff30d8f9 ("ARM: dts: r8a7790: Convert to new LVDS DT bindings") > > Fixes: e5c3f4707f39 ("ARM: dts: r8a7791: Convert to new LVDS DT bindings") > > Reported-by: Simon Horman <horms@verge.net.au> > > This should have read > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Sorry for the mistake, I had read the e-mail thread containing the report > incorrectly. Simon, could you fix this when applying to your tree, or should I > send a v2 ? No need for a v2. I have applied this patch for v4.21 with the updated Reported-by tag.
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts index 50312e752e2f..7b9508e83d46 100644 --- a/arch/arm/boot/dts/r8a7790-lager.dts +++ b/arch/arm/boot/dts/r8a7790-lager.dts @@ -489,8 +489,6 @@ }; &lvds1 { - status = "okay"; - ports { port@1 { lvds_connector: endpoint { diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts index ce22db01fbba..e6580aa0cea3 100644 --- a/arch/arm/boot/dts/r8a7791-koelsch.dts +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts @@ -479,8 +479,6 @@ }; &lvds0 { - status = "okay"; - ports { port@1 { lvds_connector: endpoint { diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts index f02036e5de01..fefdf8238bbe 100644 --- a/arch/arm/boot/dts/r8a7791-porter.dts +++ b/arch/arm/boot/dts/r8a7791-porter.dts @@ -482,8 +482,6 @@ }; &lvds0 { - status = "okay"; - ports { port@1 { lvds_connector: endpoint {
The LVDS0 encoder on Koelsh and Porter, and the LVDS1 encoder on Lager, are enabled in DT but have no device connected to their output. This result in spurious messages being printed to the kernel log such as rcar-du feb00000.display: no connector for encoder /soc/lvds@feb90000, skipping Fix it by disabling the encoders. Fixes: 15a1ff30d8f9 ("ARM: dts: r8a7790: Convert to new LVDS DT bindings") Fixes: e5c3f4707f39 ("ARM: dts: r8a7791: Convert to new LVDS DT bindings") Reported-by: Simon Horman <horms@verge.net.au> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/arm/boot/dts/r8a7790-lager.dts | 2 -- arch/arm/boot/dts/r8a7791-koelsch.dts | 2 -- arch/arm/boot/dts/r8a7791-porter.dts | 2 -- 3 files changed, 6 deletions(-)