| Message ID | 20181125144031.4407-5-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4fbd4158fe8967e9296516ebae2cfaf7a1c7a214 |
| Headers | show |
| Series | R-Car DU: Fix DPAD output routing on D3 and E3 | expand |
Hi Simon, Could you please consider taking this patch in your tree ? It's independent from the rest of the series. On Sunday, 25 November 2018 16:40:30 EET Laurent Pinchart wrote: > Add the backlight device for the LVDS1 output, in preparation for panel > support. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > .../arm64/boot/dts/renesas/r8a77995-draak.dts | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index > 2405eaad0296..cd067319e6f3 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > @@ -24,6 +24,17 @@ > stdout-path = "serial0:115200n8"; > }; > > + backlight: backlight { > + compatible = "pwm-backlight"; > + pwms = <&pwm1 0 50000>; > + > + brightness-levels = <256 128 64 16 8 4 0>; > + default-brightness-level = <6>; > + > + power-supply = <®_12p0v>; > + enable-gpios = <&gpio4 0 GPIO_ACTIVE_HIGH>; > + }; > + > composite-in { > compatible = "composite-video-connector"; > > @@ -104,6 +115,15 @@ > regulator-always-on; > }; > > + reg_12p0v: regulator1 { > + compatible = "regulator-fixed"; > + regulator-name = "D12.0V"; > + regulator-min-microvolt = <12000000>; > + regulator-max-microvolt = <12000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > vga { > compatible = "vga-connector";
On Sun, Nov 25, 2018 at 3:40 PM Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > Add the backlight device for the LVDS1 output, in preparation for panel > support. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hi Laurent, On Tue, Dec 04, 2018 at 06:57:10PM +0200, Laurent Pinchart wrote: > Hi Simon, > > Could you please consider taking this patch in your tree ? It's independent > from the rest of the series. sure, applied for v4.21. > > On Sunday, 25 November 2018 16:40:30 EET Laurent Pinchart wrote: > > Add the backlight device for the LVDS1 output, in preparation for panel > > support. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > --- > > .../arm64/boot/dts/renesas/r8a77995-draak.dts | 20 +++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index > > 2405eaad0296..cd067319e6f3 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > @@ -24,6 +24,17 @@ > > stdout-path = "serial0:115200n8"; > > }; > > > > + backlight: backlight { > > + compatible = "pwm-backlight"; > > + pwms = <&pwm1 0 50000>; > > + > > + brightness-levels = <256 128 64 16 8 4 0>; > > + default-brightness-level = <6>; > > + > > + power-supply = <®_12p0v>; > > + enable-gpios = <&gpio4 0 GPIO_ACTIVE_HIGH>; > > + }; > > + > > composite-in { > > compatible = "composite-video-connector"; > > > > @@ -104,6 +115,15 @@ > > regulator-always-on; > > }; > > > > + reg_12p0v: regulator1 { > > + compatible = "regulator-fixed"; > > + regulator-name = "D12.0V"; > > + regulator-min-microvolt = <12000000>; > > + regulator-max-microvolt = <12000000>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > + > > vga { > > compatible = "vga-connector"; > > -- > Regards, > > Laurent Pinchart > > >
Hi Laurent, On Tue, Dec 4, 2018 at 6:36 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Sun, Nov 25, 2018 at 3:40 PM Laurent Pinchart > <laurent.pinchart+renesas@ideasonboard.com> wrote: > > Add the backlight device for the LVDS1 output, in preparation for panel > > support. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Oops, seems I missed the backlight node should be moved up, to preserve sort order. Gr{oetje,eeting}s, Geert
Hi Geert, On Monday, 10 December 2018 14:30:22 EET Geert Uytterhoeven wrote: > On Tue, Dec 4, 2018 at 6:36 PM Geert Uytterhoeven wrote: > > On Sun, Nov 25, 2018 at 3:40 PM Laurent Pinchart wrote: > >> Add the backlight device for the LVDS1 output, in preparation for panel > >> support. > >> > >> Signed-off-by: Laurent Pinchart > >> <laurent.pinchart+renesas@ideasonboard.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Oops, seems I missed the backlight node should be moved up, to preserve > sort order. I assumed that aliases and chosen should be kept at the top of the file. Maybe we don't want to keep the tradition :-)
On Mon, Dec 10, 2018 at 02:33:08PM +0200, Laurent Pinchart wrote: > Hi Geert, > > On Monday, 10 December 2018 14:30:22 EET Geert Uytterhoeven wrote: > > On Tue, Dec 4, 2018 at 6:36 PM Geert Uytterhoeven wrote: > > > On Sun, Nov 25, 2018 at 3:40 PM Laurent Pinchart wrote: > > >> Add the backlight device for the LVDS1 output, in preparation for panel > > >> support. > > >> > > >> Signed-off-by: Laurent Pinchart > > >> <laurent.pinchart+renesas@ideasonboard.com> > > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Oops, seems I missed the backlight node should be moved up, to preserve > > sort order. > > I assumed that aliases and chosen should be kept at the top of the file. > Maybe we don't want to keep the tradition :-) There is precedence for this tradition in salvator-common.dtsi. I am ambivalent at this point.
diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index 2405eaad0296..cd067319e6f3 100644 --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts @@ -24,6 +24,17 @@ stdout-path = "serial0:115200n8"; }; + backlight: backlight { + compatible = "pwm-backlight"; + pwms = <&pwm1 0 50000>; + + brightness-levels = <256 128 64 16 8 4 0>; + default-brightness-level = <6>; + + power-supply = <®_12p0v>; + enable-gpios = <&gpio4 0 GPIO_ACTIVE_HIGH>; + }; + composite-in { compatible = "composite-video-connector"; @@ -104,6 +115,15 @@ regulator-always-on; }; + reg_12p0v: regulator1 { + compatible = "regulator-fixed"; + regulator-name = "D12.0V"; + regulator-min-microvolt = <12000000>; + regulator-max-microvolt = <12000000>; + regulator-boot-on; + regulator-always-on; + }; + vga { compatible = "vga-connector";
Add the backlight device for the LVDS1 output, in preparation for panel support. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- .../arm64/boot/dts/renesas/r8a77995-draak.dts | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)