| Message ID | 20181203151242.25875-2-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7aa69a47ecedb5368d862d0d8a2d6537b48e5501 |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | arm: dts: renesas: Convert remaining boards to new LVDS DT bindings | expand |
Hi Geert, Thank you for the patch. On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote: > As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate > LVDS support in the DU bindings"), the internal LVDS encoder has DT > bindings separate from the DU. The Lager device tree was ported over to > the new model, but the Stout device tree was forgotten. > > Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT > bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Compile-tested only. I can't test the patch either but it looks fine to me. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I assume you will send this directly to Simon, so I don't plan to take the patch in my tree. > --- > arch/arm/boot/dts/r8a7790-stout.dts | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/r8a7790-stout.dts > b/arch/arm/boot/dts/r8a7790-stout.dts index > 629da4cee1b971d6..7a7d3b84d1a6b21d 100644 > --- a/arch/arm/boot/dts/r8a7790-stout.dts > +++ b/arch/arm/boot/dts/r8a7790-stout.dts > @@ -94,9 +94,8 @@ > status = "okay"; > > clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, <&cpg CPG_MOD 722>, > - <&cpg CPG_MOD 726>, <&cpg CPG_MOD 725>, > <&osc1_clk>; > - clock-names = "du.0", "du.1", "du.2", "lvds.0", "lvds.1", "dclkin.0"; > + clock-names = "du.0", "du.1", "du.2", "dclkin.0"; > > ports { > port@0 { > @@ -104,11 +103,21 @@ > remote-endpoint = <&adv7511_in>; > }; > }; > + }; > +}; > + > +&lvds0 { > + ports { > port@1 { > lvds_connector0: endpoint { > }; > }; > - port@2 { > + }; > +}; > + > +&lvds1 { > + ports { > + port@1 { > lvds_connector1: endpoint { > }; > };
On 12/03/2018 10:48 PM, Laurent Pinchart wrote: > Hi Geert, Hi, > Thank you for the patch. > > On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote: >> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate >> LVDS support in the DU bindings"), the internal LVDS encoder has DT >> bindings separate from the DU. The Lager device tree was ported over to >> the new model, but the Stout device tree was forgotten. >> >> Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT >> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> --- >> Compile-tested only. > > I can't test the patch either but it looks fine to me. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > I assume you will send this directly to Simon, so I don't plan to take the > patch in my tree. I have a Stout if you need me to test something.
Hi Marek, On Tuesday, 4 December 2018 00:24:32 EET Marek Vasut wrote: > On 12/03/2018 10:48 PM, Laurent Pinchart wrote: > > On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote: > >> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate > >> LVDS support in the DU bindings"), the internal LVDS encoder has DT > >> bindings separate from the DU. The Lager device tree was ported over to > >> the new model, but the Stout device tree was forgotten. > >> > >> Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT > >> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> --- > >> Compile-tested only. > > > > I can't test the patch either but it looks fine to me. > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > I assume you will send this directly to Simon, so I don't plan to take the > > patch in my tree. > > I have a Stout if you need me to test something. Could you test HDMI output ? We just need to ensure that everything is probed correctly, so display anything on the HDMI output will do.
On 12/03/2018 11:48 PM, Laurent Pinchart wrote: > Hi Marek, > > On Tuesday, 4 December 2018 00:24:32 EET Marek Vasut wrote: >> On 12/03/2018 10:48 PM, Laurent Pinchart wrote: >>> On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote: >>>> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate >>>> LVDS support in the DU bindings"), the internal LVDS encoder has DT >>>> bindings separate from the DU. The Lager device tree was ported over to >>>> the new model, but the Stout device tree was forgotten. >>>> >>>> Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT >>>> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >>>> --- >>>> Compile-tested only. >>> >>> I can't test the patch either but it looks fine to me. >>> >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> >>> I assume you will send this directly to Simon, so I don't plan to take the >>> patch in my tree. >> >> I have a Stout if you need me to test something. > > Could you test HDMI output ? We just need to ensure that everything is probed > correctly, so display anything on the HDMI output will do. Sure, can you push me a branch somewhere, so I don't have to hunt down patches ?
Hi Marek, On Wednesday, 5 December 2018 03:10:18 EET Marek Vasut wrote: > On 12/03/2018 11:48 PM, Laurent Pinchart wrote: > > On Tuesday, 4 December 2018 00:24:32 EET Marek Vasut wrote: > >> On 12/03/2018 10:48 PM, Laurent Pinchart wrote: > >>> On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote: > >>>> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: > >>>> Deprecate LVDS support in the DU bindings"), the internal LVDS encoder > >>>> has DT bindings separate from the DU. The Lager device tree was ported > >>>> over to the new model, but the Stout device tree was forgotten. > >>>> > >>>> Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT > >>>> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > >>>> --- > >>>> Compile-tested only. > >>> > >>> I can't test the patch either but it looks fine to me. > >>> > >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >>> > >>> I assume you will send this directly to Simon, so I don't plan to take > >>> the patch in my tree. > >> > >> I have a Stout if you need me to test something. > > > > Could you test HDMI output ? We just need to ensure that everything is > > probed correctly, so display anything on the HDMI output will do. > > Sure, can you push me a branch somewhere, so I don't have to hunt down > patches ? Only this patch should be needed. You can get it from https:// patchwork.kernel.org/patch/10709781/ and apply it on top of v4.19. Please don't use v4.20-rc is there's one missing regression fix there (it has been merged in the media tree and should make it to the final release).
On 12/05/2018 06:41 AM, Laurent Pinchart wrote: > Hi Marek, > > On Wednesday, 5 December 2018 03:10:18 EET Marek Vasut wrote: >> On 12/03/2018 11:48 PM, Laurent Pinchart wrote: >>> On Tuesday, 4 December 2018 00:24:32 EET Marek Vasut wrote: >>>> On 12/03/2018 10:48 PM, Laurent Pinchart wrote: >>>>> On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote: >>>>>> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: >>>>>> Deprecate LVDS support in the DU bindings"), the internal LVDS encoder >>>>>> has DT bindings separate from the DU. The Lager device tree was ported >>>>>> over to the new model, but the Stout device tree was forgotten. >>>>>> >>>>>> Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT >>>>>> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >>>>>> --- >>>>>> Compile-tested only. >>>>> >>>>> I can't test the patch either but it looks fine to me. >>>>> >>>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>>>> >>>>> I assume you will send this directly to Simon, so I don't plan to take >>>>> the patch in my tree. >>>> >>>> I have a Stout if you need me to test something. >>> >>> Could you test HDMI output ? We just need to ensure that everything is >>> probed correctly, so display anything on the HDMI output will do. >> >> Sure, can you push me a branch somewhere, so I don't have to hunt down >> patches ? > > Only this patch should be needed. You can get it from https:// > patchwork.kernel.org/patch/10709781/ and apply it on top of v4.19. Please > don't use v4.20-rc is there's one missing regression fix there (it has been > merged in the media tree and should make it to the final release). On R8A7790 H2 ES3.0 Stout Tested-by: Marek Vasut <marek.vasut@gmail.com>
On Fri, Dec 07, 2018 at 07:36:42PM +0100, Marek Vasut wrote: > On 12/05/2018 06:41 AM, Laurent Pinchart wrote: > > Hi Marek, > > > > On Wednesday, 5 December 2018 03:10:18 EET Marek Vasut wrote: > >> On 12/03/2018 11:48 PM, Laurent Pinchart wrote: > >>> On Tuesday, 4 December 2018 00:24:32 EET Marek Vasut wrote: > >>>> On 12/03/2018 10:48 PM, Laurent Pinchart wrote: > >>>>> On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote: > >>>>>> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: > >>>>>> Deprecate LVDS support in the DU bindings"), the internal LVDS encoder > >>>>>> has DT bindings separate from the DU. The Lager device tree was ported > >>>>>> over to the new model, but the Stout device tree was forgotten. > >>>>>> > >>>>>> Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT > >>>>>> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > >>>>>> --- > >>>>>> Compile-tested only. > >>>>> > >>>>> I can't test the patch either but it looks fine to me. > >>>>> > >>>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >>>>> > >>>>> I assume you will send this directly to Simon, so I don't plan to take > >>>>> the patch in my tree. > >>>> > >>>> I have a Stout if you need me to test something. > >>> > >>> Could you test HDMI output ? We just need to ensure that everything is > >>> probed correctly, so display anything on the HDMI output will do. > >> > >> Sure, can you push me a branch somewhere, so I don't have to hunt down > >> patches ? > > > > Only this patch should be needed. You can get it from https:// > > patchwork.kernel.org/patch/10709781/ and apply it on top of v4.19. Please > > don't use v4.20-rc is there's one missing regression fix there (it has been > > merged in the media tree and should make it to the final release). > > On R8A7790 H2 ES3.0 Stout > > Tested-by: Marek Vasut <marek.vasut@gmail.com> Thanks, applied for v4.22.
diff --git a/arch/arm/boot/dts/r8a7790-stout.dts b/arch/arm/boot/dts/r8a7790-stout.dts index 629da4cee1b971d6..7a7d3b84d1a6b21d 100644 --- a/arch/arm/boot/dts/r8a7790-stout.dts +++ b/arch/arm/boot/dts/r8a7790-stout.dts @@ -94,9 +94,8 @@ status = "okay"; clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, <&cpg CPG_MOD 722>, - <&cpg CPG_MOD 726>, <&cpg CPG_MOD 725>, <&osc1_clk>; - clock-names = "du.0", "du.1", "du.2", "lvds.0", "lvds.1", "dclkin.0"; + clock-names = "du.0", "du.1", "du.2", "dclkin.0"; ports { port@0 { @@ -104,11 +103,21 @@ remote-endpoint = <&adv7511_in>; }; }; + }; +}; + +&lvds0 { + ports { port@1 { lvds_connector0: endpoint { }; }; - port@2 { + }; +}; + +&lvds1 { + ports { + port@1 { lvds_connector1: endpoint { }; };
As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate LVDS support in the DU bindings"), the internal LVDS encoder has DT bindings separate from the DU. The Lager device tree was ported over to the new model, but the Stout device tree was forgotten. Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Compile-tested only. --- arch/arm/boot/dts/r8a7790-stout.dts | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)