| Message ID | 20181203151242.25875-3-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2e0e5b1685b708297b8ace867eacb0d692a2b7cf |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | arm: dts: renesas: Convert remaining boards to new LVDS DT bindings | expand |
Hi Geert, Thank you for the patch. On Monday, 3 December 2018 17:12:42 EET Geert Uytterhoeven wrote: > As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate > LVDS support in the DU bindings"), the internal LVDS encoder has DT > bindings separate from the DU. The device trees for all R-Car H3 and > M3-W development boards were ported over to the new model, but > Salvator-XS boards equipped with an R-Car M3-W SoC were forgotten. > > Fixes: 58e8ed2ee9abe718 ("arm64: dts: renesas: Convert to new LVDS DT > bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Compile-tested only. I can't test the patch either but it looks fine to me. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I assume you will send this directly to Simon, so I don't plan to take the patch in my tree. > --- > arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts > b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts index > 8860be65342e4f38..31f12059355ee02b 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts > +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts > @@ -29,11 +29,10 @@ > clocks = <&cpg CPG_MOD 724>, > <&cpg CPG_MOD 723>, > <&cpg CPG_MOD 722>, > - <&cpg CPG_MOD 727>, > <&versaclock6 1>, > <&x21_clk>, > <&versaclock6 2>; > - clock-names = "du.0", "du.1", "du.2", "lvds.0", > + clock-names = "du.0", "du.1", "du.2", > "dclkin.0", "dclkin.1", "dclkin.2"; > };
On Mon, Dec 03, 2018 at 11:51:19PM +0200, Laurent Pinchart wrote: > Hi Geert, > > Thank you for the patch. > > On Monday, 3 December 2018 17:12:42 EET Geert Uytterhoeven wrote: > > As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate > > LVDS support in the DU bindings"), the internal LVDS encoder has DT > > bindings separate from the DU. The device trees for all R-Car H3 and > > M3-W development boards were ported over to the new model, but > > Salvator-XS boards equipped with an R-Car M3-W SoC were forgotten. > > > > Fixes: 58e8ed2ee9abe718 ("arm64: dts: renesas: Convert to new LVDS DT > > bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > Compile-tested only. > > I can't test the patch either but it looks fine to me. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > I assume you will send this directly to Simon, so I don't plan to take the > patch in my tree. Thanks, I have this one. I've applied this for v4.22.
diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts index 8860be65342e4f38..31f12059355ee02b 100644 --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts @@ -29,11 +29,10 @@ clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, <&cpg CPG_MOD 722>, - <&cpg CPG_MOD 727>, <&versaclock6 1>, <&x21_clk>, <&versaclock6 2>; - clock-names = "du.0", "du.1", "du.2", "lvds.0", + clock-names = "du.0", "du.1", "du.2", "dclkin.0", "dclkin.1", "dclkin.2"; };
As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate LVDS support in the DU bindings"), the internal LVDS encoder has DT bindings separate from the DU. The device trees for all R-Car H3 and M3-W development boards were ported over to the new model, but Salvator-XS boards equipped with an R-Car M3-W SoC were forgotten. Fixes: 58e8ed2ee9abe718 ("arm64: dts: renesas: Convert to new LVDS DT bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Compile-tested only. --- arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)