| Message ID | 20190212142000.4312-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6fffb98645e67b5203e58d5acdfc460eeda51a06 |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | arm64: dts: renesas: r8a77990: ebisu: Add GPIO expander | expand |
On Tue, Feb 12, 2019 at 03:20:00PM +0100, Geert Uytterhoeven wrote: > Describe the ON Semiconductor PCA9654 I/O expander on the first I2C > bus, which provides 8 extra GPIOs. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, This looks fine to me but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > --- > GPIOs 5-7 are accessible on test points CP16, CP17, and CP72. > > Output tested with a multi-meter using /sys/class/gpio/. > Input and interrupt capability tested using gpio-keys. > --- > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > index 5ac159b7830d58c1..b5c0dbf4982febd0 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > @@ -337,6 +337,15 @@ > &i2c0 { > status = "okay"; > > + io_expander: gpio@20 { > + compatible = "onnn,pca9654"; > + reg = <0x20>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-parent = <&gpio2>; > + interrupts = <22 IRQ_TYPE_LEVEL_LOW>; > + }; > + > hdmi-encoder@39 { > compatible = "adi,adv7511w"; > reg = <0x39>; > -- > 2.17.1 >
Hi Geert, Thanks for your patch. On 2019-02-12 15:20:00 +0100, Geert Uytterhoeven wrote: > Describe the ON Semiconductor PCA9654 I/O expander on the first I2C > bus, which provides 8 extra GPIOs. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > GPIOs 5-7 are accessible on test points CP16, CP17, and CP72. > > Output tested with a multi-meter using /sys/class/gpio/. > Input and interrupt capability tested using gpio-keys. > --- > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > index 5ac159b7830d58c1..b5c0dbf4982febd0 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > @@ -337,6 +337,15 @@ > &i2c0 { > status = "okay"; > > + io_expander: gpio@20 { > + compatible = "onnn,pca9654"; > + reg = <0x20>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-parent = <&gpio2>; > + interrupts = <22 IRQ_TYPE_LEVEL_LOW>; > + }; > + > hdmi-encoder@39 { > compatible = "adi,adv7511w"; > reg = <0x39>; > -- > 2.17.1 >
On Wed, Feb 13, 2019 at 11:11:26AM +0100, Niklas Söderlund wrote: > Hi Geert, > > Thanks for your patch. > > On 2019-02-12 15:20:00 +0100, Geert Uytterhoeven wrote: > > Describe the ON Semiconductor PCA9654 I/O expander on the first I2C > > bus, which provides 8 extra GPIOs. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Thanks, applied for v5.2.
diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts index 5ac159b7830d58c1..b5c0dbf4982febd0 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts @@ -337,6 +337,15 @@ &i2c0 { status = "okay"; + io_expander: gpio@20 { + compatible = "onnn,pca9654"; + reg = <0x20>; + gpio-controller; + #gpio-cells = <2>; + interrupt-parent = <&gpio2>; + interrupts = <22 IRQ_TYPE_LEVEL_LOW>; + }; + hdmi-encoder@39 { compatible = "adi,adv7511w"; reg = <0x39>;
Describe the ON Semiconductor PCA9654 I/O expander on the first I2C bus, which provides 8 extra GPIOs. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- GPIOs 5-7 are accessible on test points CP16, CP17, and CP72. Output tested with a multi-meter using /sys/class/gpio/. Input and interrupt capability tested using gpio-keys. --- arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 9 +++++++++ 1 file changed, 9 insertions(+)