diff mbox series

[5/6] mfd: da9063: remove leftover platform_data definitions

Message ID 20190318154759.21978-6-wsa+renesas@sang-engineering.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series mfd: da9063: remove platform_data | expand

Commit Message

Wolfram Sang March 18, 2019, 3:47 p.m. UTC 
Not used, not needed, remove them.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 include/linux/mfd/da9063/pdata.h | 65 ----------------------------------------
 1 file changed, 65 deletions(-)
 delete mode 100644 include/linux/mfd/da9063/pdata.h

Comments

Simon Horman March 19, 2019, 12:49 p.m. UTC | #1 
On Mon, Mar 18, 2019 at 04:47:57PM +0100, Wolfram Sang wrote:
> Not used, not needed, remove them.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  include/linux/mfd/da9063/pdata.h | 65 ----------------------------------------
>  1 file changed, 65 deletions(-)
>  delete mode 100644 include/linux/mfd/da9063/pdata.h
> 
> diff --git a/include/linux/mfd/da9063/pdata.h b/include/linux/mfd/da9063/pdata.h
> deleted file mode 100644
> index 21a2d107f0cf..000000000000
> --- a/include/linux/mfd/da9063/pdata.h
> +++ /dev/null
> @@ -1,65 +0,0 @@
> -/*
> - * Platform configuration options for DA9063
> - *
> - * Copyright 2012 Dialog Semiconductor Ltd.
> - *
> - * Author: Michal Hajduk, Dialog Semiconductor
> - * Author: Krystian Garbaciak, Dialog Semiconductor
> - *
> - *  This program is free software; you can redistribute  it and/or modify it
> - *  under  the terms of  the GNU General  Public License as published by the
> - *  Free Software Foundation;  either version 2 of the  License, or (at your
> - *  option) any later version.
> - *
> - */
> -
> -#ifndef __MFD_DA9063_PDATA_H__
> -#define __MFD_DA9063_PDATA_H__
> -
> -/*
> - * RGB LED configuration
> - */
> -/* LED IDs for flags in struct led_info. */
> -enum {
> -	DA9063_GPIO11_LED,
> -	DA9063_GPIO14_LED,
> -	DA9063_GPIO15_LED,
> -
> -	DA9063_LED_NUM
> -};
> -#define DA9063_LED_ID_MASK		0x3
> -
> -/* LED polarity for flags in struct led_info. */
> -#define DA9063_LED_HIGH_LEVEL_ACTIVE	0x0
> -#define DA9063_LED_LOW_LEVEL_ACTIVE	0x4
> -
> -
> -/*
> - * General PMIC configuration
> - */
> -/* HWMON ADC channels configuration */
> -#define DA9063_FLG_FORCE_IN0_MANUAL_MODE	0x0010
> -#define DA9063_FLG_FORCE_IN0_AUTO_MODE		0x0020
> -#define DA9063_FLG_FORCE_IN1_MANUAL_MODE	0x0040
> -#define DA9063_FLG_FORCE_IN1_AUTO_MODE		0x0080
> -#define DA9063_FLG_FORCE_IN2_MANUAL_MODE	0x0100
> -#define DA9063_FLG_FORCE_IN2_AUTO_MODE		0x0200
> -#define DA9063_FLG_FORCE_IN3_MANUAL_MODE	0x0400
> -#define DA9063_FLG_FORCE_IN3_AUTO_MODE		0x0800
> -
> -/* Disable register caching. */
> -#define DA9063_FLG_NO_CACHE			0x0008
> -
> -struct da9063;
> -
> -/* DA9063 platform data */
> -struct da9063_pdata {
> -	int				(*init)(struct da9063 *da9063);
> -	int				irq_base;
> -	bool				key_power;
> -	unsigned			flags;
> -	struct da9063_regulators_pdata	*regulators_pdata;
> -	struct led_platform_data	*leds_pdata;
> -};
> -
> -#endif	/* __MFD_DA9063_PDATA_H__ */
> -- 
> 2.11.0
>
Steve Twiss March 29, 2019, 11 a.m. UTC | #2 
Hi,

On 18 March 2019 15:48 Wolfram Sang wrote:

> Subject: [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions
> 
> Not used, not needed, remove them.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  include/linux/mfd/da9063/pdata.h | 65 ----------------------------------------
>  1 file changed, 65 deletions(-)
>  delete mode 100644 include/linux/mfd/da9063/pdata.h
> 
> diff --git a/include/linux/mfd/da9063/pdata.h

Thanks!
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>

Regards,
Steve
Lee Jones April 3, 2019, 8:07 a.m. UTC | #3 
On Mon, 18 Mar 2019, Wolfram Sang wrote:

> Not used, not needed, remove them.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  include/linux/mfd/da9063/pdata.h | 65 ----------------------------------------
>  1 file changed, 65 deletions(-)
>  delete mode 100644 include/linux/mfd/da9063/pdata.h

Can't take this until the last user has been removed.

But for now:

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
Wolfram Sang April 3, 2019, 8:50 a.m. UTC | #4 
On Wed, Apr 03, 2019 at 09:07:58AM +0100, Lee Jones wrote:
> On Mon, 18 Mar 2019, Wolfram Sang wrote:
> 
> > Not used, not needed, remove them.
> > 
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > ---
> >  include/linux/mfd/da9063/pdata.h | 65 ----------------------------------------
> >  1 file changed, 65 deletions(-)
> >  delete mode 100644 include/linux/mfd/da9063/pdata.h
> 
> Can't take this until the last user has been removed.
> 
> But for now:
> 
> For my own reference:
>   Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

As I wrote in the cover-letter, I'd vote for all patches going in via
MFD. Is that fine with you? Then I'll ping other maintainers for acks.
Lee Jones April 3, 2019, 9:03 a.m. UTC | #5 
On Wed, 03 Apr 2019, Wolfram Sang wrote:

> On Wed, Apr 03, 2019 at 09:07:58AM +0100, Lee Jones wrote:
> > On Mon, 18 Mar 2019, Wolfram Sang wrote:
> > 
> > > Not used, not needed, remove them.
> > > 
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > ---
> > >  include/linux/mfd/da9063/pdata.h | 65 ----------------------------------------
> > >  1 file changed, 65 deletions(-)
> > >  delete mode 100644 include/linux/mfd/da9063/pdata.h
> > 
> > Can't take this until the last user has been removed.
> > 
> > But for now:
> > 
> > For my own reference:
> >   Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> 
> As I wrote in the cover-letter, I'd vote for all patches going in via
> MFD. Is that fine with you? Then I'll ping other maintainers for acks.

That's fine by me too.
diff mbox series

Patch

diff --git a/include/linux/mfd/da9063/pdata.h b/include/linux/mfd/da9063/pdata.h
deleted file mode 100644
index 21a2d107f0cf..000000000000
--- a/include/linux/mfd/da9063/pdata.h
+++ /dev/null
@@ -1,65 +0,0 @@ 
-/*
- * Platform configuration options for DA9063
- *
- * Copyright 2012 Dialog Semiconductor Ltd.
- *
- * Author: Michal Hajduk, Dialog Semiconductor
- * Author: Krystian Garbaciak, Dialog Semiconductor
- *
- *  This program is free software; you can redistribute  it and/or modify it
- *  under  the terms of  the GNU General  Public License as published by the
- *  Free Software Foundation;  either version 2 of the  License, or (at your
- *  option) any later version.
- *
- */
-
-#ifndef __MFD_DA9063_PDATA_H__
-#define __MFD_DA9063_PDATA_H__
-
-/*
- * RGB LED configuration
- */
-/* LED IDs for flags in struct led_info. */
-enum {
-	DA9063_GPIO11_LED,
-	DA9063_GPIO14_LED,
-	DA9063_GPIO15_LED,
-
-	DA9063_LED_NUM
-};
-#define DA9063_LED_ID_MASK		0x3
-
-/* LED polarity for flags in struct led_info. */
-#define DA9063_LED_HIGH_LEVEL_ACTIVE	0x0
-#define DA9063_LED_LOW_LEVEL_ACTIVE	0x4
-
-
-/*
- * General PMIC configuration
- */
-/* HWMON ADC channels configuration */
-#define DA9063_FLG_FORCE_IN0_MANUAL_MODE	0x0010
-#define DA9063_FLG_FORCE_IN0_AUTO_MODE		0x0020
-#define DA9063_FLG_FORCE_IN1_MANUAL_MODE	0x0040
-#define DA9063_FLG_FORCE_IN1_AUTO_MODE		0x0080
-#define DA9063_FLG_FORCE_IN2_MANUAL_MODE	0x0100
-#define DA9063_FLG_FORCE_IN2_AUTO_MODE		0x0200
-#define DA9063_FLG_FORCE_IN3_MANUAL_MODE	0x0400
-#define DA9063_FLG_FORCE_IN3_AUTO_MODE		0x0800
-
-/* Disable register caching. */
-#define DA9063_FLG_NO_CACHE			0x0008
-
-struct da9063;
-
-/* DA9063 platform data */
-struct da9063_pdata {
-	int				(*init)(struct da9063 *da9063);
-	int				irq_base;
-	bool				key_power;
-	unsigned			flags;
-	struct da9063_regulators_pdata	*regulators_pdata;
-	struct led_platform_data	*leds_pdata;
-};
-
-#endif	/* __MFD_DA9063_PDATA_H__ */