| Message ID | 20190617003536.30936-1-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | [kms-tests] tests: Extend BRU/BRS allocation test to cover M3-N | expand |
Hello! On 17.06.2019 3:35, Laurent Pinchart wrote: > The BRU/BRS allocation test only covers the H3 ES2.0 SoC as that was the > only hardware platform supported by the DU driver that offered the > required features at the time the test was written. Now that M3-N is > supported in the DU driver, support it in the test script. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > tests/kms-test-brxalloc.py | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/tests/kms-test-brxalloc.py b/tests/kms-test-brxalloc.py > index 2e3f6cb8b39e..f1902f3baf1d 100755 > --- a/tests/kms-test-brxalloc.py > +++ b/tests/kms-test-brxalloc.py > @@ -17,11 +17,10 @@ class BRxAllocTest(kmstest.KMSTest): > def main(self): > # This test requires usage of two CRTCs connected to the same VSPDL > # instance to test dynamic assignment of the BRU and BRS to pipelines. > - # This is only occurs on H3 ES2.0 (and M3N which we don't support yet). > - # Check the SoC model through sysfs as we can't detected it through the > - # DRM/KMS API. > + # This is only occurs on H3 ES2.0 and M3N. Check the SoC model through Not M3-N? [...] MBR, Sergei
Hi Sergei, On Mon, Jun 17, 2019 at 11:29:52AM +0300, Sergei Shtylyov wrote: > On 17.06.2019 3:35, Laurent Pinchart wrote: > > > The BRU/BRS allocation test only covers the H3 ES2.0 SoC as that was the > > only hardware platform supported by the DU driver that offered the > > required features at the time the test was written. Now that M3-N is > > supported in the DU driver, support it in the test script. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > tests/kms-test-brxalloc.py | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/tests/kms-test-brxalloc.py b/tests/kms-test-brxalloc.py > > index 2e3f6cb8b39e..f1902f3baf1d 100755 > > --- a/tests/kms-test-brxalloc.py > > +++ b/tests/kms-test-brxalloc.py > > @@ -17,11 +17,10 @@ class BRxAllocTest(kmstest.KMSTest): > > def main(self): > > # This test requires usage of two CRTCs connected to the same VSPDL > > # instance to test dynamic assignment of the BRU and BRS to pipelines. > > - # This is only occurs on H3 ES2.0 (and M3N which we don't support yet). > > - # Check the SoC model through sysfs as we can't detected it through the > > - # DRM/KMS API. > > + # This is only occurs on H3 ES2.0 and M3N. Check the SoC model through > > Not M3-N? Of course. I'll fix it. > > [...]
Hi Laurent, On 17/06/2019 01:35, Laurent Pinchart wrote: > The BRU/BRS allocation test only covers the H3 ES2.0 SoC as that was the > only hardware platform supported by the DU driver that offered the > required features at the time the test was written. Now that M3-N is > supported in the DU driver, support it in the test script. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > tests/kms-test-brxalloc.py | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/tests/kms-test-brxalloc.py b/tests/kms-test-brxalloc.py > index 2e3f6cb8b39e..f1902f3baf1d 100755 > --- a/tests/kms-test-brxalloc.py > +++ b/tests/kms-test-brxalloc.py > @@ -17,11 +17,10 @@ class BRxAllocTest(kmstest.KMSTest): > def main(self): > # This test requires usage of two CRTCs connected to the same VSPDL > # instance to test dynamic assignment of the BRU and BRS to pipelines. > - # This is only occurs on H3 ES2.0 (and M3N which we don't support yet). > - # Check the SoC model through sysfs as we can't detected it through the > - # DRM/KMS API. > + # This is only occurs on H3 ES2.0 and M3N. Check the SoC model through > + # sysfs as we can't detected it through the DRM/KMS API. > soc = open("/sys/devices/soc0/soc_id", "rb").read().strip().decode() > - if soc != "r8a7795": > + if soc != "r8a7795" and soc != "r8a77965": To be a bit more pythonic, you could write; if soc not in ["r8a7795", "r8a77965"]: But I don't think this list is going to be extended any time soon so it doesn't really matter. Up to you either way, Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > self.skip("VSPDL (BRU+BRS) not available") > return > >
diff --git a/tests/kms-test-brxalloc.py b/tests/kms-test-brxalloc.py index 2e3f6cb8b39e..f1902f3baf1d 100755 --- a/tests/kms-test-brxalloc.py +++ b/tests/kms-test-brxalloc.py @@ -17,11 +17,10 @@ class BRxAllocTest(kmstest.KMSTest): def main(self): # This test requires usage of two CRTCs connected to the same VSPDL # instance to test dynamic assignment of the BRU and BRS to pipelines. - # This is only occurs on H3 ES2.0 (and M3N which we don't support yet). - # Check the SoC model through sysfs as we can't detected it through the - # DRM/KMS API. + # This is only occurs on H3 ES2.0 and M3N. Check the SoC model through + # sysfs as we can't detected it through the DRM/KMS API. soc = open("/sys/devices/soc0/soc_id", "rb").read().strip().decode() - if soc != "r8a7795": + if soc != "r8a7795" and soc != "r8a77965": self.skip("VSPDL (BRU+BRS) not available") return
The BRU/BRS allocation test only covers the H3 ES2.0 SoC as that was the only hardware platform supported by the DU driver that offered the required features at the time the test was written. Now that M3-N is supported in the DU driver, support it in the test script. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- tests/kms-test-brxalloc.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)