| Message ID | 20200513201016.23047-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | drm/vblank: remove outdated and noisy output | expand |
On Wed, May 13, 2020 at 10:10:16PM +0200, Wolfram Sang wrote: > The R-Car DU driver calls drm_vblank_init via some helper functions in > probe(). From what I checked, most drivers do this as well. I have a > config now where DU always stays in deferred_probe state because of a > missing dependency. This means that every time I rebind another driver > like MMC, the vblank init message is displayed again when the DU driver > is retried. Because the message doesn't really carry a useful > information, I suggest to simply drop it. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Makes sense, queued up in drm-misc-next. -Daniel > --- > drivers/gpu/drm/drm_vblank.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c > index da7b0b0c1090..ce9bed24c2da 100644 > --- a/drivers/gpu/drm/drm_vblank.c > +++ b/drivers/gpu/drm/drm_vblank.c > @@ -483,8 +483,6 @@ int drm_vblank_init(struct drm_device *dev, unsigned int num_crtcs) > seqlock_init(&vblank->seqlock); > } > > - DRM_INFO("Supports vblank timestamp caching Rev 2 (21.10.2013).\n"); > - > return 0; > > err: > -- > 2.20.1 >
diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c index da7b0b0c1090..ce9bed24c2da 100644 --- a/drivers/gpu/drm/drm_vblank.c +++ b/drivers/gpu/drm/drm_vblank.c @@ -483,8 +483,6 @@ int drm_vblank_init(struct drm_device *dev, unsigned int num_crtcs) seqlock_init(&vblank->seqlock); } - DRM_INFO("Supports vblank timestamp caching Rev 2 (21.10.2013).\n"); - return 0; err:
The R-Car DU driver calls drm_vblank_init via some helper functions in probe(). From what I checked, most drivers do this as well. I have a config now where DU always stays in deferred_probe state because of a missing dependency. This means that every time I rebind another driver like MMC, the vblank init message is displayed again when the DU driver is retried. Because the message doesn't really carry a useful information, I suggest to simply drop it. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/gpu/drm/drm_vblank.c | 2 -- 1 file changed, 2 deletions(-)