| Message ID | 20200514164540.507233-3-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | [v3,1/8] media: v4l2-subdv: Introduce [s|g]et_mbus_config pad ops | expand |
For v4 can you fix the subject? It's v4l2-subdev, not v4l2-subdv. Regards, Hans On 14/05/2020 18:45, Jacopo Mondi wrote: > Introduce two new pad operations to allow retrieving and configuring the > media bus configuration on a subdevice pad. > > The newly introduced operations aims to replace the s/g_mbus_config video > operations, which have been on their way to be deprecated since a long > time. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > include/media/v4l2-subdev.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h > index a4848de59852..8d5f4a255b87 100644 > --- a/include/media/v4l2-subdev.h > +++ b/include/media/v4l2-subdev.h > @@ -670,6 +670,32 @@ struct v4l2_subdev_pad_config { > * > * @set_frame_desc: set the low level media bus frame parameters, @fd array > * may be adjusted by the subdev driver to device capabilities. > + * > + * @get_mbus_config: get the current media bus configuration. This operation is > + * intended to be used to synchronize the media bus > + * configuration parameters between receivers and > + * transmitters. The static bus configuration is usually > + * received from the firmware interface, and updated > + * dynamically using this operation to retrieve bus > + * configuration parameters which could change at run-time. > + * Callers should make sure they get the most up-to-date as > + * possible configuration from the connected sub-device, > + * likely calling this operation as close as possible to > + * stream on time. The operation is allowed to fail if the > + * pad index it has been called on is unsupported. > + * > + * @set_mbus_config: set the media bus configuration. This operations is > + * intended to allow, in combination with the > + * get_mbus_format operation, the negotiation of media bus > + * configuration parameters between media subdevices. > + * The initial media bus configuration is retrieved from > + * the firmware interface and later updated through this > + * operation if the sub-device allows changing it. > + * The operation shall not fail if the requested configuration > + * is not supported, but the driver shall update the received > + * %config argument to reflect what has been actually applied > + * to the hardware. The operation is allowed to fail if the > + * pad index it has been called on is unsupported. > */ > struct v4l2_subdev_pad_ops { > int (*init_cfg)(struct v4l2_subdev *sd, > @@ -710,6 +736,10 @@ struct v4l2_subdev_pad_ops { > struct v4l2_mbus_frame_desc *fd); > int (*set_frame_desc)(struct v4l2_subdev *sd, unsigned int pad, > struct v4l2_mbus_frame_desc *fd); > + int (*get_mbus_config)(struct v4l2_subdev *sd, unsigned int pad, > + struct v4l2_mbus_config *config); > + int (*set_mbus_config)(struct v4l2_subdev *sd, unsigned int pad, > + struct v4l2_mbus_config *config); > }; > > /** >
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index a4848de59852..8d5f4a255b87 100644 --- a/include/media/v4l2-subdev.h +++ b/include/media/v4l2-subdev.h @@ -670,6 +670,32 @@ struct v4l2_subdev_pad_config { * * @set_frame_desc: set the low level media bus frame parameters, @fd array * may be adjusted by the subdev driver to device capabilities. + * + * @get_mbus_config: get the current media bus configuration. This operation is + * intended to be used to synchronize the media bus + * configuration parameters between receivers and + * transmitters. The static bus configuration is usually + * received from the firmware interface, and updated + * dynamically using this operation to retrieve bus + * configuration parameters which could change at run-time. + * Callers should make sure they get the most up-to-date as + * possible configuration from the connected sub-device, + * likely calling this operation as close as possible to + * stream on time. The operation is allowed to fail if the + * pad index it has been called on is unsupported. + * + * @set_mbus_config: set the media bus configuration. This operations is + * intended to allow, in combination with the + * get_mbus_format operation, the negotiation of media bus + * configuration parameters between media subdevices. + * The initial media bus configuration is retrieved from + * the firmware interface and later updated through this + * operation if the sub-device allows changing it. + * The operation shall not fail if the requested configuration + * is not supported, but the driver shall update the received + * %config argument to reflect what has been actually applied + * to the hardware. The operation is allowed to fail if the + * pad index it has been called on is unsupported. */ struct v4l2_subdev_pad_ops { int (*init_cfg)(struct v4l2_subdev *sd, @@ -710,6 +736,10 @@ struct v4l2_subdev_pad_ops { struct v4l2_mbus_frame_desc *fd); int (*set_frame_desc)(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_mbus_frame_desc *fd); + int (*get_mbus_config)(struct v4l2_subdev *sd, unsigned int pad, + struct v4l2_mbus_config *config); + int (*set_mbus_config)(struct v4l2_subdev *sd, unsigned int pad, + struct v4l2_mbus_config *config); }; /**
Introduce two new pad operations to allow retrieving and configuring the media bus configuration on a subdevice pad. The newly introduced operations aims to replace the s/g_mbus_config video operations, which have been on their way to be deprecated since a long time. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- include/media/v4l2-subdev.h | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)