| Message ID | 20200609143412.3456484-1-kieran.bingham+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [v2] mm/balloon_compaction: Fix trivial spelling | expand |
On Tue, Jun 9, 2020 at 8:04 PM Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> wrote: > > The word 'descriptor' is misspelled throughout the tree. I think, *throughout the tree* is not appropriate* here. This patch has fixed it within the file. With that, Acked-by: Souptick Joarder <jrdr.linux@gmail.com> > > Fix it up accordingly: > decriptors -> descriptors > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Reviewed-by: David Hildenbrand <david@redhat.com> > --- > mm/balloon_compaction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c > index 26de020aae7b..907fefde2572 100644 > --- a/mm/balloon_compaction.c > +++ b/mm/balloon_compaction.c > @@ -58,7 +58,7 @@ EXPORT_SYMBOL_GPL(balloon_page_list_enqueue); > /** > * balloon_page_list_dequeue() - removes pages from balloon's page list and > * returns a list of the pages. > - * @b_dev_info: balloon device decriptor where we will grab a page from. > + * @b_dev_info: balloon device descriptor where we will grab a page from. > * @pages: pointer to the list of pages that would be returned to the caller. > * @n_req_pages: number of requested pages. > * > @@ -157,7 +157,7 @@ EXPORT_SYMBOL_GPL(balloon_page_enqueue); > /* > * balloon_page_dequeue - removes a page from balloon's page list and returns > * its address to allow the driver to release the page. > - * @b_dev_info: balloon device decriptor where we will grab a page from. > + * @b_dev_info: balloon device descriptor where we will grab a page from. > * > * Driver must call this function to properly dequeue a previously enqueued page > * before definitively releasing it back to the guest system. > -- > 2.25.1 > >
On Tue, Jun 9, 2020 at 10:02 PM Souptick Joarder <jrdr.linux@gmail.com> wrote: > > On Tue, Jun 9, 2020 at 8:04 PM Kieran Bingham > <kieran.bingham+renesas@ideasonboard.com> wrote: > > > > The word 'descriptor' is misspelled throughout the tree. > > I think, *throughout the tree* is not appropriate* here. This patch > has fixed it within the file. With that, Sorry, I read the mail thread in a wrong way. You are right. > > Acked-by: Souptick Joarder <jrdr.linux@gmail.com> > > > > > Fix it up accordingly: > > decriptors -> descriptors > > > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > Reviewed-by: David Hildenbrand <david@redhat.com> > > --- > > mm/balloon_compaction.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c > > index 26de020aae7b..907fefde2572 100644 > > --- a/mm/balloon_compaction.c > > +++ b/mm/balloon_compaction.c > > @@ -58,7 +58,7 @@ EXPORT_SYMBOL_GPL(balloon_page_list_enqueue); > > /** > > * balloon_page_list_dequeue() - removes pages from balloon's page list and > > * returns a list of the pages. > > - * @b_dev_info: balloon device decriptor where we will grab a page from. > > + * @b_dev_info: balloon device descriptor where we will grab a page from. > > * @pages: pointer to the list of pages that would be returned to the caller. > > * @n_req_pages: number of requested pages. > > * > > @@ -157,7 +157,7 @@ EXPORT_SYMBOL_GPL(balloon_page_enqueue); > > /* > > * balloon_page_dequeue - removes a page from balloon's page list and returns > > * its address to allow the driver to release the page. > > - * @b_dev_info: balloon device decriptor where we will grab a page from. > > + * @b_dev_info: balloon device descriptor where we will grab a page from. > > * > > * Driver must call this function to properly dequeue a previously enqueued page > > * before definitively releasing it back to the guest system. > > -- > > 2.25.1 > > > >
On Tue, Jun 09, 2020 at 03:34:12PM +0100, Kieran Bingham wrote: > The word 'descriptor' is misspelled throughout the tree. > > Fix it up accordingly: > decriptors -> descriptors > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Reviewed-by: David Hildenbrand <david@redhat.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Trivial tree pls. > --- > mm/balloon_compaction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c > index 26de020aae7b..907fefde2572 100644 > --- a/mm/balloon_compaction.c > +++ b/mm/balloon_compaction.c > @@ -58,7 +58,7 @@ EXPORT_SYMBOL_GPL(balloon_page_list_enqueue); > /** > * balloon_page_list_dequeue() - removes pages from balloon's page list and > * returns a list of the pages. > - * @b_dev_info: balloon device decriptor where we will grab a page from. > + * @b_dev_info: balloon device descriptor where we will grab a page from. > * @pages: pointer to the list of pages that would be returned to the caller. > * @n_req_pages: number of requested pages. > * > @@ -157,7 +157,7 @@ EXPORT_SYMBOL_GPL(balloon_page_enqueue); > /* > * balloon_page_dequeue - removes a page from balloon's page list and returns > * its address to allow the driver to release the page. > - * @b_dev_info: balloon device decriptor where we will grab a page from. > + * @b_dev_info: balloon device descriptor where we will grab a page from. > * > * Driver must call this function to properly dequeue a previously enqueued page > * before definitively releasing it back to the guest system. > -- > 2.25.1
Hello! On 09.06.2020 17:34, Kieran Bingham wrote: > The word 'descriptor' is misspelled throughout the tree. > > Fix it up accordingly: > decriptors -> descriptors decriptor -> descriptor really. ;-) > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Reviewed-by: David Hildenbrand <david@redhat.com> > --- > mm/balloon_compaction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c > index 26de020aae7b..907fefde2572 100644 > --- a/mm/balloon_compaction.c > +++ b/mm/balloon_compaction.c > @@ -58,7 +58,7 @@ EXPORT_SYMBOL_GPL(balloon_page_list_enqueue); > /** > * balloon_page_list_dequeue() - removes pages from balloon's page list and > * returns a list of the pages. > - * @b_dev_info: balloon device decriptor where we will grab a page from. > + * @b_dev_info: balloon device descriptor where we will grab a page from. > * @pages: pointer to the list of pages that would be returned to the caller. > * @n_req_pages: number of requested pages. > * > @@ -157,7 +157,7 @@ EXPORT_SYMBOL_GPL(balloon_page_enqueue); > /* > * balloon_page_dequeue - removes a page from balloon's page list and returns > * its address to allow the driver to release the page. > - * @b_dev_info: balloon device decriptor where we will grab a page from. > + * @b_dev_info: balloon device descriptor where we will grab a page from. > * > * Driver must call this function to properly dequeue a previously enqueued page > * before definitively releasing it back to the guest system. MBR, Sergei
Hi Sergei, On 10/06/2020 10:00, Sergei Shtylyov wrote: > Hello! > > On 09.06.2020 17:34, Kieran Bingham wrote: > >> The word 'descriptor' is misspelled throughout the tree. >> >> Fix it up accordingly: >> decriptors -> descriptors > > decriptor -> descriptor really. ;-) Ayeee ... that's what I get for doing a batch fixup ... Which - I believe I probably actually did a sed conversion on decriptor, anyway, so I'm not even sure why the commit messages ended up all pluralised ;-) Thanks for the highlight, I'll fix up in any resends. -- Kieran >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> >> Reviewed-by: David Hildenbrand <david@redhat.com> >> --- >> mm/balloon_compaction.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c >> index 26de020aae7b..907fefde2572 100644 >> --- a/mm/balloon_compaction.c >> +++ b/mm/balloon_compaction.c >> @@ -58,7 +58,7 @@ EXPORT_SYMBOL_GPL(balloon_page_list_enqueue); >> /** >> * balloon_page_list_dequeue() - removes pages from balloon's page >> list and >> * returns a list of the pages. >> - * @b_dev_info: balloon device decriptor where we will grab a page from. >> + * @b_dev_info: balloon device descriptor where we will grab a page >> from. >> * @pages: pointer to the list of pages that would be returned to >> the caller. >> * @n_req_pages: number of requested pages. >> * >> @@ -157,7 +157,7 @@ EXPORT_SYMBOL_GPL(balloon_page_enqueue); >> /* >> * balloon_page_dequeue - removes a page from balloon's page list >> and returns >> * its address to allow the driver to release the page. >> - * @b_dev_info: balloon device decriptor where we will grab a page from. >> + * @b_dev_info: balloon device descriptor where we will grab a page >> from. >> * >> * Driver must call this function to properly dequeue a previously >> enqueued page >> * before definitively releasing it back to the guest system. > > MBR, Sergei
diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index 26de020aae7b..907fefde2572 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -58,7 +58,7 @@ EXPORT_SYMBOL_GPL(balloon_page_list_enqueue); /** * balloon_page_list_dequeue() - removes pages from balloon's page list and * returns a list of the pages. - * @b_dev_info: balloon device decriptor where we will grab a page from. + * @b_dev_info: balloon device descriptor where we will grab a page from. * @pages: pointer to the list of pages that would be returned to the caller. * @n_req_pages: number of requested pages. * @@ -157,7 +157,7 @@ EXPORT_SYMBOL_GPL(balloon_page_enqueue); /* * balloon_page_dequeue - removes a page from balloon's page list and returns * its address to allow the driver to release the page. - * @b_dev_info: balloon device decriptor where we will grab a page from. + * @b_dev_info: balloon device descriptor where we will grab a page from. * * Driver must call this function to properly dequeue a previously enqueued page * before definitively releasing it back to the guest system.
The word 'descriptor' is misspelled throughout the tree. Fix it up accordingly: decriptors -> descriptors Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: David Hildenbrand <david@redhat.com> --- mm/balloon_compaction.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)