| Message ID | 20200704155856.3037010-2-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | d344234abde938ae1062edb6c05852b0bafb4a03 |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | ARM: dts: renesas: Cleanup ADV7180 bindings | expand |
Hi Niklas, On Sat, Jul 4, 2020 at 5:59 PM Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote: > When adding the adv7180 device node the ports node was misspelled as > port, fix this. > > Fixes: 8cae359049a88b75 ("ARM: dts: gose: add composite video input") > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Thanks for your patch! > --- a/arch/arm/boot/dts/r8a7793-gose.dts > +++ b/arch/arm/boot/dts/r8a7793-gose.dts > @@ -336,7 +336,7 @@ composite-in@20 { > reg = <0x20>; > remote = <&vin1>; > > - port { > + ports { > #address-cells = <1>; > #size-cells = <0>; > Does this have any run-time impact, or dependencies? Don't we need the same fix for the other boards? Gr{oetje,eeting}s, Geert
Hi Geert, On 2020-07-07 11:59:12 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Sat, Jul 4, 2020 at 5:59 PM Niklas Söderlund > <niklas.soderlund+renesas@ragnatech.se> wrote: > > When adding the adv7180 device node the ports node was misspelled as > > port, fix this. > > > > Fixes: 8cae359049a88b75 ("ARM: dts: gose: add composite video input") > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > Thanks for your patch! > > > --- a/arch/arm/boot/dts/r8a7793-gose.dts > > +++ b/arch/arm/boot/dts/r8a7793-gose.dts > > @@ -336,7 +336,7 @@ composite-in@20 { > > reg = <0x20>; > > remote = <&vin1>; > > > > - port { > > + ports { > > #address-cells = <1>; > > #size-cells = <0>; > > > > Does this have any run-time impact, or dependencies? No run-time impact. > Don't we need the same fix for the other boards? The only other board we have that uses the same compatible string (adi,adv7180cp) is Draak and there the ports node is already correctly named. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Niklas, On Mon, Jul 13, 2020 at 9:24 AM Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote: > On 2020-07-07 11:59:12 +0200, Geert Uytterhoeven wrote: > > On Sat, Jul 4, 2020 at 5:59 PM Niklas Söderlund > > <niklas.soderlund+renesas@ragnatech.se> wrote: > > > When adding the adv7180 device node the ports node was misspelled as > > > port, fix this. > > > > > > Fixes: 8cae359049a88b75 ("ARM: dts: gose: add composite video input") > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > > > Thanks for your patch! > > > > > --- a/arch/arm/boot/dts/r8a7793-gose.dts > > > +++ b/arch/arm/boot/dts/r8a7793-gose.dts > > > @@ -336,7 +336,7 @@ composite-in@20 { > > > reg = <0x20>; > > > remote = <&vin1>; > > > > > > - port { > > > + ports { > > > #address-cells = <1>; > > > #size-cells = <0>; > > > > > > > Does this have any run-time impact, or dependencies? > > No run-time impact. OK. > > Don't we need the same fix for the other boards? > > The only other board we have that uses the same compatible string > (adi,adv7180cp) is Draak and there the ports node is already correctly > named. Ah, I missed Gose is using "adi,adv7180cp", while Lager, Koelsch, Porter, Alt, and Silk are using "adi,adv7180". Next question: why the difference? Gose and Koelsch should be identical w.r.t. these interfaces. In fact all boards listed above are using ADV7180WBCP32Z, and seem to use similar wiring. What's happening? Thanks! Gr{oetje,eeting}s, Geert
Hi Geert, On 2020-07-13 09:51:08 +0200, Geert Uytterhoeven wrote: > > > Don't we need the same fix for the other boards? > > > > The only other board we have that uses the same compatible string > > (adi,adv7180cp) is Draak and there the ports node is already correctly > > named. > > Ah, I missed Gose is using "adi,adv7180cp", while Lager, Koelsch, Porter, > Alt, and Silk are using "adi,adv7180". > > Next question: why the difference? Gose and Koelsch should be identical > w.r.t. these interfaces. In fact all boards listed above are using > ADV7180WBCP32Z, and seem to use similar wiring. Good point. The difference as far as I can tell is only in the bindings. The older 'adi,adv7180' compatibility string only describes where the adv7180 is transmitting the data it collects from an undescribed connector. While the more recent compat string 'adi,adv7180cp' describes both the destination and the connector. A good example as you point out is to compare koelsch with gose. From a V4L2 point of view the connector being described does not effect the capture operation. Ulrich maybe you can help us shed some light on this as you added the new compat strings? > > What's happening? If I only knew ;-)
> On July 13, 2020 10:15 AM Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote: > The difference as far as I can tell is only in the bindings. The older > 'adi,adv7180' compatibility string only describes where the adv7180 is > transmitting the data it collects from an undescribed connector. While > the more recent compat string 'adi,adv7180cp' describes both the > destination and the connector. A good example as you point out is to > compare koelsch with gose. From a V4L2 point of view the connector being > described does not effect the capture operation. > > Ulrich maybe you can help us shed some light on this as you added the > new compat strings? Executive summary: "[Laurent and Hans] agreed that DT should model physical ports." Full details: https://www.mail-archive.com/linux-media@vger.kernel.org/msg103799.html The reason why it's only in Gose is that that was the patch series that raised the issue, and we didn't update the existing implementations. CU Uli
diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts index 79baf06019f5a6ff..a378b54867bb4d1f 100644 --- a/arch/arm/boot/dts/r8a7793-gose.dts +++ b/arch/arm/boot/dts/r8a7793-gose.dts @@ -336,7 +336,7 @@ composite-in@20 { reg = <0x20>; remote = <&vin1>; - port { + ports { #address-cells = <1>; #size-cells = <0>;
When adding the adv7180 device node the ports node was misspelled as port, fix this. Fixes: 8cae359049a88b75 ("ARM: dts: gose: add composite video input") Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- arch/arm/boot/dts/r8a7793-gose.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)