diff mbox series

[9/9] arm64: dts: renesas: r8a774e1-hihope-rzg2h: Setup DU clocks

Message ID 20200812140217.24251-10-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
State Accepted
Delegated to: Geert Uytterhoeven
Headers show
Series r8a774e1 add support for DU, HDMI and LVDS | expand

Commit Message

Lad Prabhakar Aug. 12, 2020, 2:02 p.m. UTC
Setup up the required clocks for the DU to be functional.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Laurent Pinchart Aug. 12, 2020, 4:36 p.m. UTC | #1
Hi Prabhakar,

Thank you for the patch.

On Wed, Aug 12, 2020 at 03:02:17PM +0100, Lad Prabhakar wrote:
> Setup up the required clocks for the DU to be functional.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts b/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts
> index cdbe527e9340..12f9242e263b 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts
> @@ -24,3 +24,14 @@
>  		reg = <0x5 0x00000000 0x0 0x80000000>;
>  	};
>  };
> +
> +&du {
> +	clocks = <&cpg CPG_MOD 724>,
> +		 <&cpg CPG_MOD 723>,
> +		 <&cpg CPG_MOD 721>,
> +		 <&versaclock5 1>,
> +		 <&x302_clk>,
> +		 <&versaclock5 2>;
> +	clock-names = "du.0", "du.1", "du.3",
> +		      "dclkin.0", "dclkin.1", "dclkin.3";

I have no reason to doubt this is correct, but I also can't assess that
as I don't have access to the schematics.

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +};
Geert Uytterhoeven Aug. 13, 2020, 9:19 a.m. UTC | #2
On Wed, Aug 12, 2020 at 4:03 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Setup up the required clocks for the DU to be functional.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.10 (after resolving the port numbering).

Gr{oetje,eeting}s,

                        Geert
Laurent Pinchart Aug. 13, 2020, 12:57 p.m. UTC | #3
On Wed, Aug 12, 2020 at 07:36:54PM +0300, Laurent Pinchart wrote:
> Hi Prabhakar,
> 
> Thank you for the patch.
> 
> On Wed, Aug 12, 2020 at 03:02:17PM +0100, Lad Prabhakar wrote:
> > Setup up the required clocks for the DU to be functional.
> > 
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> >  arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts b/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts
> > index cdbe527e9340..12f9242e263b 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts
> > @@ -24,3 +24,14 @@
> >  		reg = <0x5 0x00000000 0x0 0x80000000>;
> >  	};
> >  };
> > +
> > +&du {
> > +	clocks = <&cpg CPG_MOD 724>,
> > +		 <&cpg CPG_MOD 723>,
> > +		 <&cpg CPG_MOD 721>,
> > +		 <&versaclock5 1>,
> > +		 <&x302_clk>,
> > +		 <&versaclock5 2>;
> > +	clock-names = "du.0", "du.1", "du.3",
> > +		      "dclkin.0", "dclkin.1", "dclkin.3";
> 
> I have no reason to doubt this is correct, but I also can't assess that
> as I don't have access to the schematics.
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Upgrading to

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

:-)

> 
> > +};
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts b/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts
index cdbe527e9340..12f9242e263b 100644
--- a/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts
+++ b/arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h.dts
@@ -24,3 +24,14 @@ 
 		reg = <0x5 0x00000000 0x0 0x80000000>;
 	};
 };
+
+&du {
+	clocks = <&cpg CPG_MOD 724>,
+		 <&cpg CPG_MOD 723>,
+		 <&cpg CPG_MOD 721>,
+		 <&versaclock5 1>,
+		 <&x302_clk>,
+		 <&versaclock5 2>;
+	clock-names = "du.0", "du.1", "du.3",
+		      "dclkin.0", "dclkin.1", "dclkin.3";
+};