diff mbox series

[v2,3/3] ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication

Message ID 20200907155541.2011-4-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
State Accepted
Delegated to: Geert Uytterhoeven
Headers show
Series iWave G21D-Q7 enable flash, CAN and SD2 LED | expand

Commit Message

Lad Prabhakar Sept. 7, 2020, 3:55 p.m. UTC 
Add support for LED trigger on SD2 interface.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a7742-iwg21d-q7.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Geert Uytterhoeven Sept. 10, 2020, 9:05 a.m. UTC | #1 
On Mon, Sep 7, 2020 at 5:56 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Add support for LED trigger on SD2 interface.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks for the update, will queue in renesas-devel for v5.10.

Gr{oetje,eeting}s,

                        Geert
Pavel Machek Oct. 9, 2020, 7:33 a.m. UTC | #2 
Hi!

> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
> @@ -63,6 +63,16 @@
>  		enable-gpios = <&gpio3 11 GPIO_ACTIVE_HIGH>;
>  	};
>  
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		sdhi2_led {
> +			label = "sdio-led";

This should use appropriate label... probably mmc1:green:activity.

Best regards,
									Pavel
Prabhakar Oct. 9, 2020, 8:41 a.m. UTC | #3 
Hi Pavel,

Thank you for the review.

On Fri, Oct 9, 2020 at 8:33 AM Pavel Machek <pavel@denx.de> wrote:
>
> Hi!
>
> > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
> > @@ -63,6 +63,16 @@
> >               enable-gpios = <&gpio3 11 GPIO_ACTIVE_HIGH>;
> >       };
> >
> > +     leds {
> > +             compatible = "gpio-leds";
> > +
> > +             sdhi2_led {
> > +                     label = "sdio-led";
>
> This should use appropriate label... probably mmc1:green:activity.
>
$ grep -nr mmc | grep -i activity
$ grep -nr  sd | grep -i activity

Results in 0 outputs in dts folder.

Cheers,
Prabhakar
Pavel Machek Oct. 9, 2020, 5:36 p.m. UTC | #4 
Hi!

> Thank you for the review.

Note I'm LED maintainer.

> > > +     leds {
> > > +             compatible = "gpio-leds";
> > > +
> > > +             sdhi2_led {
> > > +                     label = "sdio-led";
> >
> > This should use appropriate label... probably mmc1:green:activity.
> >
> $ grep -nr mmc | grep -i activity
> $ grep -nr  sd | grep -i activity
> 
> Results in 0 outputs in dts folder.

Well, so does

grep -ri label.*sdio-led arch/arm*

:-). Feel free to suggest other name following documentation in
Documentation/leds/leds-class.rst .

(And yes, we have lot of work to get this to some kind of consistent
state).

								Pavel
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
index 66881a473d6c..e45b502d61cb 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
@@ -63,6 +63,16 @@ 
 		enable-gpios = <&gpio3 11 GPIO_ACTIVE_HIGH>;
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		sdhi2_led {
+			label = "sdio-led";
+			gpios = <&gpio5 22 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "mmc1";
+		};
+	};
+
 	lvds-receiver {
 		compatible = "ti,ds90cf384a", "lvds-decoder";
 		vcc-supply = <&vcc_3v3_tft1>;