| Message ID | 20200915140110.11268-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [-next] soc: renesas: r8a779a0-sysc: Make r8a779a0_sysc_info static | expand |
On 2020/9/15 23:22, Geert Uytterhoeven wrote: > Hi Yue, > > On Tue, Sep 15, 2020 at 4:58 PM YueHaibing <yuehaibing@huawei.com> wrote: >> Fix sparse warning: >> >> drivers/soc/renesas/r8a779a0-sysc.c:99:33: warning: symbol 'r8a779a0_sysc_info' was not declared. Should it be static? >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > As commit 7f29315cf4211316 ("soc: renesas: r8a779a0-sysc: Add r8a779a0 > support") hasn't been merged into arm-soc yet, is it OK for you if I > just fold your fix into the original commit? Sure, it's ok for me. > > Thanks again! > >> --- a/drivers/soc/renesas/r8a779a0-sysc.c >> +++ b/drivers/soc/renesas/r8a779a0-sysc.c >> @@ -96,7 +96,7 @@ static struct r8a779a0_sysc_area r8a779a0_areas[] __initdata = { >> { "a1dsp1", R8A779A0_PD_A1DSP1, R8A779A0_PD_A2CN1 }, >> }; >> >> -const struct r8a779a0_sysc_info r8a779a0_sysc_info __initconst = { >> +static const struct r8a779a0_sysc_info r8a779a0_sysc_info __initconst = { >> .areas = r8a779a0_areas, >> .num_areas = ARRAY_SIZE(r8a779a0_areas), >> }; > > Gr{oetje,eeting}s, > > Geert >
Hi Yue, On Wed, Sep 16, 2020 at 3:26 AM Yuehaibing <yuehaibing@huawei.com> wrote: > On 2020/9/15 23:22, Geert Uytterhoeven wrote: > > On Tue, Sep 15, 2020 at 4:58 PM YueHaibing <yuehaibing@huawei.com> wrote: > >> Fix sparse warning: > >> > >> drivers/soc/renesas/r8a779a0-sysc.c:99:33: warning: symbol 'r8a779a0_sysc_info' was not declared. Should it be static? > >> > >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > > > Thanks for your patch! > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > As commit 7f29315cf4211316 ("soc: renesas: r8a779a0-sysc: Add r8a779a0 > > support") hasn't been merged into arm-soc yet, is it OK for you if I > > just fold your fix into the original commit? > > Sure, it's ok for me. Thank you, I've updated the commit in my rrenesas-devel/renesas-drivers-for-v5.10 branch. The renesas-devel/next branch will be updated later. Gr{oetje,eeting}s, Geert
diff --git a/drivers/soc/renesas/r8a779a0-sysc.c b/drivers/soc/renesas/r8a779a0-sysc.c index 09dac5742c60..d464ffa1be33 100644 --- a/drivers/soc/renesas/r8a779a0-sysc.c +++ b/drivers/soc/renesas/r8a779a0-sysc.c @@ -96,7 +96,7 @@ static struct r8a779a0_sysc_area r8a779a0_areas[] __initdata = { { "a1dsp1", R8A779A0_PD_A1DSP1, R8A779A0_PD_A2CN1 }, }; -const struct r8a779a0_sysc_info r8a779a0_sysc_info __initconst = { +static const struct r8a779a0_sysc_info r8a779a0_sysc_info __initconst = { .areas = r8a779a0_areas, .num_areas = ARRAY_SIZE(r8a779a0_areas), };
Fix sparse warning: drivers/soc/renesas/r8a779a0-sysc.c:99:33: warning: symbol 'r8a779a0_sysc_info' was not declared. Should it be static? Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/soc/renesas/r8a779a0-sysc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)