diff mbox series

[net-netx] net: renesas: sh_eth: suppress initialized field overwritten warning

Message ID 20200919105945.251532-1-liujian56@huawei.com
State Under Review
Delegated to: Geert Uytterhoeven
Headers show
Series [net-netx] net: renesas: sh_eth: suppress initialized field overwritten warning | expand

Commit Message

Liu Jian Sept. 19, 2020, 10:59 a.m. UTC
Suppress a bunch of warnings of the form:

drivers/net/ethernet/renesas/sh_eth.c:100:13: warning: initialized field overwritten [-Woverride-init]

This is because after the sh_eth_offset_xxx array is initialized to SH_ETH_OFFSET_INVALID,
some specific register_offsets are re-initialized. It wasn't a mistake.

Signed-off-by: Liu Jian <liujian56@huawei.com>
---
 drivers/net/ethernet/renesas/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

David Miller Sept. 20, 2020, 9:28 p.m. UTC | #1
From: Liu Jian <liujian56@huawei.com>
Date: Sat, 19 Sep 2020 18:59:45 +0800

> Suppress a bunch of warnings of the form:
> 
> drivers/net/ethernet/renesas/sh_eth.c:100:13: warning: initialized field overwritten [-Woverride-init]
> 
> This is because after the sh_eth_offset_xxx array is initialized to SH_ETH_OFFSET_INVALID,
> some specific register_offsets are re-initialized. It wasn't a mistake.
> 
> Signed-off-by: Liu Jian <liujian56@huawei.com>

Even if I agreed with this approach to the fix, you can't just blindly
add a CFLAG option.  What if the compile doesn't understand or support
that option?

I leave it to the patch submitter to grep the Makefiles in the tree to
learn how to handle this situation properly, because that's how I
learned what the right thing to do since I wasn't sure.

But in the end I think just sticking a warning disable here and there
isn't the solution.  I think this driver should explicitly initialize
the array entries that are invalid on each and every chip.

No only does that get rid of the warnings cleanly, but it also more
clearly documents the available register set.  Currently you have to
walk each and every enumeration value in the sh_eth.h header and
see if the table has it or not, in order to figure out which registers
are _not_ present for a chip.

Thank you.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/renesas/Makefile b/drivers/net/ethernet/renesas/Makefile
index f21ab8c02af0..ccb8521d190b 100644
--- a/drivers/net/ethernet/renesas/Makefile
+++ b/drivers/net/ethernet/renesas/Makefile
@@ -3,6 +3,7 @@ 
 # Makefile for the Renesas device drivers.
 #
 
+CFLAGS_sh_eth.o += -Wno-override-init
 obj-$(CONFIG_SH_ETH) += sh_eth.o
 
 ravb-objs := ravb_main.o ravb_ptp.o