diff mbox series

[1/4] gpio: rcar: Cache gpiochip_get_data() return value

Message ID 20201028141504.1729093-2-geert+renesas@glider.be
State Under Review
Delegated to: Geert Uytterhoeven
Headers show
Series gpio: rcar: Cleanups and improvements | expand

Commit Message

Geert Uytterhoeven Oct. 28, 2020, 2:15 p.m. UTC
Since commit 43c54ecade400cf6 ("gpio: move the subdriver data pointer
into gpio_device") changed gpiochip_get_data() to an out-of-line
function, it is now worthwhile to avoid multiple calls in a row by
caching its return value in a local variable.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
 drivers/gpio/gpio-rcar.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff mbox series


diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 3ef19cef8da9b240..a75bbc9af1f14b06 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -295,14 +295,15 @@  static int gpio_rcar_direction_input(struct gpio_chip *chip, unsigned offset)
 static int gpio_rcar_get(struct gpio_chip *chip, unsigned offset)
+	struct gpio_rcar_priv *p = gpiochip_get_data(chip);
 	u32 bit = BIT(offset);
 	/* testing on r8a7790 shows that INDT does not show correct pin state
 	 * when configured as output, so use OUTDT in case of output pins */
-	if (gpio_rcar_read(gpiochip_get_data(chip), INOUTSEL) & bit)
-		return !!(gpio_rcar_read(gpiochip_get_data(chip), OUTDT) & bit);
+	if (gpio_rcar_read(p, INOUTSEL) & bit)
+		return !!(gpio_rcar_read(p, OUTDT) & bit);
-		return !!(gpio_rcar_read(gpiochip_get_data(chip), INDT) & bit);
+		return !!(gpio_rcar_read(p, INDT) & bit);
 static void gpio_rcar_set(struct gpio_chip *chip, unsigned offset, int value)