| Message ID | 20201103162435.13689-4-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [1/8] clk: pwm: drop of_match_ptr from of_device_id table | expand |
Quoting Krzysztof Kozlowski (2020-11-03 08:24:31) > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might be not relevant here). This > fixes compile warning (!CONFIG_OF && !CONFIG_MODULES): > > drivers/clk/imx/clk-imx8mp.c:751:34: warning: > ‘imx8mp_clk_of_match’ defined but not used [-Wunused-const-variable=] > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- Acked-by: Stephen Boyd <sboyd@kernel.org>
On Tue, Nov 03, 2020 at 05:24:31PM +0100, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might be not relevant here). This > fixes compile warning (!CONFIG_OF && !CONFIG_MODULES): > > drivers/clk/imx/clk-imx8mp.c:751:34: warning: > ‘imx8mp_clk_of_match’ defined but not used [-Wunused-const-variable=] > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Applied, thanks.
diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c index 12ce4770f702..5295a5156ab0 100644 --- a/drivers/clk/imx/clk-imx8mp.c +++ b/drivers/clk/imx/clk-imx8mp.c @@ -763,7 +763,7 @@ static struct platform_driver imx8mp_clk_driver = { * reloading the driver will crash or break devices. */ .suppress_bind_attrs = true, - .of_match_table = of_match_ptr(imx8mp_clk_of_match), + .of_match_table = imx8mp_clk_of_match, }, }; module_platform_driver(imx8mp_clk_driver);
The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might be not relevant here). This fixes compile warning (!CONFIG_OF && !CONFIG_MODULES): drivers/clk/imx/clk-imx8mp.c:751:34: warning: ‘imx8mp_clk_of_match’ defined but not used [-Wunused-const-variable=] Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/clk/imx/clk-imx8mp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)