diff mbox series

[3/3] arm64: dts: update device trees to specify clock-frequency in imx219 node

Message ID 20201205183355.6488-3-michael.srba@seznam.cz (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series [1/3] media: i2c: imx219: add support for specifying clock-frequencies | expand

Commit Message

Michael Srba Dec. 5, 2020, 6:33 p.m. UTC 
From: Michael Srba <Michael.Srba@seznam.cz>

This patch adds the clock-frequency property to all device trees that use
the imx219 binding, with the value of exactly 24Mhz which was previously
implicitly assumed.

Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
---
 arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi | 1 +
 arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts        | 1 +
 2 files changed, 2 insertions(+)

Comments

Geert Uytterhoeven Dec. 5, 2020, 6:55 p.m. UTC | #1 
Hi Michael,

On Sat, Dec 5, 2020 at 7:36 PM <michael.srba@seznam.cz> wrote:
> From: Michael Srba <Michael.Srba@seznam.cz>
>
> This patch adds the clock-frequency property to all device trees that use
> the imx219 binding, with the value of exactly 24Mhz which was previously
> implicitly assumed.
>
> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
> @@ -82,6 +82,7 @@ imx219: imx219@10 {
>                 compatible = "sony,imx219";
>                 reg = <0x10>;
>                 clocks = <&osc25250_clk>;
> +               clock-frequency = <24000000>;
>                 VANA-supply = <&imx219_vana_2v8>;
>                 VDIG-supply = <&imx219_vdig_1v8>;
>                 VDDL-supply = <&imx219_vddl_1v2>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
> index f0829e905506..db4b801b17b5 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
> @@ -59,6 +59,7 @@ &imx219 {
>         port {
>                 imx219_ep: endpoint {
>                         clock-lanes = <0>;
> +                       clock-frequency = <24000000>;

Why is this change needed? This is not the imx219 node, but its endpoint
subnode (the imx219 is imported from aistarvision-mipi-adapter-2.1.dtsi).

>                         data-lanes = <1 2>;
>                         link-frequencies = /bits/ 64 <456000000>;
>                         /* uncomment remote-endpoint property to tie imx219 to
-
Gr{oetje,eeting}s,

                        Geert
Michael Srba Dec. 6, 2020, 5:20 p.m. UTC | #2 
> Hi Michael,
>
> On Sat, Dec 5, 2020 at 7:36 PM <michael.srba@seznam.cz> wrote:
>> From: Michael Srba <Michael.Srba@seznam.cz>
>>
>> This patch adds the clock-frequency property to all device trees that use
>> the imx219 binding, with the value of exactly 24Mhz which was previously
>> implicitly assumed.
>>
>> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
> Thanks for your patch!
>
>> --- a/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
>> @@ -82,6 +82,7 @@ imx219: imx219@10 {
>>                 compatible = "sony,imx219";
>>                 reg = <0x10>;
>>                 clocks = <&osc25250_clk>;
>> +               clock-frequency = <24000000>;
>>                 VANA-supply = <&imx219_vana_2v8>;
>>                 VDIG-supply = <&imx219_vdig_1v8>;
>>                 VDDL-supply = <&imx219_vddl_1v2>;
>> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
>> index f0829e905506..db4b801b17b5 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
>> @@ -59,6 +59,7 @@ &imx219 {
>>         port {
>>                 imx219_ep: endpoint {
>>                         clock-lanes = <0>;
>> +                       clock-frequency = <24000000>;
> Why is this change needed? This is not the imx219 node, but its endpoint
> subnode (the imx219 is imported from aistarvision-mipi-adapter-2.1.dtsi).
My bad, I must have been really tired.
will rectify this

>>                         data-lanes = <1 2>;
>>                         link-frequencies = /bits/ 64 <456000000>;
>>                         /* uncomment remote-endpoint property to tie imx219 to
> -
> Gr{oetje,eeting}s,
>
>                         Geert
>
Michael
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi b/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
index dac6ff49020f..986c6c1f7312 100644
--- a/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
+++ b/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
@@ -82,6 +82,7 @@  imx219: imx219@10 {
 		compatible = "sony,imx219";
 		reg = <0x10>;
 		clocks = <&osc25250_clk>;
+		clock-frequency = <24000000>;
 		VANA-supply = <&imx219_vana_2v8>;
 		VDIG-supply = <&imx219_vdig_1v8>;
 		VDDL-supply = <&imx219_vddl_1v2>;
diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
index f0829e905506..db4b801b17b5 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
+++ b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
@@ -59,6 +59,7 @@  &imx219 {
 	port {
 		imx219_ep: endpoint {
 			clock-lanes = <0>;
+			clock-frequency = <24000000>;
 			data-lanes = <1 2>;
 			link-frequencies = /bits/ 64 <456000000>;
 			/* uncomment remote-endpoint property to tie imx219 to