diff mbox series

[1/5] clk: renesas: r8a7795: Add TMU clocks

Message ID 20201209195343.803120-2-niklas.soderlund+renesas@ragnatech.se (mailing list archive)
State Under Review
Delegated to: Geert Uytterhoeven
Headers show
Series clk: renesas: Add TMU clocks | expand

Commit Message

Niklas Söderlund Dec. 9, 2020, 7:53 p.m. UTC
This patch adds TMU{0,1,2,3,4} clocks.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 drivers/clk/renesas/r8a7795-cpg-mssr.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Geert Uytterhoeven Dec. 10, 2020, 12:32 p.m. UTC | #1
Hi Niklas,

On Wed, Dec 9, 2020 at 8:54 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> This patch adds TMU{0,1,2,3,4} clocks.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks for your patch!

> --- a/drivers/clk/renesas/r8a7795-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c
> @@ -128,6 +128,11 @@ static struct mssr_mod_clk r8a7795_mod_clks[] __initdata = {
>         DEF_MOD("fdp1-2",                117,   R8A7795_CLK_S2D1), /* ES1.x */
>         DEF_MOD("fdp1-1",                118,   R8A7795_CLK_S0D1),
>         DEF_MOD("fdp1-0",                119,   R8A7795_CLK_S0D1),
> +       DEF_MOD("tmu4",                  121,   R8A7795_CLK_S0D6),

The above is correct for R-Car H3 ES2.0 and later.
On R-Car H3 ES1.x, the parent clock of TMU4 is S3D2 (datasheet rev 0.52),
so you need to add an entry to r8a7795es1_mod_reparent[].

> +       DEF_MOD("tmu3",                  122,   R8A7795_CLK_S3D2),
> +       DEF_MOD("tmu2",                  123,   R8A7795_CLK_S3D2),
> +       DEF_MOD("tmu1",                  124,   R8A7795_CLK_S3D2),
> +       DEF_MOD("tmu0",                  125,   R8A7795_CLK_CP),
>         DEF_MOD("scif5",                 202,   R8A7795_CLK_S3D4),
>         DEF_MOD("scif4",                 203,   R8A7795_CLK_S3D4),
>         DEF_MOD("scif3",                 204,   R8A7795_CLK_S3D4),

The rest looks good to me.

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/drivers/clk/renesas/r8a7795-cpg-mssr.c b/drivers/clk/renesas/r8a7795-cpg-mssr.c
index 068018ae3c6e2254..a2102106fad2d01a 100644
--- a/drivers/clk/renesas/r8a7795-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c
@@ -128,6 +128,11 @@  static struct mssr_mod_clk r8a7795_mod_clks[] __initdata = {
 	DEF_MOD("fdp1-2",		 117,	R8A7795_CLK_S2D1), /* ES1.x */
 	DEF_MOD("fdp1-1",		 118,	R8A7795_CLK_S0D1),
 	DEF_MOD("fdp1-0",		 119,	R8A7795_CLK_S0D1),
+	DEF_MOD("tmu4",			 121,	R8A7795_CLK_S0D6),
+	DEF_MOD("tmu3",			 122,	R8A7795_CLK_S3D2),
+	DEF_MOD("tmu2",			 123,	R8A7795_CLK_S3D2),
+	DEF_MOD("tmu1",			 124,	R8A7795_CLK_S3D2),
+	DEF_MOD("tmu0",			 125,	R8A7795_CLK_CP),
 	DEF_MOD("scif5",		 202,	R8A7795_CLK_S3D4),
 	DEF_MOD("scif4",		 203,	R8A7795_CLK_S3D4),
 	DEF_MOD("scif3",		 204,	R8A7795_CLK_S3D4),