| Message ID | 20201213183759.223246-3-aford173@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: Cleanup Beacon Kit and support more SoC's | expand |
On Sun, Dec 13, 2020 at 7:38 PM Adam Ford <aford173@gmail.com> wrote: > The Bluetooth chip is capable of operating at 4Mbps, but the > max-speed setting was on the UART node instead of the Bluetooth > node, so the chip didn't operate at the correct speed resulting > in choppy audio. Fix this by setting the max-speed in the proper > node. > > Fixes: a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit") > Signed-off-by: Adam Ford <aford173@gmail.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v5.12. Gr{oetje,eeting}s, Geert
On Thu, Dec 17, 2020 at 4:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Sun, Dec 13, 2020 at 7:38 PM Adam Ford <aford173@gmail.com> wrote: > > The Bluetooth chip is capable of operating at 4Mbps, but the > > max-speed setting was on the UART node instead of the Bluetooth > > node, so the chip didn't operate at the correct speed resulting > > in choppy audio. Fix this by setting the max-speed in the proper > > node. > > > > Fixes: a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit") > > Signed-off-by: Adam Ford <aford173@gmail.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-devel for v5.12. Since various other patches in the series need a V2, should this be included in the V2 as no-change, or should I skip this and others that have been queued? If/when they appear in your branch, I can rebase the series against that branch and just submit V2's on what's missing. I want to do whatever creates less work for you. adam > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Adam, On Thu, Dec 17, 2020 at 1:16 PM Adam Ford <aford173@gmail.com> wrote: > On Thu, Dec 17, 2020 at 4:41 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Sun, Dec 13, 2020 at 7:38 PM Adam Ford <aford173@gmail.com> wrote: > > > The Bluetooth chip is capable of operating at 4Mbps, but the > > > max-speed setting was on the UART node instead of the Bluetooth > > > node, so the chip didn't operate at the correct speed resulting > > > in choppy audio. Fix this by setting the max-speed in the proper > > > node. > > > > > > Fixes: a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit") > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > i.e. will queue in renesas-devel for v5.12. > > Since various other patches in the series need a V2, should this be > included in the V2 as no-change, or should I skip this and others that > have been queued? If/when they appear in your branch, I can rebase > the series against that branch and just submit V2's on what's missing. > > I want to do whatever creates less work for you. I think it's best to postpone v2 until I have queued up the accepted patches in renesas-devel. Probably that will happen on Monday. Thanks! Gr{oetje,eeting}s, Geert
diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi index 449ff5937fc6..c50f8e63c80f 100644 --- a/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi @@ -90,7 +90,6 @@ &hscif0 { pinctrl-names = "default"; uart-has-rtscts; status = "okay"; - max-speed = <4000000>; bluetooth { compatible = "brcm,bcm43438-bt"; @@ -99,6 +98,7 @@ bluetooth { device-wakeup-gpios = <&pca9654 5 GPIO_ACTIVE_HIGH>; clocks = <&osc_32k>; clock-names = "extclk"; + max-speed = <4000000>; }; };
The Bluetooth chip is capable of operating at 4Mbps, but the max-speed setting was on the UART node instead of the Bluetooth node, so the chip didn't operate at the correct speed resulting in choppy audio. Fix this by setting the max-speed in the proper node. Fixes: a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit") Signed-off-by: Adam Ford <aford173@gmail.com> --- arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)