| Message ID | 20210216174146.106639-16-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | media: i2c: GMSL reliability improvements | expand |
On 16/02/2021 17:41, Jacopo Mondi wrote: > Re-phrase a comment in .bound() callback to make it clear we register > a subdev notifier and remove a redundant comment about disabling i2c > auto-ack. > > No functional changes intended. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > drivers/media/i2c/max9286.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c > index c41284de89b6..aa01d5bb79ef 100644 > --- a/drivers/media/i2c/max9286.c > +++ b/drivers/media/i2c/max9286.c > @@ -567,9 +567,9 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier, > } > > /* > - * We can only register v4l2_async_notifiers, which do not provide a > - * means to register a complete callback. bound_sources allows us to > - * identify when all remote serializers have completed their probe. > + * As we register a subdev notifiers we won't get a .complete() callback > + * here, so we have to use bound_sources to identify when all remote > + * serializers have probed. s/subdev notifiers/subdev notifier/ ? ... I'm not sure that helps me ? :S > */ > if (priv->bound_sources != priv->source_mask) { > /* > @@ -583,16 +583,12 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier, > /* > * All enabled sources have probed and enabled their reverse control > * channels: > + * - The reverse channel amplitude stays high Isn't this part of the previous patch? > * - Verify all configuration links are properly detected > - * - Disable auto-ack as communication on the control channel are now > - * stable. > + * - Disable auto-ack as communications on the control channel are now > + * stable > */ > max9286_check_config_link(priv, priv->source_mask); > - > - /* > - * Re-configure I2C with local acknowledge disabled after cameras have > - * probed. > - */ > max9286_configure_i2c(priv, false); > > return max9286_set_pixelrate(priv); >
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index c41284de89b6..aa01d5bb79ef 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -567,9 +567,9 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier, } /* - * We can only register v4l2_async_notifiers, which do not provide a - * means to register a complete callback. bound_sources allows us to - * identify when all remote serializers have completed their probe. + * As we register a subdev notifiers we won't get a .complete() callback + * here, so we have to use bound_sources to identify when all remote + * serializers have probed. */ if (priv->bound_sources != priv->source_mask) { /* @@ -583,16 +583,12 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier, /* * All enabled sources have probed and enabled their reverse control * channels: + * - The reverse channel amplitude stays high * - Verify all configuration links are properly detected - * - Disable auto-ack as communication on the control channel are now - * stable. + * - Disable auto-ack as communications on the control channel are now + * stable */ max9286_check_config_link(priv, priv->source_mask); - - /* - * Re-configure I2C with local acknowledge disabled after cameras have - * probed. - */ max9286_configure_i2c(priv, false); return max9286_set_pixelrate(priv);
Re-phrase a comment in .bound() callback to make it clear we register a subdev notifier and remove a redundant comment about disabling i2c auto-ack. No functional changes intended. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- drivers/media/i2c/max9286.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-)