| Message ID | 20210225225147.29920-8-fabrizio.castro.jz@renesas.com (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add FFT Support for R-Car Gen3 devices | expand |
Hi Fabrizio, Thank you for the patch. On Thu, Feb 25, 2021 at 10:51:47PM +0000, Fabrizio Castro wrote: > Make sure that the R-Car DAB device driver gets compiled as a > module since R-Car E3 and R-Car M3-N come with the DAB IP. > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> Do we need this in the defconfig ? It's not required to have a bootable E3 or M3-N with the set of standard features, and would result in all ARM64 platforms having one module they don't care about. > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index d612f633b771..3b9996c7f1fc 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -274,6 +274,7 @@ CONFIG_PCI_ENDPOINT_TEST=m > CONFIG_EEPROM_AT24=m > CONFIG_EEPROM_AT25=m > CONFIG_UACCE=m > +CONFIG_RCAR_DAB=m > # CONFIG_SCSI_PROC_FS is not set > CONFIG_BLK_DEV_SD=y > CONFIG_SCSI_SAS_ATA=y
Hi Laurent, On Fri, Feb 26, 2021 at 1:53 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Thu, Feb 25, 2021 at 10:51:47PM +0000, Fabrizio Castro wrote: > > Make sure that the R-Car DAB device driver gets compiled as a > > module since R-Car E3 and R-Car M3-N come with the DAB IP. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > > Do we need this in the defconfig ? It's not required to have a bootable > E3 or M3-N with the set of standard features, and would result in all That's why it's modular. > ARM64 platforms having one module they don't care about. We typically add all drivers used by all supported platforms, to increase build coverage. Gr{oetje,eeting}s, Geert
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index d612f633b771..3b9996c7f1fc 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -274,6 +274,7 @@ CONFIG_PCI_ENDPOINT_TEST=m CONFIG_EEPROM_AT24=m CONFIG_EEPROM_AT25=m CONFIG_UACCE=m +CONFIG_RCAR_DAB=m # CONFIG_SCSI_PROC_FS is not set CONFIG_BLK_DEV_SD=y CONFIG_SCSI_SAS_ATA=y
Make sure that the R-Car DAB device driver gets compiled as a module since R-Car E3 and R-Car M3-N come with the DAB IP. Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)