diff mbox series

[RFT,2/2] mmc: tmio: always flag retune when resetting and a card is present

Message ID 20210316085717.7276-3-wsa+renesas@sang-engineering.com (mailing list archive)
State Accepted
Delegated to: Geert Uytterhoeven
Headers show
Series mmc: tmio: make resets more robust | expand

Commit Message

Wolfram Sang March 16, 2021, 8:57 a.m. UTC
After reset, we manually flagged retune in runtime resume, but missed it
in the workqueue. To fix that and avoid the problem in the future, let's
flag retune in the reset handler directly whenever a card is present.

Reported-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
 drivers/mmc/host/tmio_mmc_core.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox series


diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
index 3755f606b8db..2e85e40f50f9 100644
--- a/drivers/mmc/host/tmio_mmc_core.c
+++ b/drivers/mmc/host/tmio_mmc_core.c
@@ -198,6 +198,9 @@  static void tmio_mmc_reset(struct tmio_mmc_host *host)
 		sd_ctrl_write16(host, CTL_SDIO_IRQ_MASK, host->sdio_irq_mask);
 		sd_ctrl_write16(host, CTL_TRANSACTION_CTL, 0x0001);
+	if (host->mmc->card)
+		mmc_retune_needed(host->mmc);
 static void tmio_mmc_reset_work(struct work_struct *work)
@@ -1290,8 +1293,6 @@  int tmio_mmc_host_runtime_resume(struct device *dev)
 	tmio_mmc_enable_dma(host, true);
-	mmc_retune_needed(host->mmc);
 	return 0;